[Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

[Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

[Baruch Siach]

Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
as well.

Cc: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/libnftnl/Config.in | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/package/libnftnl/Config.in b/package/libnftnl/Config.in
index d4c9a1bb54e3..65390011a983 100644
--- a/package/libnftnl/Config.in
+++ b/package/libnftnl/Config.in
@@ -22,13 +22,6 @@ config BR2_PACKAGE_LIBNFTNL_JSON
 	help
 	  Enable JSON parsing support
 
-config BR2_PACKAGE_LIBNFTNL_XML
-	bool "enable XML support"
-	depends on BR2_TOOLCHAIN_HAS_THREADS
-	select BR2_PACKAGE_MXML
-	help
-	  Enable XML parsing support
-
 comment "libnftnl XML parsing support needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
-- 
2.19.1

[Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

[Thomas Petazzoni]

Hello,

On Tue, 13 Nov 2018 21:59:08 +0200, Baruch Siach wrote:
> Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
> dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
> as well.
> 
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Do we need Config.in.legacy handling ?

We normally add Config.in.legacy handling when removing options, but on
the other hand, this option has had no effect since 2018.02.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML

[Arnout Vandecappelle]

On 13/11/2018 21:21, Thomas Petazzoni wrote:
> Hello,
> 
> On Tue, 13 Nov 2018 21:59:08 +0200, Baruch Siach wrote:
>> Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
>> dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
>> as well.
>>
>> Cc: Yegor Yefremov <yegorslists@googlemail.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Do we need Config.in.legacy handling ?
> 
> We normally add Config.in.legacy handling when removing options, but on
> the other hand, this option has had no effect since 2018.02.

 Legacy handling is there mostly to make sure the appropriate alternative option
can be selected. In this case there is no alternative.

 Also, compare this to a situation where it would have been an automatic
optional dependency: in that case, the feature also disappears silently.

 That said: legacy handling costs nothing and can be useful for some users. And
it can be backported to 2018.02.x.

 Regards,
 Arnout