* [Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML
@ 2018-11-13 19:59 Baruch Siach
2018-11-13 20:21 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2018-11-13 19:59 UTC (permalink / raw)
To: buildroot
Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
as well.
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/libnftnl/Config.in | 7 -------
1 file changed, 7 deletions(-)
diff --git a/package/libnftnl/Config.in b/package/libnftnl/Config.in
index d4c9a1bb54e3..65390011a983 100644
--- a/package/libnftnl/Config.in
+++ b/package/libnftnl/Config.in
@@ -22,13 +22,6 @@ config BR2_PACKAGE_LIBNFTNL_JSON
help
Enable JSON parsing support
-config BR2_PACKAGE_LIBNFTNL_XML
- bool "enable XML support"
- depends on BR2_TOOLCHAIN_HAS_THREADS
- select BR2_PACKAGE_MXML
- help
- Enable XML parsing support
-
comment "libnftnl XML parsing support needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML
2018-11-13 19:59 [Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML Baruch Siach
@ 2018-11-13 20:21 ` Thomas Petazzoni
2018-11-13 23:42 ` Arnout Vandecappelle
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-13 20:21 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 13 Nov 2018 21:59:08 +0200, Baruch Siach wrote:
> Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
> dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
> as well.
>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Do we need Config.in.legacy handling ?
We normally add Config.in.legacy handling when removing options, but on
the other hand, this option has had no effect since 2018.02.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML
2018-11-13 20:21 ` Thomas Petazzoni
@ 2018-11-13 23:42 ` Arnout Vandecappelle
0 siblings, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2018-11-13 23:42 UTC (permalink / raw)
To: buildroot
On 13/11/2018 21:21, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 13 Nov 2018 21:59:08 +0200, Baruch Siach wrote:
>> Commit fa0d1ebff99 (libnftnl: bump to version 1.0.9) removed the mxml
>> dependency. Remove the redundant BR2_PACKAGE_LIBNFTNL_XML config symbol
>> as well.
>>
>> Cc: Yegor Yefremov <yegorslists@googlemail.com>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Do we need Config.in.legacy handling ?
>
> We normally add Config.in.legacy handling when removing options, but on
> the other hand, this option has had no effect since 2018.02.
Legacy handling is there mostly to make sure the appropriate alternative option
can be selected. In this case there is no alternative.
Also, compare this to a situation where it would have been an automatic
optional dependency: in that case, the feature also disappears silently.
That said: legacy handling costs nothing and can be useful for some users. And
it can be backported to 2018.02.x.
Regards,
Arnout
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-13 23:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-13 19:59 [Buildroot] [PATCH] libnftnl: drop useless BR2_PACKAGE_LIBNFTNL_XML Baruch Siach
2018-11-13 20:21 ` Thomas Petazzoni
2018-11-13 23:42 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox