[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Serj Kalichev]

The command "make show-build-order" doesn't show dependencies of rootfs-common target.

This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/common.mk b/fs/common.mk
index 358801d44f..e4a6a4897b 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -148,7 +148,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1)
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)
 TARGETS_ROOTFS += rootfs-$(1)
-PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))
+PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES) $$(ROOTFS_COMMON_DEPENDENCIES))
 endif
 
 # Check for legacy POST_TARGETS rules
-- 
2.17.1

[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Yann E. MORIN]

Serj, All,

On 2018-11-15 18:25 +0300, Serj Kalichev spake thusly:
> The command "make show-build-order" doesn't show dependencies of rootfs-common target.
> 
> This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.
> 
> Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

(I would still have preferred they be added to the _DEPENDENCIES list,
but others disagreed, so...)

Regards,
Yann E. MORIN.

> ---
>  fs/common.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/common.mk b/fs/common.mk
> index 358801d44f..e4a6a4897b 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -148,7 +148,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1)
>  
>  ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)
>  TARGETS_ROOTFS += rootfs-$(1)
> -PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))
> +PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES) $$(ROOTFS_COMMON_DEPENDENCIES))
>  endif
>  
>  # Check for legacy POST_TARGETS rules
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Yann E. MORIN]

Serj, All,

On 2018-11-15 17:35 +0100, Yann E. MORIN spake thusly:
> On 2018-11-15 18:25 +0300, Serj Kalichev spake thusly:
> > The command "make show-build-order" doesn't show dependencies of rootfs-common target.
> > 
> > This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.
> > 
> > Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> (I would still have preferred they be added to the _DEPENDENCIES list,
> but others disagreed, so...)

I somehow got confused to see that patch pop up on the list, wen Thomas
said he had integrated it in his PPS series.

It turns out that the previous thread was started by Andreas:
    http://lists.busybox.net/pipermail/buildroot/2018-November/thread.html#235256

This patch by Serj confused me because the reason for that same change
is totally different (but as valid).

My Reviewed-by tag still stands, obviously.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Peter Korsgaard]

>>>>> "Serj" == Serj Kalichev <serj.kalichev@gmail.com> writes:

 > The command "make show-build-order" doesn't show dependencies of rootfs-common target.
 > This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

 > Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order

[Peter Korsgaard]

>>>>> "Serj" == Serj Kalichev <serj.kalichev@gmail.com> writes:

 > The command "make show-build-order" doesn't show dependencies of rootfs-common target.
 > This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.

 > Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard