* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
@ 2018-12-17 8:47 Thomas Petazzoni
2018-12-17 22:48 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-17 8:47 UTC (permalink / raw)
To: buildroot
The netsurf build system creates a stamp file inside TMP_PREFIX to
know if the build was done, and if the stamp file exists, it doesn't
do any build. Therefore, having this stamp file in STAGING_DIR
prevents from rebuilding netsurf, even after removing its entire build
directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
build anything, causing the installation to fail.
We fix this by putting this temporary directory inside the netsurf
build directory.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/netsurf/netsurf.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
index e5a251b9c1..e4ed4fd1a7 100644
--- a/package/netsurf/netsurf.mk
+++ b/package/netsurf/netsurf.mk
@@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
BUILD_CC="$(HOSTCC)" \
CC="$(TARGET_CC)" \
AR="$(TARGET_AR)" \
- TMP_PREFIX=$(STAGING_DIR)/usr \
+ TMP_PREFIX=$(@D)/tmpusr \
NETSURF_CONFIG="$(NETSURF_CONFIG)" \
PREFIX=/usr
--
2.19.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
2018-12-17 8:47 [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory Thomas Petazzoni
@ 2018-12-17 22:48 ` Peter Korsgaard
2018-12-18 7:18 ` François Perrad
2018-12-18 7:48 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-12-17 22:48 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> The netsurf build system creates a stamp file inside TMP_PREFIX to
> know if the build was done, and if the stamp file exists, it doesn't
> do any build. Therefore, having this stamp file in STAGING_DIR
> prevents from rebuilding netsurf, even after removing its entire build
> directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
> build anything, causing the installation to fail.
> We fix this by putting this temporary directory inside the netsurf
> build directory.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/netsurf/netsurf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> index e5a251b9c1..e4ed4fd1a7 100644
> --- a/package/netsurf/netsurf.mk
> +++ b/package/netsurf/netsurf.mk
> @@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
> BUILD_CC="$(HOSTCC)" \
> CC="$(TARGET_CC)" \
> AR="$(TARGET_AR)" \
> - TMP_PREFIX=$(STAGING_DIR)/usr \
> + TMP_PREFIX=$(@D)/tmpusr \
Why do we have to set it at all? It looks like it defaults to a
directory under the build dir as well?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
2018-12-17 22:48 ` Peter Korsgaard
@ 2018-12-18 7:18 ` François Perrad
2018-12-18 7:48 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: François Perrad @ 2018-12-18 7:18 UTC (permalink / raw)
To: buildroot
Le lun. 17 d?c. 2018 ? 23:48, Peter Korsgaard <peter@korsgaard.com> a
?crit :
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>
> > The netsurf build system creates a stamp file inside TMP_PREFIX to
> > know if the build was done, and if the stamp file exists, it doesn't
> > do any build. Therefore, having this stamp file in STAGING_DIR
> > prevents from rebuilding netsurf, even after removing its entire build
> > directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
> > build anything, causing the installation to fail.
>
> > We fix this by putting this temporary directory inside the netsurf
> > build directory.
>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > ---
> > package/netsurf/netsurf.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> > index e5a251b9c1..e4ed4fd1a7 100644
> > --- a/package/netsurf/netsurf.mk
> > +++ b/package/netsurf/netsurf.mk
> > @@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
> > BUILD_CC="$(HOSTCC)" \
> > CC="$(TARGET_CC)" \
> > AR="$(TARGET_AR)" \
> > - TMP_PREFIX=$(STAGING_DIR)/usr \
> > + TMP_PREFIX=$(@D)/tmpusr \
>
> Why do we have to set it at all? It looks like it defaults to a
> directory under the build dir as well?
>
>
without TMP_PREFIX=$(STAGING_DIR)/usr, a fresh build fails with :
COMPILE: src/stylesheet.c
In file included from src/stylesheet.c:12:
src/stylesheet.h:14:10: fatal error: libwapcaplet/libwapcaplet.h: No such
file or directory
#include <libwapcaplet/libwapcaplet.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/inst-framebuffer/share/netsurf-buildsystem/makefiles/Makefile.top:584:
recipe for target
'build-x86_64-linux-gnu-arm-linux-gnueabihf-release-lib-static/src_stylesheet.o'
failed
make[2]: ***
[build-x86_64-linux-gnu-arm-linux-gnueabihf-release-lib-static/src_stylesheet.o]
Error 1
make[2]: Leaving directory
'/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/libcss'
Makefile:119: recipe for target
'/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/inst-framebuffer/build-stamp'
failed
make[1]: ***
[/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/inst-framebuffer/build-stamp]
Error 2
make[1]: Leaving directory
'/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8'
package/pkg-generic.mk:229: recipe for target
'/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/.stamp_built'
failed
make: ***
[/home/dev/checkout/BR/build/lime_netsurf_fb/build/netsurf-3.8/.stamp_built]
Error 2
Fran?ois
> --
> Bye, Peter Korsgaard
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181218/47380e71/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
2018-12-17 22:48 ` Peter Korsgaard
2018-12-18 7:18 ` François Perrad
@ 2018-12-18 7:48 ` Thomas Petazzoni
2019-02-03 20:36 ` Arnout Vandecappelle
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-18 7:48 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 17 Dec 2018 23:48:34 +0100, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>
> > The netsurf build system creates a stamp file inside TMP_PREFIX to
> > know if the build was done, and if the stamp file exists, it doesn't
> > do any build. Therefore, having this stamp file in STAGING_DIR
> > prevents from rebuilding netsurf, even after removing its entire build
> > directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
> > build anything, causing the installation to fail.
>
> > We fix this by putting this temporary directory inside the netsurf
> > build directory.
>
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > ---
> > package/netsurf/netsurf.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> > index e5a251b9c1..e4ed4fd1a7 100644
> > --- a/package/netsurf/netsurf.mk
> > +++ b/package/netsurf/netsurf.mk
> > @@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
> > BUILD_CC="$(HOSTCC)" \
> > CC="$(TARGET_CC)" \
> > AR="$(TARGET_AR)" \
> > - TMP_PREFIX=$(STAGING_DIR)/usr \
> > + TMP_PREFIX=$(@D)/tmpusr \
>
> Why do we have to set it at all? It looks like it defaults to a
> directory under the build dir as well?
Indeed, it does. So it's obviously simpler to drop it. I'll respin the
patch. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
2018-12-18 7:48 ` Thomas Petazzoni
@ 2019-02-03 20:36 ` Arnout Vandecappelle
2019-02-04 10:23 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-02-03 20:36 UTC (permalink / raw)
To: buildroot
On 18/12/2018 08:48, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 17 Dec 2018 23:48:34 +0100, Peter Korsgaard wrote:
>>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>>
>> > The netsurf build system creates a stamp file inside TMP_PREFIX to
>> > know if the build was done, and if the stamp file exists, it doesn't
>> > do any build. Therefore, having this stamp file in STAGING_DIR
>> > prevents from rebuilding netsurf, even after removing its entire build
>> > directory: the stamp file exists in STAGING_DIR, and netsurf doesn't
>> > build anything, causing the installation to fail.
>>
>> > We fix this by putting this temporary directory inside the netsurf
>> > build directory.
As observed by Francois, this makes the build fail the first time. Adding an
mkdir solves the issue, so I've added that and applied to master, thanks.
Probably a better solution would be an upstreamable patch that does it, but oh
well.
Regards,
Arnout
>>
>> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> > ---
>> > package/netsurf/netsurf.mk | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> > diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
>> > index e5a251b9c1..e4ed4fd1a7 100644
>> > --- a/package/netsurf/netsurf.mk
>> > +++ b/package/netsurf/netsurf.mk
>> > @@ -78,7 +78,7 @@ NETSURF_MAKE_OPTS = \
>> > BUILD_CC="$(HOSTCC)" \
>> > CC="$(TARGET_CC)" \
>> > AR="$(TARGET_AR)" \
>> > - TMP_PREFIX=$(STAGING_DIR)/usr \
>> > + TMP_PREFIX=$(@D)/tmpusr \
>>
>> Why do we have to set it at all? It looks like it defaults to a
>> directory under the build dir as well?
>
> Indeed, it does. So it's obviously simpler to drop it. I'll respin the
> patch. Thanks!
As
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory
2019-02-03 20:36 ` Arnout Vandecappelle
@ 2019-02-04 10:23 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-02-04 10:23 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
>>> > - TMP_PREFIX=$(STAGING_DIR)/usr \
>>> > + TMP_PREFIX=$(@D)/tmpusr \
>>>
>>> Why do we have to set it at all? It looks like it defaults to a
>>> directory under the build dir as well?
>>
>> Indeed, it does. So it's obviously simpler to drop it. I'll respin the
>> patch. Thanks!
> As
As?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-04 10:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 8:47 [Buildroot] [PATCH] package/netsurf: use TMP_PREFIX inside the build directory Thomas Petazzoni
2018-12-17 22:48 ` Peter Korsgaard
2018-12-18 7:18 ` François Perrad
2018-12-18 7:48 ` Thomas Petazzoni
2019-02-03 20:36 ` Arnout Vandecappelle
2019-02-04 10:23 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox