* [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: new package
2018-12-29 2:07 [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package james.hilliard1 at gmail.com
@ 2018-12-29 2:07 ` james.hilliard1 at gmail.com
2018-12-29 8:16 ` François Perrad
2018-12-30 14:07 ` Thomas Petazzoni
2018-12-29 2:07 ` [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4 james.hilliard1 at gmail.com
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: james.hilliard1 at gmail.com @ 2018-12-29 2:07 UTC (permalink / raw)
To: buildroot
From: James Hilliard <james.hilliard1@gmail.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v1 -> v2:
- rename lua-normalize to lua-std-normalize
---
package/Config.in | 1 +
package/lua-std-normalize/Config.in | 13 +++++++++++++
package/lua-std-normalize/lua-std-normalize.hash | 2 ++
package/lua-std-normalize/lua-std-normalize.mk | 14 ++++++++++++++
4 files changed, 30 insertions(+)
create mode 100644 package/lua-std-normalize/Config.in
create mode 100644 package/lua-std-normalize/lua-std-normalize.hash
create mode 100644 package/lua-std-normalize/lua-std-normalize.mk
diff --git a/package/Config.in b/package/Config.in
index f33aaf9..eaf3c04 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -625,6 +625,7 @@ menu "Lua libraries/modules"
source "package/lua-periphery/Config.in"
source "package/lua-sdl2/Config.in"
source "package/lua-std-debug/Config.in"
+ source "package/lua-std-normalize/Config.in"
source "package/lua-stdlib/Config.in"
source "package/lua-testmore/Config.in"
source "package/lua-utf8/Config.in"
diff --git a/package/lua-std-normalize/Config.in b/package/lua-std-normalize/Config.in
new file mode 100644
index 0000000..b959836
--- /dev/null
+++ b/package/lua-std-normalize/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LUA_STD_NORMALIZE
+ bool "lua-std-normalize"
+ depends on BR2_PACKAGE_HAS_LUAINTERPRETER
+ select BR2_PACKAGE_LUA_STD_DEBUG # runtime
+ help
+ This module can inject deterministic versions of core Lua
+ functions that do not behave identically across all supported Lua
+ implementations into your module's lexical environment. Each
+ function is as thin and fast a version as is possible in each Lua
+ implementation, evaluating to the Lua C implementation with no
+ overhead when semantics allow.
+
+ https://lua-stdlib.github.io/normalize
diff --git a/package/lua-std-normalize/lua-std-normalize.hash b/package/lua-std-normalize/lua-std-normalize.hash
new file mode 100644
index 0000000..831528d
--- /dev/null
+++ b/package/lua-std-normalize/lua-std-normalize.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 50baac6fbcbc6bbe72b63ce0871ec36176d75c04dccc6e368590ba6ef107c67a std.normalize-2.0.2-1.src.rock
diff --git a/package/lua-std-normalize/lua-std-normalize.mk b/package/lua-std-normalize/lua-std-normalize.mk
new file mode 100644
index 0000000..efbf48b
--- /dev/null
+++ b/package/lua-std-normalize/lua-std-normalize.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# lua-std-normalize
+#
+################################################################################
+
+LUA_STD_NORMALIZE_VERSION_UPSTREAM = 2.0.2
+LUA_STD_NORMALIZE_VERSION = $(LUA_STD_NORMALIZE_VERSION_UPSTREAM)-1
+LUA_STD_NORMALIZE_NAME_UPSTREAM = std.normalize
+LUA_STD_NORMALIZE_SUBDIR = normalize-$(LUA_STD_NORMALIZE_VERSION_UPSTREAM)
+LUA_STD_NORMALIZE_LICENSE = MIT
+LUA_STD_NORMALIZE_LICENSE_FILES = LICENSE.md
+
+$(eval $(luarocks-package))
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: new package
2018-12-29 2:07 ` [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: " james.hilliard1 at gmail.com
@ 2018-12-29 8:16 ` François Perrad
2018-12-30 14:07 ` Thomas Petazzoni
1 sibling, 0 replies; 10+ messages in thread
From: François Perrad @ 2018-12-29 8:16 UTC (permalink / raw)
To: buildroot
Le sam. 29 d?c. 2018 ? 03:07, <james.hilliard1@gmail.com> a ?crit :
> From: James Hilliard <james.hilliard1@gmail.com>
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
Acked-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> Changes v1 -> v2:
> - rename lua-normalize to lua-std-normalize
> ---
> package/Config.in | 1 +
> package/lua-std-normalize/Config.in | 13 +++++++++++++
> package/lua-std-normalize/lua-std-normalize.hash | 2 ++
> package/lua-std-normalize/lua-std-normalize.mk | 14 ++++++++++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 package/lua-std-normalize/Config.in
> create mode 100644 package/lua-std-normalize/lua-std-normalize.hash
> create mode 100644 package/lua-std-normalize/lua-std-normalize.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index f33aaf9..eaf3c04 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -625,6 +625,7 @@ menu "Lua libraries/modules"
> source "package/lua-periphery/Config.in"
> source "package/lua-sdl2/Config.in"
> source "package/lua-std-debug/Config.in"
> + source "package/lua-std-normalize/Config.in"
> source "package/lua-stdlib/Config.in"
> source "package/lua-testmore/Config.in"
> source "package/lua-utf8/Config.in"
> diff --git a/package/lua-std-normalize/Config.in
> b/package/lua-std-normalize/Config.in
> new file mode 100644
> index 0000000..b959836
> --- /dev/null
> +++ b/package/lua-std-normalize/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LUA_STD_NORMALIZE
> + bool "lua-std-normalize"
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> + select BR2_PACKAGE_LUA_STD_DEBUG # runtime
> + help
> + This module can inject deterministic versions of core Lua
> + functions that do not behave identically across all supported Lua
> + implementations into your module's lexical environment. Each
> + function is as thin and fast a version as is possible in each Lua
> + implementation, evaluating to the Lua C implementation with no
> + overhead when semantics allow.
> +
> + https://lua-stdlib.github.io/normalize
> diff --git a/package/lua-std-normalize/lua-std-normalize.hash
> b/package/lua-std-normalize/lua-std-normalize.hash
> new file mode 100644
> index 0000000..831528d
> --- /dev/null
> +++ b/package/lua-std-normalize/lua-std-normalize.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 50baac6fbcbc6bbe72b63ce0871ec36176d75c04dccc6e368590ba6ef107c67a
> std.normalize-2.0.2-1.src.rock
> diff --git a/package/lua-std-normalize/lua-std-normalize.mk
> b/package/lua-std-normalize/lua-std-normalize.mk
> new file mode 100644
> index 0000000..efbf48b
> --- /dev/null
> +++ b/package/lua-std-normalize/lua-std-normalize.mk
> @@ -0,0 +1,14 @@
>
> +################################################################################
> +#
> +# lua-std-normalize
> +#
>
> +################################################################################
> +
> +LUA_STD_NORMALIZE_VERSION_UPSTREAM = 2.0.2
> +LUA_STD_NORMALIZE_VERSION = $(LUA_STD_NORMALIZE_VERSION_UPSTREAM)-1
> +LUA_STD_NORMALIZE_NAME_UPSTREAM = std.normalize
> +LUA_STD_NORMALIZE_SUBDIR = normalize-$(LUA_STD_NORMALIZE_VERSION_UPSTREAM)
> +LUA_STD_NORMALIZE_LICENSE = MIT
> +LUA_STD_NORMALIZE_LICENSE_FILES = LICENSE.md
> +
> +$(eval $(luarocks-package))
> --
> 2.7.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181229/d7dd2cc3/attachment.html>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: new package
2018-12-29 2:07 ` [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: " james.hilliard1 at gmail.com
2018-12-29 8:16 ` François Perrad
@ 2018-12-30 14:07 ` Thomas Petazzoni
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2018-12-30 14:07 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 29 Dec 2018 10:07:24 +0800, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Applied to master with the following changes:
[Thomas:
- add entry to DEVELOPERS file
- drop useless dependency in Config.in
- fix path to license file
- add hash of license file]
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4
2018-12-29 2:07 [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package james.hilliard1 at gmail.com
2018-12-29 2:07 ` [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: " james.hilliard1 at gmail.com
@ 2018-12-29 2:07 ` james.hilliard1 at gmail.com
2018-12-29 8:16 ` François Perrad
2018-12-29 8:15 ` [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package François Perrad
2018-12-30 13:53 ` Thomas Petazzoni
3 siblings, 1 reply; 10+ messages in thread
From: james.hilliard1 at gmail.com @ 2018-12-29 2:07 UTC (permalink / raw)
To: buildroot
From: James Hilliard <james.hilliard1@gmail.com>
This version has a new dependency on lua-std-normalize.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v1 -> v2:
- Use generic package infrastructure instead of luarocks
---
package/luaposix/Config.in | 1 +
package/luaposix/luaposix.hash | 2 +-
package/luaposix/luaposix.mk | 4 ++--
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/package/luaposix/Config.in b/package/luaposix/Config.in
index 91abcb9..176c765 100644
--- a/package/luaposix/Config.in
+++ b/package/luaposix/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LUAPOSIX
bool "luaposix"
depends on BR2_PACKAGE_HAS_LUAINTERPRETER
+ select BR2_PACKAGE_LUA_STD_NORMALIZE # runtime
# "bit32" is included in Lua 5.2+. luajit has an equivalent
# "bit" module, but since it has a different name, luaposix
# doesn't find it.
diff --git a/package/luaposix/luaposix.hash b/package/luaposix/luaposix.hash
index b3984c1..a13cb4a 100644
--- a/package/luaposix/luaposix.hash
+++ b/package/luaposix/luaposix.hash
@@ -1,2 +1,2 @@
# Locally calculated
-sha256 ba0bc343783fc33958cd02a68cdbfd65430152d9f297f7ed92678b1a305bd5d7 luaposix-34.0.1.tar.gz
+sha256 eb6e7322da3013bdb3d524f68df4f5510a2efd805c06bf7cc27be6611eab7483 luaposix-34.0.4.tar.gz
diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk
index 779e707..f467992 100644
--- a/package/luaposix/luaposix.mk
+++ b/package/luaposix/luaposix.mk
@@ -4,8 +4,8 @@
#
################################################################################
-LUAPOSIX_VERSION = 34.0.1
-LUAPOSIX_SITE = $(call github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION))
+LUAPOSIX_VERSION = 34.0.4
+LUAPOSIX_SITE = $(call github,luaposix,luaposix,v$(LUAPOSIX_VERSION))
LUAPOSIX_LICENSE = MIT
LUAPOSIX_LICENSE_FILES = LICENSE
LUAPOSIX_DEPENDENCIES = luainterpreter host-lua
--
2.7.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4
2018-12-29 2:07 ` [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4 james.hilliard1 at gmail.com
@ 2018-12-29 8:16 ` François Perrad
0 siblings, 0 replies; 10+ messages in thread
From: François Perrad @ 2018-12-29 8:16 UTC (permalink / raw)
To: buildroot
Le sam. 29 d?c. 2018 ? 03:07, <james.hilliard1@gmail.com> a ?crit :
> From: James Hilliard <james.hilliard1@gmail.com>
>
> This version has a new dependency on lua-std-normalize.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
Acked-by: Francois Perrad <francois.perrad@gadz.org>
>
> ---
> Changes v1 -> v2:
> - Use generic package infrastructure instead of luarocks
> ---
> package/luaposix/Config.in | 1 +
> package/luaposix/luaposix.hash | 2 +-
> package/luaposix/luaposix.mk | 4 ++--
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/package/luaposix/Config.in b/package/luaposix/Config.in
> index 91abcb9..176c765 100644
> --- a/package/luaposix/Config.in
> +++ b/package/luaposix/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_LUAPOSIX
> bool "luaposix"
> depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> + select BR2_PACKAGE_LUA_STD_NORMALIZE # runtime
> # "bit32" is included in Lua 5.2+. luajit has an equivalent
> # "bit" module, but since it has a different name, luaposix
> # doesn't find it.
> diff --git a/package/luaposix/luaposix.hash
> b/package/luaposix/luaposix.hash
> index b3984c1..a13cb4a 100644
> --- a/package/luaposix/luaposix.hash
> +++ b/package/luaposix/luaposix.hash
> @@ -1,2 +1,2 @@
> # Locally calculated
> -sha256 ba0bc343783fc33958cd02a68cdbfd65430152d9f297f7ed92678b1a305bd5d7
> luaposix-34.0.1.tar.gz
> +sha256 eb6e7322da3013bdb3d524f68df4f5510a2efd805c06bf7cc27be6611eab7483
> luaposix-34.0.4.tar.gz
> diff --git a/package/luaposix/luaposix.mk b/package/luaposix/luaposix.mk
> index 779e707..f467992 100644
> --- a/package/luaposix/luaposix.mk
> +++ b/package/luaposix/luaposix.mk
> @@ -4,8 +4,8 @@
> #
>
> ################################################################################
>
> -LUAPOSIX_VERSION = 34.0.1
> -LUAPOSIX_SITE = $(call
> github,luaposix,luaposix,release-v$(LUAPOSIX_VERSION))
> +LUAPOSIX_VERSION = 34.0.4
> +LUAPOSIX_SITE = $(call github,luaposix,luaposix,v$(LUAPOSIX_VERSION))
> LUAPOSIX_LICENSE = MIT
> LUAPOSIX_LICENSE_FILES = LICENSE
> LUAPOSIX_DEPENDENCIES = luainterpreter host-lua
> --
> 2.7.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181229/1c20aab9/attachment.html>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package
2018-12-29 2:07 [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package james.hilliard1 at gmail.com
2018-12-29 2:07 ` [Buildroot] [PATCH v2 2/3] package/lua-std-normalize: " james.hilliard1 at gmail.com
2018-12-29 2:07 ` [Buildroot] [PATCH v2 3/3] package/luaposix: bump version to 34.0.4 james.hilliard1 at gmail.com
@ 2018-12-29 8:15 ` François Perrad
2018-12-30 13:53 ` Thomas Petazzoni
3 siblings, 0 replies; 10+ messages in thread
From: François Perrad @ 2018-12-29 8:15 UTC (permalink / raw)
To: buildroot
Le sam. 29 d?c. 2018 ? 03:07, <james.hilliard1@gmail.com> a ?crit :
> From: James Hilliard <james.hilliard1@gmail.com>
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
Acked-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> Changes v1 -> v2:
> - rename lua-debug to lua-std-debug
> ---
> package/Config.in | 1 +
> package/lua-std-debug/Config.in | 7 +++++++
> package/lua-std-debug/lua-std-debug.hash | 2 ++
> package/lua-std-debug/lua-std-debug.mk | 16 ++++++++++++++++
> 4 files changed, 26 insertions(+)
> create mode 100644 package/lua-std-debug/Config.in
> create mode 100644 package/lua-std-debug/lua-std-debug.hash
> create mode 100644 package/lua-std-debug/lua-std-debug.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index c3e0691..f33aaf9 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -624,6 +624,7 @@ menu "Lua libraries/modules"
> source "package/lua-msgpack-native/Config.in"
> source "package/lua-periphery/Config.in"
> source "package/lua-sdl2/Config.in"
> + source "package/lua-std-debug/Config.in"
> source "package/lua-stdlib/Config.in"
> source "package/lua-testmore/Config.in"
> source "package/lua-utf8/Config.in"
> diff --git a/package/lua-std-debug/Config.in
> b/package/lua-std-debug/Config.in
> new file mode 100644
> index 0000000..3774292
> --- /dev/null
> +++ b/package/lua-std-debug/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LUA_STD_DEBUG
> + bool "lua-std-debug"
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> + help
> + Manage an overall debug state, and associated hint substates.
> +
> + http://lua-stdlib.github.io/_debug
> diff --git a/package/lua-std-debug/lua-std-debug.hash
> b/package/lua-std-debug/lua-std-debug.hash
> new file mode 100644
> index 0000000..2c48711
> --- /dev/null
> +++ b/package/lua-std-debug/lua-std-debug.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 7f6b84283d4b78dafee17e7765dd5f1f8e75c3314169977f4dda0e7873616ce2
> std._debug-1.0.1-1.src.rock
> diff --git a/package/lua-std-debug/lua-std-debug.mk
> b/package/lua-std-debug/lua-std-debug.mk
> new file mode 100644
> index 0000000..b9e6312
> --- /dev/null
> +++ b/package/lua-std-debug/lua-std-debug.mk
> @@ -0,0 +1,16 @@
>
> +################################################################################
> +#
> +# lua-std-debug
> +#
>
> +################################################################################
> +
> +LUA_STD_DEBUG_VERSION_UPSTREAM = 1.0.1
> +LUA_STD_DEBUG_VERSION = $(LUA_STD_DEBUG_VERSION_UPSTREAM)-1
> +LUA_STD_DEBUG_NAME_UPSTREAM = std._debug
> +LUA_STD_DEBUG_SUBDIR = _debug-$(LUA_STD_DEBUG_VERSION_UPSTREAM)
> +LUA_STD_DEBUG_ROCKSPEC =
> $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).rockspec
> +LUA_STD_DEBUG_SOURCE =
> $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).src.rock
> +LUA_STD_DEBUG_LICENSE = MIT
> +LUA_STD_DEBUG_LICENSE_FILES = LICENSE.md
> +
> +$(eval $(luarocks-package))
> --
> 2.7.4
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181229/d1714a74/attachment.html>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package
2018-12-29 2:07 [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package james.hilliard1 at gmail.com
` (2 preceding siblings ...)
2018-12-29 8:15 ` [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package François Perrad
@ 2018-12-30 13:53 ` Thomas Petazzoni
2018-12-30 21:38 ` James Hilliard
3 siblings, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2018-12-30 13:53 UTC (permalink / raw)
To: buildroot
Hello,
I have applied, but there were a few things to fix. I'm Cc'ing
Fran?ois, who gave his Acked-by, so that he can hopefully take into
account these details for the next reviews. For me, it is *very* useful
to have the reviews of Fran?ois on Lua patches, but it's even better
when such a review catches all the small details! :-)
On Sat, 29 Dec 2018 10:07:23 +0800, james.hilliard1 at gmail.com wrote:
> package/Config.in | 1 +
> package/lua-std-debug/Config.in | 7 +++++++
> package/lua-std-debug/lua-std-debug.hash | 2 ++
> package/lua-std-debug/lua-std-debug.mk | 16 ++++++++++++++++
First issue: no entry was added to the DEVELOPERS file. Even if
Fran?ois entry covers all Lua modules, it's good when someone
contributes a new package that he gets referenced as such in the
DEVELOPERS file.
> diff --git a/package/lua-std-debug/Config.in b/package/lua-std-debug/Config.in
> new file mode 100644
> index 0000000..3774292
> --- /dev/null
> +++ b/package/lua-std-debug/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LUA_STD_DEBUG
> + bool "lua-std-debug"
> + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
This dependency is not needed: all Lua modules inclusions in
package/Config.in are already enclosed in a
BR2_PACKAGE_HAS_LUAINTERPRETER & !BR2_STATIC_LIBS condition.
> diff --git a/package/lua-std-debug/lua-std-debug.hash b/package/lua-std-debug/lua-std-debug.hash
> new file mode 100644
> index 0000000..2c48711
> --- /dev/null
> +++ b/package/lua-std-debug/lua-std-debug.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 7f6b84283d4b78dafee17e7765dd5f1f8e75c3314169977f4dda0e7873616ce2 std._debug-1.0.1-1.src.rock
The hash for the license file was missing.
> diff --git a/package/lua-std-debug/lua-std-debug.mk b/package/lua-std-debug/lua-std-debug.mk
> new file mode 100644
> index 0000000..b9e6312
> --- /dev/null
> +++ b/package/lua-std-debug/lua-std-debug.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# lua-std-debug
> +#
> +################################################################################
> +
> +LUA_STD_DEBUG_VERSION_UPSTREAM = 1.0.1
> +LUA_STD_DEBUG_VERSION = $(LUA_STD_DEBUG_VERSION_UPSTREAM)-1
> +LUA_STD_DEBUG_NAME_UPSTREAM = std._debug
> +LUA_STD_DEBUG_SUBDIR = _debug-$(LUA_STD_DEBUG_VERSION_UPSTREAM)
> +LUA_STD_DEBUG_ROCKSPEC = $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).rockspec
> +LUA_STD_DEBUG_SOURCE = $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).src.rock
I was a bit surprised that those values were not automatically inferred
by the luarocks package infrastructure. However indeed, due to the
infrastructure using $(call LOWERCASE) and the upstream name containing
a underscore, it gets turned into a dash, and it no longer matches.
I don't think it's worth fixing the infrastructure about this right
now, but it's worth keeping in mind, in case several other packages are
in the same situation, in which case we could think about improving the
common infrastructure logic.
> +LUA_STD_DEBUG_LICENSE = MIT
> +LUA_STD_DEBUG_LICENSE_FILES = LICENSE.md
This was clearly not tested with "make legal-info". Indeed LICENSE.md
is inside LUA_STD_DEBUG_SUBDIR.
I fixed those details, and applied. Thanks!
Best regards
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package
2018-12-30 13:53 ` Thomas Petazzoni
@ 2018-12-30 21:38 ` James Hilliard
2018-12-30 21:50 ` Thomas Petazzoni
0 siblings, 1 reply; 10+ messages in thread
From: James Hilliard @ 2018-12-30 21:38 UTC (permalink / raw)
To: buildroot
On Sun, Dec 30, 2018 at 7:53 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> I have applied, but there were a few things to fix. I'm Cc'ing
> Fran?ois, who gave his Acked-by, so that he can hopefully take into
> account these details for the next reviews. For me, it is *very* useful
> to have the reviews of Fran?ois on Lua patches, but it's even better
> when such a review catches all the small details! :-)
>
> On Sat, 29 Dec 2018 10:07:23 +0800, james.hilliard1 at gmail.com wrote:
>
> > package/Config.in | 1 +
> > package/lua-std-debug/Config.in | 7 +++++++
> > package/lua-std-debug/lua-std-debug.hash | 2 ++
> > package/lua-std-debug/lua-std-debug.mk | 16 ++++++++++++++++
>
> First issue: no entry was added to the DEVELOPERS file. Even if
> Fran?ois entry covers all Lua modules, it's good when someone
> contributes a new package that he gets referenced as such in the
> DEVELOPERS file.
Yeah, I didn't do that for these since I was adding these packages
only since they were required for the luaposix version bump, I also
don't normally write anything in lua(I'm primarily a python developer)
but needed to use lua for the built in script interface in the
swupdate package for automatic disk formatting and installation.
>
>
> > diff --git a/package/lua-std-debug/Config.in b/package/lua-std-debug/Config.in
> > new file mode 100644
> > index 0000000..3774292
> > --- /dev/null
> > +++ b/package/lua-std-debug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_LUA_STD_DEBUG
> > + bool "lua-std-debug"
> > + depends on BR2_PACKAGE_HAS_LUAINTERPRETER
>
> This dependency is not needed: all Lua modules inclusions in
> package/Config.in are already enclosed in a
> BR2_PACKAGE_HAS_LUAINTERPRETER & !BR2_STATIC_LIBS condition.
Yeah, I wasn't sure what was supposed to be there, I copied that from luaposix.
>
> > diff --git a/package/lua-std-debug/lua-std-debug.hash b/package/lua-std-debug/lua-std-debug.hash
> > new file mode 100644
> > index 0000000..2c48711
> > --- /dev/null
> > +++ b/package/lua-std-debug/lua-std-debug.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256 7f6b84283d4b78dafee17e7765dd5f1f8e75c3314169977f4dda0e7873616ce2 std._debug-1.0.1-1.src.rock
>
> The hash for the license file was missing.
>
> > diff --git a/package/lua-std-debug/lua-std-debug.mk b/package/lua-std-debug/lua-std-debug.mk
> > new file mode 100644
> > index 0000000..b9e6312
> > --- /dev/null
> > +++ b/package/lua-std-debug/lua-std-debug.mk
> > @@ -0,0 +1,16 @@
> > +################################################################################
> > +#
> > +# lua-std-debug
> > +#
> > +################################################################################
> > +
> > +LUA_STD_DEBUG_VERSION_UPSTREAM = 1.0.1
> > +LUA_STD_DEBUG_VERSION = $(LUA_STD_DEBUG_VERSION_UPSTREAM)-1
> > +LUA_STD_DEBUG_NAME_UPSTREAM = std._debug
> > +LUA_STD_DEBUG_SUBDIR = _debug-$(LUA_STD_DEBUG_VERSION_UPSTREAM)
> > +LUA_STD_DEBUG_ROCKSPEC = $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).rockspec
> > +LUA_STD_DEBUG_SOURCE = $(LUA_STD_DEBUG_NAME_UPSTREAM)-$(LUA_STD_DEBUG_VERSION).src.rock
>
> I was a bit surprised that those values were not automatically inferred
> by the luarocks package infrastructure. However indeed, due to the
> infrastructure using $(call LOWERCASE) and the upstream name containing
> a underscore, it gets turned into a dash, and it no longer matches.
> I don't think it's worth fixing the infrastructure about this right
> now, but it's worth keeping in mind, in case several other packages are
> in the same situation, in which case we could think about improving the
> common infrastructure logic.
>
> > +LUA_STD_DEBUG_LICENSE = MIT
> > +LUA_STD_DEBUG_LICENSE_FILES = LICENSE.md
>
> This was clearly not tested with "make legal-info". Indeed LICENSE.md
> is inside LUA_STD_DEBUG_SUBDIR.
>
> I fixed those details, and applied. Thanks!
>
> Best regards
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/lua-std-debug: new package
2018-12-30 21:38 ` James Hilliard
@ 2018-12-30 21:50 ` Thomas Petazzoni
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2018-12-30 21:50 UTC (permalink / raw)
To: buildroot
Hello James,
On Sun, 30 Dec 2018 15:38:02 -0600, James Hilliard wrote:
> Yeah, I didn't do that for these since I was adding these packages
> only since they were required for the luaposix version bump, I also
> don't normally write anything in lua(I'm primarily a python developer)
> but needed to use lua for the built in script interface in the
> swupdate package for automatic disk formatting and installation.
OK, understood. But by default, we expect people who add new packages
to be willing to take care of them, at least to some extent.
> > This dependency is not needed: all Lua modules inclusions in
> > package/Config.in are already enclosed in a
> > BR2_PACKAGE_HAS_LUAINTERPRETER & !BR2_STATIC_LIBS condition.
> Yeah, I wasn't sure what was supposed to be there, I copied that from luaposix.
A number of other Lua packages have this redundant dependency. I have
sent a patch to remove it: http://patchwork.ozlabs.org/patch/1019425/.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 10+ messages in thread