* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
@ 2019-05-16 20:12 Fabrice Fontaine
2019-05-16 21:28 ` Adrian Perez de Castro
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2019-05-16 20:12 UTC (permalink / raw)
To: buildroot
Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
to add it to wpewebkit
Fixes:
- http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/wpewebkit/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
index 04ebe5452b..15db924829 100644
--- a/package/wpewebkit/Config.in
+++ b/package/wpewebkit/Config.in
@@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
-comment "wpewebkit needs an OpenGL ES w/ EGL backend"
+comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
depends on !BR2_BINFMT_FLAT
- depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
+ depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
+ || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
config BR2_PACKAGE_WPEWEBKIT
bool "wpewebkit"
@@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
depends on BR2_USE_WCHAR # icu, libsoup
depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
+ depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
select BR2_PACKAGE_CAIRO
select BR2_PACKAGE_CAIRO_PNG
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 20:12 [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency Fabrice Fontaine
@ 2019-05-16 21:28 ` Adrian Perez de Castro
2019-05-17 6:43 ` Fabrice Fontaine
2019-05-17 7:08 ` Thomas Petazzoni
2019-05-16 21:35 ` Giulio Benetti
2019-05-18 19:30 ` Thomas Petazzoni
2 siblings, 2 replies; 9+ messages in thread
From: Adrian Perez de Castro @ 2019-05-16 21:28 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 16 May 2019 22:12:20 +0200, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
> BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
> to add it to wpewebkit
>
> Fixes:
> - http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/wpewebkit/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 04ebe5452b..15db924829 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
> || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
>
> -comment "wpewebkit needs an OpenGL ES w/ EGL backend"
> +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
> depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> depends on !BR2_BINFMT_FLAT
> - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
> + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
> + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>
> config BR2_PACKAGE_WPEWEBKIT
> bool "wpewebkit"
> @@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
> depends on BR2_USE_WCHAR # icu, libsoup
> depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
> depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
> + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
> depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> select BR2_PACKAGE_CAIRO
> select BR2_PACKAGE_CAIRO_PNG
This is not correct. The short version of the story is tat WPE WebKit
itself does not require Wayland, only wpebackend-fdo uses Wayland.
The long storey: WPE WebKit itself uses generic interfaces from libwpe,
and the programs which use WPE WebKit are responsible for instructing
libwpe to load a "WPE backend plug-in" which provides a concrete
implementation of its interfaces. One such backend is provided by
wpebackend-fdo. This "FDO backend" is what actually requires Wayland,
but there are others which do not require Wayland. For example the
RDK backend [1] can be configured to use dispmanx on the RaspberryPi
directly, or the Vivante i.MX6 proprietary driver ? no Wayland
involved!
Regards,
?Adri?n
---
[1] https://github.com/WebPlatformForEmbedded/WPEBackend-rdk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190517/6da2781b/attachment.asc>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 21:28 ` Adrian Perez de Castro
@ 2019-05-17 6:43 ` Fabrice Fontaine
2019-05-17 7:08 ` Thomas Petazzoni
1 sibling, 0 replies; 9+ messages in thread
From: Fabrice Fontaine @ 2019-05-17 6:43 UTC (permalink / raw)
To: buildroot
Dear Adrian,
Le jeu. 16 mai 2019 ? 23:28, Adrian Perez de Castro
<aperez@igalia.com> a ?crit :
>
> Hello,
>
> On Thu, 16 May 2019 22:12:20 +0200, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
> > BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
> > to add it to wpewebkit
> >
> > Fixes:
> > - http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/wpewebkit/Config.in | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> > index 04ebe5452b..15db924829 100644
> > --- a/package/wpewebkit/Config.in
> > +++ b/package/wpewebkit/Config.in
> > @@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
> > || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> > || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
> >
> > -comment "wpewebkit needs an OpenGL ES w/ EGL backend"
> > +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
> > depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> > depends on !BR2_BINFMT_FLAT
> > - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
> > + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
> > + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
> >
> > config BR2_PACKAGE_WPEWEBKIT
> > bool "wpewebkit"
> > @@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
> > depends on BR2_USE_WCHAR # icu, libsoup
> > depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
> > depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
> > + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
> > depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> > select BR2_PACKAGE_CAIRO
> > select BR2_PACKAGE_CAIRO_PNG
>
> This is not correct. The short version of the story is tat WPE WebKit
> itself does not require Wayland, only wpebackend-fdo uses Wayland.
>
> The long storey: WPE WebKit itself uses generic interfaces from libwpe,
> and the programs which use WPE WebKit are responsible for instructing
> libwpe to load a "WPE backend plug-in" which provides a concrete
> implementation of its interfaces. One such backend is provided by
> wpebackend-fdo. This "FDO backend" is what actually requires Wayland,
> but there are others which do not require Wayland. For example the
> RDK backend [1] can be configured to use dispmanx on the RaspberryPi
> directly, or the Vivante i.MX6 proprietary driver ? no Wayland
> involved!
Thanks for the feedback however what do you suggest to fix the build
failure raised by commit 5b3c7a3e7828107eaa9dad49ba2650466277d891
which allows wpewebkit to select wpebackend-fdo without complying with
its new libegl-wayland dependency?
I'm not an expert in wpewebkit but I assume that FDO backend is
selected because this is the only available backend in buildroot (I
didn't find RDK). So I also assume that we can't drop this select to
make FDO backend optional (at least until we have other available
backends).
>
> Regards,
> ?Adri?n
>
> ---
> [1] https://github.com/WebPlatformForEmbedded/WPEBackend-rdk
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 21:28 ` Adrian Perez de Castro
2019-05-17 6:43 ` Fabrice Fontaine
@ 2019-05-17 7:08 ` Thomas Petazzoni
2019-05-17 18:09 ` Giulio Benetti
1 sibling, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2019-05-17 7:08 UTC (permalink / raw)
To: buildroot
Hello Adrian,
On Fri, 17 May 2019 00:28:28 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:
> This is not correct. The short version of the story is tat WPE WebKit
> itself does not require Wayland, only wpebackend-fdo uses Wayland.
That does not matter.
If A selects B, and B depends on C, then A *must* replicate the
"depends on C". That's due to how Kconfig work, and it's totally
unrelated to the fact that A doesn't use C directly in practice.
If you don't replicate this "depends on", then Kconfig allows you to
enable "A" even if the dependencies for "B" are not satisfied, causing
the build failure that Fabrice is fixing.
So, Fabrice patch is correct.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-17 7:08 ` Thomas Petazzoni
@ 2019-05-17 18:09 ` Giulio Benetti
0 siblings, 0 replies; 9+ messages in thread
From: Giulio Benetti @ 2019-05-17 18:09 UTC (permalink / raw)
To: buildroot
Hello Adrian, All,
Il 17/05/2019 09:08, Thomas Petazzoni ha scritto:
> Hello Adrian,
>
> On Fri, 17 May 2019 00:28:28 +0300
> Adrian Perez de Castro <aperez@igalia.com> wrote:
>
>> This is not correct. The short version of the story is tat WPE WebKit
>> itself does not require Wayland, only wpebackend-fdo uses Wayland.
>
> That does not matter.
>
> If A selects B, and B depends on C, then A *must* replicate the
> "depends on C". That's due to how Kconfig work, and it's totally
> unrelated to the fact that A doesn't use C directly in practice.
>
> If you don't replicate this "depends on", then Kconfig allows you to
> enable "A" even if the dependencies for "B" are not satisfied, causing
> the build failure that Fabrice is fixing.
>
> So, Fabrice patch is correct.
Thomas and Fabrice are correct because wpewebkit in its Config.in:
"select BR2_PACKAGE_WPEBACKEND_FDO"
Probably that's the problem, wpewebkit should not select that specific
Backend, but should let to the user the choice about which Backend to
use or even none.
This is why I've got confused too.
So Fabrice's patch fixes build failure, but probably we need another
patch to add the Backend choice.
What do you think?
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 20:12 [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency Fabrice Fontaine
2019-05-16 21:28 ` Adrian Perez de Castro
@ 2019-05-16 21:35 ` Giulio Benetti
2019-05-16 21:38 ` Giulio Benetti
2019-05-18 19:30 ` Thomas Petazzoni
2 siblings, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2019-05-16 21:35 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
> Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
> BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
> to add it to wpewebkit
>
> Fixes:
> - http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/wpewebkit/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> index 04ebe5452b..15db924829 100644
> --- a/package/wpewebkit/Config.in
> +++ b/package/wpewebkit/Config.in
> @@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++, wchar, threads, dynamic library, gc
> || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_HOST_GCC_AT_LEAST_4_8
>
> -comment "wpewebkit needs an OpenGL ES w/ EGL backend"
> +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
> depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> depends on !BR2_BINFMT_FLAT
> - depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
> + depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
> + || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>
> config BR2_PACKAGE_WPEWEBKIT
> bool "wpewebkit"
> @@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
> depends on BR2_USE_WCHAR # icu, libsoup
> depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
> depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
> + depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
> depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
> select BR2_PACKAGE_CAIRO
> select BR2_PACKAGE_CAIRO_PNG
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 21:35 ` Giulio Benetti
@ 2019-05-16 21:38 ` Giulio Benetti
2019-05-17 18:12 ` Giulio Benetti
0 siblings, 1 reply; 9+ messages in thread
From: Giulio Benetti @ 2019-05-16 21:38 UTC (permalink / raw)
To: buildroot
Il 16/05/2019 23:35, Giulio Benetti ha scritto:
> Hello Fabrice,
>
> Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
>> Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
>> BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
>> to add it to wpewebkit
>>
>> Fixes:
>> ? -
>> http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
>>
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Please discard this ^^^^^^^^^
>> ---
>> ? package/wpewebkit/Config.in | 6 ++++--
>> ? 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
>> index 04ebe5452b..15db924829 100644
>> --- a/package/wpewebkit/Config.in
>> +++ b/package/wpewebkit/Config.in
>> @@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++,
>> wchar, threads, dynamic library, gc
>> ????????? || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
>> ????????? || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||
>> !BR2_HOST_GCC_AT_LEAST_4_8
>> -comment "wpewebkit needs an OpenGL ES w/ EGL backend"
>> +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
>> ????? depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
>> ????? depends on !BR2_BINFMT_FLAT
>> -??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
>> +??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
>> +??????? || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>> ? config BR2_PACKAGE_WPEWEBKIT
>> ????? bool "wpewebkit"
>> @@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
>> ????? depends on BR2_USE_WCHAR # icu, libsoup
>> ????? depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
>> ????? depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
>> +??? depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
>> ????? depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
>> ????? select BR2_PACKAGE_CAIRO
>> ????? select BR2_PACKAGE_CAIRO_PNG
>>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 21:38 ` Giulio Benetti
@ 2019-05-17 18:12 ` Giulio Benetti
0 siblings, 0 replies; 9+ messages in thread
From: Giulio Benetti @ 2019-05-17 18:12 UTC (permalink / raw)
To: buildroot
Il 16/05/2019 23:38, Giulio Benetti ha scritto:
> Il 16/05/2019 23:35, Giulio Benetti ha scritto:
>> Hello Fabrice,
>>
>> Il 16/05/2019 22:12, Fabrice Fontaine ha scritto:
>>> Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
>>> BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
>>> to add it to wpewebkit
>>>
>>> Fixes:
>>> ? -
>>> http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
>>>
>>>
>>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>
>> Reviewed-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>
> Please discard this ^^^^^^^^^
Sorry, please keep my Reviewed-by.
Thanks
Best regards
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
>>> ---
>>> ? package/wpewebkit/Config.in | 6 ++++--
>>> ? 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
>>> index 04ebe5452b..15db924829 100644
>>> --- a/package/wpewebkit/Config.in
>>> +++ b/package/wpewebkit/Config.in
>>> @@ -35,10 +35,11 @@ comment "wpewebkit needs a toolchain w/ C++,
>>> wchar, threads, dynamic library, gc
>>> ????????? || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
>>> ????????? || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 ||
>>> !BR2_HOST_GCC_AT_LEAST_4_8
>>> -comment "wpewebkit needs an OpenGL ES w/ EGL backend"
>>> +comment "wpewebkit needs an OpenGL ES w/ EGL-capable Wayland backend"
>>> ????? depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
>>> ????? depends on !BR2_BINFMT_FLAT
>>> -??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
>>> +??? depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL \
>>> +??????? || !BR2_PACKAGE_HAS_LIBEGL_WAYLAND
>>> ? config BR2_PACKAGE_WPEWEBKIT
>>> ????? bool "wpewebkit"
>>> @@ -51,6 +52,7 @@ config BR2_PACKAGE_WPEWEBKIT
>>> ????? depends on BR2_USE_WCHAR # icu, libsoup
>>> ????? depends on BR2_PACKAGE_HAS_LIBGLES # libepoxy
>>> ????? depends on BR2_PACKAGE_HAS_LIBEGL # libepoxy
>>> +??? depends on BR2_PACKAGE_HAS_LIBEGL_WAYLAND # wpebackend-fdo
>>> ????? depends on BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS
>>> ????? select BR2_PACKAGE_CAIRO
>>> ????? select BR2_PACKAGE_CAIRO_PNG
>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency
2019-05-16 20:12 [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency Fabrice Fontaine
2019-05-16 21:28 ` Adrian Perez de Castro
2019-05-16 21:35 ` Giulio Benetti
@ 2019-05-18 19:30 ` Thomas Petazzoni
2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2019-05-18 19:30 UTC (permalink / raw)
To: buildroot
On Thu, 16 May 2019 22:12:20 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Commit 5b3c7a3e7828107eaa9dad49ba2650466277d891 added a
> BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency to wpebackend-fdo but forget
> to add it to wpewebkit
>
> Fixes:
> - http://autobuild.buildroot.net/results/49e04166de68358e69bce580b29ba3a25b313acf
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/wpewebkit/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-05-18 19:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-16 20:12 [Buildroot] [PATCH 1/1] package/wpewebkit: add BR2_PACKAGE_HAS_LIBEGL_WAYLAND dependency Fabrice Fontaine
2019-05-16 21:28 ` Adrian Perez de Castro
2019-05-17 6:43 ` Fabrice Fontaine
2019-05-17 7:08 ` Thomas Petazzoni
2019-05-17 18:09 ` Giulio Benetti
2019-05-16 21:35 ` Giulio Benetti
2019-05-16 21:38 ` Giulio Benetti
2019-05-17 18:12 ` Giulio Benetti
2019-05-18 19:30 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox