[Buildroot] [RFC PATCH 1/4] configs/bananapro_defconfig: bump Linux to 5.1.1

[Buildroot] [RFC PATCH 1/4] configs/bananapro_defconfig: bump Linux to 5.1.1

[Bartosz Bilas]

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 configs/bananapro_defconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configs/bananapro_defconfig b/configs/bananapro_defconfig
index a6433ee597..d5284bdd4c 100644
--- a/configs/bananapro_defconfig
+++ b/configs/bananapro_defconfig
@@ -4,8 +4,8 @@ BR2_cortex_a7=y
 BR2_ARM_EABIHF=y
 BR2_ARM_FPU_NEON_VFPV4=y
 
-# Linux headers same as kernel, a 4.14 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
+# Linux headers same as kernel, a 5.1 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_1=y
 
 # Toolchain
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -22,7 +22,7 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/lemaker/bananapro/post-image.sh"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.116"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.1.1"
 BR2_LINUX_KERNEL_USE_DEFCONFIG=y
 BR2_LINUX_KERNEL_DEFCONFIG="sunxi"
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/lemaker/bananapro/linux-wifi.fragment"
-- 
2.21.0

[Buildroot] [RFC PATCH 2/4] configs/bananapro_defconfig: set patches directory

[Bartosz Bilas]

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 configs/bananapro_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/bananapro_defconfig b/configs/bananapro_defconfig
index d5284bdd4c..56166c9428 100644
--- a/configs/bananapro_defconfig
+++ b/configs/bananapro_defconfig
@@ -1,6 +1,7 @@
 # Architecture
 BR2_arm=y
 BR2_cortex_a7=y
+BR2_GLOBAL_PATCH_DIR="board/lemaker/bananapro/patches"
 BR2_ARM_EABIHF=y
 BR2_ARM_FPU_NEON_VFPV4=y
 
-- 
2.21.0

[Buildroot] [RFC PATCH 3/4] board/lemaker/bananapro/patches/linux: add patch to disable 00B IRQ

[Bartosz Bilas]

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 ...s-sun7i-a20-bananapro.dts-disable-00.patch | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 board/lemaker/bananapro/patches/linux/0001-arch-arm-boot-dts-sun7i-a20-bananapro.dts-disable-00.patch

diff --git a/board/lemaker/bananapro/patches/linux/0001-arch-arm-boot-dts-sun7i-a20-bananapro.dts-disable-00.patch b/board/lemaker/bananapro/patches/linux/0001-arch-arm-boot-dts-sun7i-a20-bananapro.dts-disable-00.patch
new file mode 100644
index 0000000000..428f591eb6
--- /dev/null
+++ b/board/lemaker/bananapro/patches/linux/0001-arch-arm-boot-dts-sun7i-a20-bananapro.dts-disable-00.patch
@@ -0,0 +1,44 @@
+From 896e82ab14e7e4e361ffa7c81def787907c1bf4c Mon Sep 17 00:00:00 2001
+From: Bartosz Bilas <b.bilas@grinn-global.com>
+Date: Sun, 19 May 2019 21:04:35 +0200
+Subject: [PATCH 1/1] arch/arm/boot/dts/sun7i-a20-bananapro.dts: disable 00B
+ IRQ for brcm wifi module
+
+	BugLink: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908438
+
+Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
+Signed-off-by: Hans de Goede <hdegoede@redhat.com>
+---
+ arch/arm/boot/dts/sun7i-a20-bananapro.dts | 16 +++++++++++++---
+ 1 file changed, 13 insertions(+), 3 deletions(-)
+
+diff --git a/arch/arm/boot/dts/sun7i-a20-bananapro.dts b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+index 0176e9de0..93b3340f5 100644
+--- a/arch/arm/boot/dts/sun7i-a20-bananapro.dts
++++ b/arch/arm/boot/dts/sun7i-a20-bananapro.dts
+@@ -160,9 +160,19 @@
+ 	brcmf: wifi at 1 {
+ 		reg = <1>;
+ 		compatible = "brcm,bcm4329-fmac";
+-		interrupt-parent = <&pio>;
+-		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
+-		interrupt-names = "host-wake";
++		/*
++		 * OOB interrupt support is broken ATM, often the first irq
++		 * does not get seen resulting in the drv probe failing with:
++		 *
++		 * brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
++		 * brcmfmac: brcmf_bus_started: failed: -110
++		 * brcmfmac: brcmf_attach: dongle is not responding: err=-110
++		 * brcmfmac: brcmf_sdio_firmware_callback: brcmf_attach failed
++		 *
++		 * interrupt-parent = <&pio>;
++		 * interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
++		 * interrupt-names = "host-wake";
++		 */
+ 	};
+ };
+ 
+-- 
+2.21.0
+
-- 
2.21.0

[Buildroot] [RFC PATCH 4/4] board/lemaker/bananapro/rootfs_overlay: add symlink for brcmfmac43362-sdio file

[Bartosz Bilas]

This fixes following error:
     brcmfmac mmc1:0001:1: Direct firmware load for
     brcm/brcmfmac43362-sdio.lemaker,bananapro.txt failed with error -2

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
 .../lib/firmware/brcm/brcmfmac43362-sdio.lemaker,bananapro.txt   | 1 +
 1 file changed, 1 insertion(+)
 create mode 120000 board/lemaker/bananapro/rootfs_overlay/lib/firmware/brcm/brcmfmac43362-sdio.lemaker,bananapro.txt

diff --git a/board/lemaker/bananapro/rootfs_overlay/lib/firmware/brcm/brcmfmac43362-sdio.lemaker,bananapro.txt b/board/lemaker/bananapro/rootfs_overlay/lib/firmware/brcm/brcmfmac43362-sdio.lemaker,bananapro.txt
new file mode 120000
index 0000000000..93947975ee
--- /dev/null
+++ b/board/lemaker/bananapro/rootfs_overlay/lib/firmware/brcm/brcmfmac43362-sdio.lemaker,bananapro.txt
@@ -0,0 +1 @@
+brcmfmac43362-sdio.txt
\ No newline at end of file
-- 
2.21.0

[Buildroot] [RFC PATCH 1/4] configs/bananapro_defconfig: bump Linux to 5.1.1

[Thomas Petazzoni]

Hello,

On Mon, 20 May 2019 21:32:20 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:

> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
>  configs/bananapro_defconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Why did you split your changes into four patches ? As I understand it,
the current bananapro_defconfig already supports WiFi, so if the bump
to Linux 5.1.1 breaks WiFi and requires the fixes of the three other
patches, then you should have a single patch that does all.

Without this, you break bisectability: if I apply only your PATCH 1/4,
then the WiFi feature which was working is no longer working.

Of course, if WiFi was in fact not working with the current defconfig
(i.e before any of your patches), then it's fine to split the patches.
Just perhaps patches 2, 3 and 4 could be the same, because it's all
about making WiFi work.

Could you clarify this point, and send a new iteration ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [RFC PATCH 1/4] configs/bananapro_defconfig: bump Linux to 5.1.1

[Bartosz Biłas]

Hi Thomas,

On 26.05.2019 21:26, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 20 May 2019 21:32:20 +0200
> Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>> ---
>>   configs/bananapro_defconfig | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
> Why did you split your changes into four patches ? As I understand it,
> the current bananapro_defconfig already supports WiFi,
Yes, that's right.
>   so if the bump
> to Linux 5.1.1 breaks WiFi and requires the fixes of the three other
> patches, then you should have a single patch that does all.
>
> Without this, you break bisectability: if I apply only your PATCH 1/4,
> then the WiFi feature which was working is no longer working.
Ah, I haven't thought about that in that way, I'll keep it in my mind ;)
>
> Of course, if WiFi was in fact not working with the current defconfig
> (i.e before any of your patches), then it's fine to split the patches.
> Just perhaps patches 2, 3 and 4 could be the same, because it's all
> about making WiFi work.
Ok, thanks for the hints.
>
> Could you clarify this point, and send a new iteration ?
I've fixed that and I'm going to send a new one soon.
>
> Thanks,
>
> Thomas

Best

Bartek