* [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option
@ 2020-03-14 22:36 Fabrice Fontaine
2020-03-15 21:07 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Fabrice Fontaine @ 2020-03-14 22:36 UTC (permalink / raw)
To: buildroot
Use --with-sound option as requested by Thomas Petazzoni in review of
https://patchwork.ozlabs.org/patch/1254693
alsa, libao and pulseaudio are not exclusive, the order of registrations
in rdpsnd_register_drivers define the probe-order when opening the
device for the first time
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/rdesktop/rdesktop.mk | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/package/rdesktop/rdesktop.mk b/package/rdesktop/rdesktop.mk
index 672d85b5c5..1922c08edc 100644
--- a/package/rdesktop/rdesktop.mk
+++ b/package/rdesktop/rdesktop.mk
@@ -15,20 +15,32 @@ RDESKTOP_DEPENDENCIES = \
xlib_libX11 \
xlib_libXcursor \
xlib_libXt \
- $(if $(BR2_PACKAGE_ALSA_LIB_PCM),alsa-lib) \
- $(if $(BR2_PACKAGE_LIBAO),libao) \
$(if $(BR2_PACKAGE_LIBICONV),libiconv) \
$(if $(BR2_PACKAGE_LIBSAMPLERATE),libsamplerate) \
- $(if $(BR2_PACKAGE_PULSEAUDIO),pulseaudio) \
$(if $(BR2_PACKAGE_XLIB_LIBXRANDR),xlib_libXrandr)
RDESKTOP_CONF_OPTS = --disable-credssp
RDESKTOP_LICENSE = GPL-3.0+
RDESKTOP_LICENSE_FILES = COPYING
+ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
+RDESKTOP_DEPENDENCIES += alsa-lib
+RDESKTOP_CONF_OPTS += --with-sound=alsa
+endif
+
+ifeq ($(BR2_PACKAGE_LIBAO),y)
+RDESKTOP_DEPENDENCIES += libao
+RDESKTOP_CONF_OPTS += --with-sound=libao
+endif
+
ifeq ($(BR2_PACKAGE_PCSC_LITE),y)
RDESKTOP_DEPENDENCIES += pcsc-lite
else
RDESKTOP_CONF_OPTS += --disable-smartcard
endif
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
+RDESKTOP_DEPENDENCIES += pulseaudio
+RDESKTOP_CONF_OPTS += --with-sound=pulse
+endif
+
$(eval $(autotools-package))
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option
2020-03-14 22:36 [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option Fabrice Fontaine
@ 2020-03-15 21:07 ` Thomas Petazzoni
2020-03-15 21:10 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-03-15 21:07 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Sat, 14 Mar 2020 23:36:41 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Use --with-sound option as requested by Thomas Petazzoni in review of
> https://patchwork.ozlabs.org/patch/1254693
>
> alsa, libao and pulseaudio are not exclusive, the order of registrations
> in rdpsnd_register_drivers define the probe-order when opening the
> device for the first time
But if you pass a single --with-sound=foo, don't they become mutually
exclusive ? Does the configure script properly handles --with-sound=foo
--with-sound=bar, and understands it should enable both support for
"foo" and "bar" ? I think a normal configure script would only keep
"bar" in such a circumstance.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option
2020-03-15 21:07 ` Thomas Petazzoni
@ 2020-03-15 21:10 ` Yann E. MORIN
2020-03-15 21:50 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-03-15 21:10 UTC (permalink / raw)
To: buildroot
Fabrice, Thomas, All,
On 2020-03-15 22:07 +0100, Thomas Petazzoni spake thusly:
> On Sat, 14 Mar 2020 23:36:41 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Use --with-sound option as requested by Thomas Petazzoni in review of
> > https://patchwork.ozlabs.org/patch/1254693
> >
> > alsa, libao and pulseaudio are not exclusive, the order of registrations
> > in rdpsnd_register_drivers define the probe-order when opening the
> > device for the first time
>
> But if you pass a single --with-sound=foo, don't they become mutually
> exclusive ? Does the configure script properly handles --with-sound=foo
> --with-sound=bar, and understands it should enable both support for
> "foo" and "bar" ? I think a normal configure script would only keep
> "bar" in such a circumstance.
Which is indeed what happens here;
https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L286
Regards,
Yann E. MORIN.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option
2020-03-15 21:10 ` Yann E. MORIN
@ 2020-03-15 21:50 ` Thomas Petazzoni
2020-03-15 22:14 ` Fabrice Fontaine
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-03-15 21:50 UTC (permalink / raw)
To: buildroot
On Sun, 15 Mar 2020 22:10:18 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Which is indeed what happens here;
>
> https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L286
If I read
https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L323
correctly, it means that --with-sound (or --with-sound=yes) will allow
multiple audio backends to be supported at the same time.
While passing any other --with-sound=foo will only support the foo
audio backend.
So in fact, passing --with-sound=foo is annoying, because you cannot
support multiple audio backends.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option
2020-03-15 21:50 ` Thomas Petazzoni
@ 2020-03-15 22:14 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2020-03-15 22:14 UTC (permalink / raw)
To: buildroot
Dear all,
Le dim. 15 mars 2020 ? 22:50, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Sun, 15 Mar 2020 22:10:18 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>
> > Which is indeed what happens here;
> >
> > https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L286
>
> If I read
> https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L323
> correctly, it means that --with-sound (or --with-sound=yes) will allow
> multiple audio backends to be supported at the same time.
>
> While passing any other --with-sound=foo will only support the foo
> audio backend.
>
> So in fact, passing --with-sound=foo is annoying, because you cannot
> support multiple audio backends.
Indeed, I was too quick on this one, I'll set it as rejected.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-15 22:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-14 22:36 [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound option Fabrice Fontaine
2020-03-15 21:07 ` Thomas Petazzoni
2020-03-15 21:10 ` Yann E. MORIN
2020-03-15 21:50 ` Thomas Petazzoni
2020-03-15 22:14 ` Fabrice Fontaine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox