public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures
@ 2020-04-19 23:38 James Hilliard
  2020-04-20  5:54 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2020-04-19 23:38 UTC (permalink / raw)
  To: buildroot

Fixes:
http://autobuild.buildroot.net/results/416/4161bfcd9577cdc6b9795fc3d6903f3bcc124f99/build-end.log
http://autobuild.buildroot.net/results/be7/be709462bbab54e4f405302d54d157218f867939/build-end.log
http://autobuild.buildroot.net/results/b0c/b0ca52e3948cbbc5bb8c6ce08932e355653b08d7/build-end.log
http://autobuild.buildroot.net/results/cd7/cd748aa26fdabcef72a581e1fe26edac14d07d2d/build-end.log

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/python-greenlet/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/python-greenlet/Config.in b/package/python-greenlet/Config.in
index ef82375b0b..eae76ef6be 100644
--- a/package/python-greenlet/Config.in
+++ b/package/python-greenlet/Config.in
@@ -1,5 +1,11 @@
 config BR2_PACKAGE_PYTHON_GREENLET
 	bool "python-greenlet"
+	depends on !BR2_arceb
+	depends on !BR2_arcle
+	depends on !BR2_microblazebe
+	depends on !BR2_microblazeel
+	depends on !BR2_or1k
+	depends on !BR2_sh
 	help
 	  Lightweight in-process concurrent programming.
 
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures
  2020-04-19 23:38 [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures James Hilliard
@ 2020-04-20  5:54 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-04-20  5:54 UTC (permalink / raw)
  To: buildroot

On Sun, 19 Apr 2020 17:38:23 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> diff --git a/package/python-greenlet/Config.in b/package/python-greenlet/Config.in
> index ef82375b0b..eae76ef6be 100644
> --- a/package/python-greenlet/Config.in
> +++ b/package/python-greenlet/Config.in
> @@ -1,5 +1,11 @@
>  config BR2_PACKAGE_PYTHON_GREENLET
>  	bool "python-greenlet"
> +	depends on !BR2_arceb
> +	depends on !BR2_arcle
> +	depends on !BR2_microblazebe
> +	depends on !BR2_microblazeel
> +	depends on !BR2_or1k
> +	depends on !BR2_sh

We prefer to use a BR2_PACKAGE_foo_ARCH_SUPPORTS hidden boolean, and to
use positive logic (i.e enable the package for supported architectures,
not disable for unsupported one). For example, you had probably missed
nios2 or nds32 as unsupported architectures.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-20  5:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-19 23:38 [Buildroot] [PATCH 1/1] package/python-greenlet: disable on unsupported architectures James Hilliard
2020-04-20  5:54 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox