* [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation
@ 2020-06-03 10:38 Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Peter Seiderer @ 2020-06-03 10:38 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- split of from original patch (suggested by Thomas Petazzoni)
---
package/bcm2835/bcm2835.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
index d43dd7e574..f75b2fc69e 100644
--- a/package/bcm2835/bcm2835.mk
+++ b/package/bcm2835/bcm2835.mk
@@ -10,4 +10,7 @@ BCM2835_LICENSE = GPL-3.0
BCM2835_LICENSE_FILES = COPYING
BCM2835_INSTALL_STAGING = YES
+# disable doxygen doc generation
+BCM2835_CONF_ENV = ac_cv_prog_DOXYGEN=/bin/true
+
$(eval $(autotools-package))
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65
2020-06-03 10:38 [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Peter Seiderer
@ 2020-06-03 10:38 ` Peter Seiderer
2020-06-03 21:32 ` Yann E. MORIN
2020-06-03 10:38 ` [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support Peter Seiderer
2020-06-03 21:25 ` [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Yann E. MORIN
2 siblings, 1 reply; 6+ messages in thread
From: Peter Seiderer @ 2020-06-03 10:38 UTC (permalink / raw)
To: buildroot
Changes since 1.63:
- 1.64 2020-04-11 Fixed error in definitions of BCM2835_AUX_SPI_STAT_TX_LVL
and BCM2835_AUX_SPI_STAT_RX_LVL
- 1.65, 1.66 2020-04-16 Added support for use of capability cap_sys_rawio
to determine if access to /dev/mem is available for non-root users
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- split original patch into three independent ones
---
package/bcm2835/bcm2835.hash | 2 +-
package/bcm2835/bcm2835.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/bcm2835/bcm2835.hash b/package/bcm2835/bcm2835.hash
index c722a97456..8317e10256 100644
--- a/package/bcm2835/bcm2835.hash
+++ b/package/bcm2835/bcm2835.hash
@@ -1,3 +1,3 @@
# Locally computed:
-sha256 aec4b33ed9ecda4a1c4c12b8ed2abdd13cf87f352f0d27a24be726d11f1fbf54 bcm2835-1.63.tar.gz
+sha256 62955cc8506cc6506d729da3138442beb9763f1ffd536e925aeb0dc223492874 bcm2835-1.65.tar.gz
sha256 8b1ba204bb69a0ade2bfcf65ef294a920f6bb361b317dba43c7ef29d96332b9b COPYING
diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
index f75b2fc69e..2ef6d94b38 100644
--- a/package/bcm2835/bcm2835.mk
+++ b/package/bcm2835/bcm2835.mk
@@ -4,7 +4,7 @@
#
################################################################################
-BCM2835_VERSION = 1.63
+BCM2835_VERSION = 1.65
BCM2835_SITE = http://www.airspayce.com/mikem/bcm2835
BCM2835_LICENSE = GPL-3.0
BCM2835_LICENSE_FILES = COPYING
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
@ 2020-06-03 21:32 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-06-03 21:32 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2020-06-03 12:38 +0200, Peter Seiderer spake thusly:
> Changes since 1.63:
> - 1.64 2020-04-11 Fixed error in definitions of BCM2835_AUX_SPI_STAT_TX_LVL
> and BCM2835_AUX_SPI_STAT_RX_LVL
> - 1.65, 1.66 2020-04-16 Added support for use of capability cap_sys_rawio
> to determine if access to /dev/mem is available for non-root users
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Appleid to master, after adding an explanation about why we don;t use
capabilities and how it is borked upstream.
I'm not going to apply the third patch, however: this must be fixed
upstream, period (this package is definitely not a nice package...)
Previously, that library required running as root; it still does. Not
supporting capabilities is thus not a regression.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - split original patch into three independent ones
> ---
> package/bcm2835/bcm2835.hash | 2 +-
> package/bcm2835/bcm2835.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/bcm2835/bcm2835.hash b/package/bcm2835/bcm2835.hash
> index c722a97456..8317e10256 100644
> --- a/package/bcm2835/bcm2835.hash
> +++ b/package/bcm2835/bcm2835.hash
> @@ -1,3 +1,3 @@
> # Locally computed:
> -sha256 aec4b33ed9ecda4a1c4c12b8ed2abdd13cf87f352f0d27a24be726d11f1fbf54 bcm2835-1.63.tar.gz
> +sha256 62955cc8506cc6506d729da3138442beb9763f1ffd536e925aeb0dc223492874 bcm2835-1.65.tar.gz
> sha256 8b1ba204bb69a0ade2bfcf65ef294a920f6bb361b317dba43c7ef29d96332b9b COPYING
> diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
> index f75b2fc69e..2ef6d94b38 100644
> --- a/package/bcm2835/bcm2835.mk
> +++ b/package/bcm2835/bcm2835.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -BCM2835_VERSION = 1.63
> +BCM2835_VERSION = 1.65
> BCM2835_SITE = http://www.airspayce.com/mikem/bcm2835
> BCM2835_LICENSE = GPL-3.0
> BCM2835_LICENSE_FILES = COPYING
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support
2020-06-03 10:38 [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
@ 2020-06-03 10:38 ` Peter Seiderer
2020-06-03 21:14 ` Yann E. MORIN
2020-06-03 21:25 ` [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Yann E. MORIN
2 siblings, 1 reply; 6+ messages in thread
From: Peter Seiderer @ 2020-06-03 10:38 UTC (permalink / raw)
To: buildroot
Add cap_sys_rawio capability support in case libcap is available.
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- split of from original patch and fixed for
BCM2835_HAVE_LIBCAP/BCM2835_HAVE_LIBCAP2 typo
---
package/bcm2835/bcm2835.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
index 2ef6d94b38..1cabd72e5d 100644
--- a/package/bcm2835/bcm2835.mk
+++ b/package/bcm2835/bcm2835.mk
@@ -13,4 +13,10 @@ BCM2835_INSTALL_STAGING = YES
# disable doxygen doc generation
BCM2835_CONF_ENV = ac_cv_prog_DOXYGEN=/bin/true
+ifeq ($(BR2_PACKAGE_LIBCAP),y)
+BCM2835_DEPENDENCIES = libcap
+# workaround typo in src/bcm2835.c and use both defines
+BCM2835_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -DBCM2835_HAVE_LIBCAP -DBCM2835_HAVE_LIBCAP2"
+endif
+
$(eval $(autotools-package))
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support
2020-06-03 10:38 ` [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support Peter Seiderer
@ 2020-06-03 21:14 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-06-03 21:14 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2020-06-03 12:38 +0200, Peter Seiderer spake thusly:
> Add cap_sys_rawio capability support in case libcap is available.
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - split of from original patch and fixed for
> BCM2835_HAVE_LIBCAP/BCM2835_HAVE_LIBCAP2 typo
> ---
> package/bcm2835/bcm2835.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
> index 2ef6d94b38..1cabd72e5d 100644
> --- a/package/bcm2835/bcm2835.mk
> +++ b/package/bcm2835/bcm2835.mk
> @@ -13,4 +13,10 @@ BCM2835_INSTALL_STAGING = YES
> # disable doxygen doc generation
> BCM2835_CONF_ENV = ac_cv_prog_DOXYGEN=/bin/true
>
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +BCM2835_DEPENDENCIES = libcap
> +# workaround typo in src/bcm2835.c and use both defines
> +BCM2835_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -DBCM2835_HAVE_LIBCAP -DBCM2835_HAVE_LIBCAP2"
As reported by Thomas, this is just a stupid bug in the code. It should
be fixed by sending upstream a patch.
(note: this is hilarious... not.)
Regards,
Yann E. MORIN.
> +endif
> +
> $(eval $(autotools-package))
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation
2020-06-03 10:38 [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support Peter Seiderer
@ 2020-06-03 21:25 ` Yann E. MORIN
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2020-06-03 21:25 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2020-06-03 12:38 +0200, Peter Seiderer spake thusly:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - split of from original patch (suggested by Thomas Petazzoni)
> ---
> package/bcm2835/bcm2835.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/bcm2835/bcm2835.mk b/package/bcm2835/bcm2835.mk
> index d43dd7e574..f75b2fc69e 100644
> --- a/package/bcm2835/bcm2835.mk
> +++ b/package/bcm2835/bcm2835.mk
> @@ -10,4 +10,7 @@ BCM2835_LICENSE = GPL-3.0
> BCM2835_LICENSE_FILES = COPYING
> BCM2835_INSTALL_STAGING = YES
>
> +# disable doxygen doc generation
> +BCM2835_CONF_ENV = ac_cv_prog_DOXYGEN=/bin/true
> +
> $(eval $(autotools-package))
> --
> 2.26.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-03 21:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-03 10:38 [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Peter Seiderer
2020-06-03 10:38 ` [Buildroot] [PATCH v2 2/3] package/bcm2835: bump version to 1.65 Peter Seiderer
2020-06-03 21:32 ` Yann E. MORIN
2020-06-03 10:38 ` [Buildroot] [PATCH v2 3/3] package/bcm2835: add cap_sys_rawio capability support Peter Seiderer
2020-06-03 21:14 ` Yann E. MORIN
2020-06-03 21:25 ` [Buildroot] [PATCH v2 1/3] package/bcm2835: disable doxygen doc generation Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox