[Buildroot] [PATCH 1/1] rpi-firmware: do not rename startup files

[Yann E. MORIN <yann.morin.1998@free.fr>]

St?phane, All,

On 2020-06-25 19:30 +0200, St?phane Veyret spake thusly:
> > > Le jeu. 25 juin 2020 ? 18:23, Peter Seiderer <ps.report@gmx.net> a ?crit :
> > > > > I think we should instead force the name of the startup files in the
> > > > > config.txt (in package/rpi-firmware/config.txt):
> > > > >     start_file=start.elf
> > > > >     fixup_file=fixup.dat
> > > > Or one step further, copy the start/fixup file verbatim and only change the
> > > > start_file/fixup_file entry in config.txt (with the advantage to make it
> > > > transparent which files are installed/in-use)...
> > > If the file name is already the appropriate one (this is the first
> > > version of my patch), using start_file and fixup_file is useless. And
> > > I don't feel it is a good idea to set start_file and fixup_file if the
> > > files already have expected names, because using these options is
> > > discouraged: https://www.raspberrypi.org/documentation/configuration/config-txt/boot.md.
> > The options are not discouraged, but 'advanced options' and should be handled with care ;-)
> > The advantage of the explicit start_file/fixup_file entries is that it is clear/determined
> > which files are used (instead of relaying on the RPi 'magic' depending on the combination
> > of other options)....
> OK, I understand. Yann, do you agree? Shall I create a v3 patch?

I do agree that we better force the names of the file to load, yes.

No, you do not need to send a v3, as I explained in my reply to Peter.

I'll will probably apply your v2 patch as-is shortly...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'