* [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
@ 2020-08-23 17:03 Yann E. MORIN
2020-08-23 17:06 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-08-23 17:03 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=de9e0f1f00cc4491ef67722b93fb77040ef63043
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
hash extension can't be disabled since version 7.4.0 and
https://github.com/php/php-src/commit/bf344425812b0f6156d0a8a54ed7bc38054f7636
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Config.in.legacy | 6 ++++++
package/php/Config.ext | 7 -------
package/php/php.mk | 1 -
3 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index cf7aaf75a5..957cbb8b3c 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -146,6 +146,12 @@ endif
comment "Legacy options removed in 2020.08"
+config BR2_PACKAGE_PHP_EXT_HASH
+ bool "php hash extension is mandatory"
+ select BR2_LEGACY
+ help
+ Since php 7.4.0, hash extension can't be disabled.
+
config BR2_PACKAGE_EFL_GIF
bool "efl evas gif loader is mandatory"
select BR2_LEGACY
diff --git a/package/php/Config.ext b/package/php/Config.ext
index 556276da97..44afea010b 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -65,11 +65,6 @@ config BR2_PACKAGE_PHP_EXT_ZLIB
comment "Cryptography extensions"
-config BR2_PACKAGE_PHP_EXT_HASH
- bool "hash"
- help
- HASH message digest framework
-
comment "libargon2 needs a toolchain w/ dynamic library"
depends on BR2_USE_MMU
depends on BR2_STATIC_LIBS
@@ -136,7 +131,6 @@ endif
config BR2_PACKAGE_PHP_EXT_MYSQLI
bool "Mysqli"
- select BR2_PACKAGE_PHP_EXT_HASH
help
MySQL Improved extension support
@@ -168,7 +162,6 @@ if BR2_PACKAGE_PHP_EXT_PDO
config BR2_PACKAGE_PHP_EXT_PDO_MYSQL
bool "MySQL"
- select BR2_PACKAGE_PHP_EXT_HASH
help
PDO driver for MySQL
diff --git a/package/php/php.mk b/package/php/php.mk
index ef9c7e8644..d9516ae127 100644
--- a/package/php/php.mk
+++ b/package/php/php.mk
@@ -97,7 +97,6 @@ PHP_CONF_OPTS += \
$(if $(BR2_PACKAGE_PHP_EXT_SOCKETS),--enable-sockets) \
$(if $(BR2_PACKAGE_PHP_EXT_POSIX),--enable-posix) \
$(if $(BR2_PACKAGE_PHP_EXT_SESSION),--enable-session) \
- $(if $(BR2_PACKAGE_PHP_EXT_HASH),--enable-hash) \
$(if $(BR2_PACKAGE_PHP_EXT_DOM),--enable-dom) \
$(if $(BR2_PACKAGE_PHP_EXT_SIMPLEXML),--enable-simplexml) \
$(if $(BR2_PACKAGE_PHP_EXT_SOAP),--enable-soap) \
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
2020-08-23 17:03 [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH Yann E. MORIN
@ 2020-08-23 17:06 ` Thomas Petazzoni
2020-08-24 8:25 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2020-08-23 17:06 UTC (permalink / raw)
To: buildroot
On Sun, 23 Aug 2020 19:03:20 +0200
Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=de9e0f1f00cc4491ef67722b93fb77040ef63043
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> hash extension can't be disabled since version 7.4.0 and
> https://github.com/php/php-src/commit/bf344425812b0f6156d0a8a54ed7bc38054f7636
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Config.in.legacy | 6 ++++++
> package/php/Config.ext | 7 -------
> package/php/php.mk | 1 -
> 3 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index cf7aaf75a5..957cbb8b3c 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -146,6 +146,12 @@ endif
>
> comment "Legacy options removed in 2020.08"
>
> +config BR2_PACKAGE_PHP_EXT_HASH
> + bool "php hash extension is mandatory"
> + select BR2_LEGACY
> + help
> + Since php 7.4.0, hash extension can't be disabled.
In this sort of situation, we generally don't add any legacy handling.
Indeed, since the feature is now mandatory... the default behavior will
always be OK.
People who could be annoyed are people who had this feature disabled...
which is now always enabled. But the legacy handling will anyway not
help those people.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
2020-08-23 17:06 ` Thomas Petazzoni
@ 2020-08-24 8:25 ` Yann E. MORIN
2020-08-24 8:33 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-08-24 8:25 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-08-23 19:06 +0200, Thomas Petazzoni spake thusly:
> On Sun, 23 Aug 2020 19:03:20 +0200
> Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> > commit: https://git.buildroot.net/buildroot/commit/?id=de9e0f1f00cc4491ef67722b93fb77040ef63043
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> > hash extension can't be disabled since version 7.4.0 and
> > https://github.com/php/php-src/commit/bf344425812b0f6156d0a8a54ed7bc38054f7636
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> > ---
> > Config.in.legacy | 6 ++++++
> > package/php/Config.ext | 7 -------
> > package/php/php.mk | 1 -
> > 3 files changed, 6 insertions(+), 8 deletions(-)
> >
> > diff --git a/Config.in.legacy b/Config.in.legacy
> > index cf7aaf75a5..957cbb8b3c 100644
> > --- a/Config.in.legacy
> > +++ b/Config.in.legacy
> > @@ -146,6 +146,12 @@ endif
> >
> > comment "Legacy options removed in 2020.08"
> >
> > +config BR2_PACKAGE_PHP_EXT_HASH
> > + bool "php hash extension is mandatory"
> > + select BR2_LEGACY
> > + help
> > + Since php 7.4.0, hash extension can't be disabled.
>
> In this sort of situation, we generally don't add any legacy handling.
> Indeed, since the feature is now mandatory... the default behavior will
> always be OK.
>
> People who could be annoyed are people who had this feature disabled...
> which is now always enabled. But the legacy handling will anyway not
> help those people.
Damn. indeed... I'll push a commit to drop it.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
2020-08-24 8:25 ` Yann E. MORIN
@ 2020-08-24 8:33 ` Yann E. MORIN
2020-08-24 13:12 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2020-08-24 8:33 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2020-08-24 10:25 +0200, Yann E. MORIN spake thusly:
> On 2020-08-23 19:06 +0200, Thomas Petazzoni spake thusly:
> > On Sun, 23 Aug 2020 19:03:20 +0200
> > Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > > +config BR2_PACKAGE_PHP_EXT_HASH
> > > + bool "php hash extension is mandatory"
> > > + select BR2_LEGACY
> > > + help
> > > + Since php 7.4.0, hash extension can't be disabled.
> > In this sort of situation, we generally don't add any legacy handling.
> > Indeed, since the feature is now mandatory... the default behavior will
> > always be OK.
[--SNIP--]
> Damn. indeed... I'll push a commit to drop it.
While doing so, I notice we do have similar now-mandatory options from
the EFL package, with commit 6deaa3d50de (package/efl: bump to version
1.23.2).
Shall I drop those too?
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH
2020-08-24 8:33 ` Yann E. MORIN
@ 2020-08-24 13:12 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2020-08-24 13:12 UTC (permalink / raw)
To: buildroot
On Mon, 24 Aug 2020 10:33:06 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> While doing so, I notice we do have similar now-mandatory options from
> the EFL package, with commit 6deaa3d50de (package/efl: bump to version
> 1.23.2).
>
> Shall I drop those too?
Indeed, those are not needed, we can drop them. Thanks for noticing!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-24 13:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-23 17:03 [Buildroot] [git commit] package/php: drop BR2_PACKAGE_PHP_EXT_HASH Yann E. MORIN
2020-08-23 17:06 ` Thomas Petazzoni
2020-08-24 8:25 ` Yann E. MORIN
2020-08-24 8:33 ` Yann E. MORIN
2020-08-24 13:12 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox