From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k
Date: Fri, 4 Sep 2020 14:52:37 +0200 [thread overview]
Message-ID: <20200904145237.0b1acf0d@windsurf.home> (raw)
In-Reply-To: <20200904095148.844292-2-kieran.bingham@ideasonboard.com>
On Fri, 4 Sep 2020 10:51:45 +0100
Kieran Bingham <kieran.bingham@ideasonboard.com> wrote:
> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> index 960d78b82e95..1ea747d1c57e 100644
> --- a/package/libcamera/Config.in
> +++ b/package/libcamera/Config.in
> @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
> depends on !BR2_STATIC_LIBS # gnutls
> depends on BR2_USE_WCHAR # gnutls
> + # Invalid packing size of ControlValue struct on m68k
> + depends on !BR2_m68k
Another comment: this dependency should be replicated in the Config.in
comment for libcamera, so that the comment that says "libcamera needs a
toolchain w/ ..." doesn't appear on m68k... which would be meaningless
as libcamera is not available at all for this architecture.
In general, we like to have:
config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
config
default y
depends on !BR2_m68k
and then use that in BR2_PACKAGE_LIBCAMERA and the Config.in comment.
This way, if other packages select libcamera, they can also re-use this
"depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS".
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-09-04 12:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 9:51 [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Kieran Bingham
2020-09-04 9:51 ` [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k Kieran Bingham
2020-09-04 12:50 ` Thomas Petazzoni
2020-09-04 12:52 ` Kieran Bingham
2020-09-04 12:52 ` Thomas Petazzoni [this message]
2020-09-04 20:33 ` Yann E. MORIN
2020-09-04 20:36 ` Yann E. MORIN
2020-09-05 12:31 ` Peter Korsgaard
2020-09-04 9:51 ` [Buildroot] [PATCH 2/3] package/libcamera: Update requirements for C++17 Kieran Bingham
2020-09-04 12:51 ` Thomas Petazzoni
2020-09-04 12:55 ` Kieran Bingham
2020-09-04 13:53 ` Thomas Petazzoni
2020-09-04 13:56 ` Yann E. MORIN
2020-09-04 9:51 ` [Buildroot] [PATCH 3/3] package/libcamera: bump version to e59713c6 Kieran Bingham
2020-11-17 17:47 ` [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Eugen.Hristev at microchip.com
2020-11-17 21:20 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904145237.0b1acf0d@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox