Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k
Date: Fri, 4 Sep 2020 22:36:13 +0200	[thread overview]
Message-ID: <20200904203613.GM14354@scaer> (raw)
In-Reply-To: <20200904203358.GL14354@scaer>

Kieran, All,

On 2020-09-04 22:33 +0200, Yann E. MORIN spake thusly:
> On 2020-09-04 10:51 +0100, Kieran Bingham spake thusly:
> > The ControlValue structure is currently defined with a 16-bit hole
> > (causing unaligned access to the numElements_ field, though that's a
> > separate topic).
> > 
> > This structure has a static assertion to ensure that its size does not
> > change without due care, as it forms part of our ABI and is used in
> > Serialisation between the pipeline handlers and IPA componenents.
> > 
> > The m68k architecture is the only target which fails this assertion,
> > which is likely because it can pack the structure more efficiently,
> > producing a different binary size.
> > 
> > This is likely an area we will tackle before stabilising our ABI, but
> > until then, disable m68k builds as libcamera is not expected to be
> > supported on this target.
> > 
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> Applied to master, after doing the slight adjustments suggested by
> Thomas:
> 
>   - introduce BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
>   - propagate that to the comment
>   - add autobuilder reference

Ah, I forgot to note:
  - move the arch dependency to the top (indeed we like to have those
    dependencies first:
        https://buildroot.org/downloads/manual/manual.html#_config_files

Cheers!

Regards,
Yann E. MORIN.

> Thanks!
> 
> Regards,
> Yann E. MORIN.
> 
> > ---
> >  package/libcamera/Config.in | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
> > index 960d78b82e95..1ea747d1c57e 100644
> > --- a/package/libcamera/Config.in
> > +++ b/package/libcamera/Config.in
> > @@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
> >  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
> >  	depends on !BR2_STATIC_LIBS # gnutls
> >  	depends on BR2_USE_WCHAR # gnutls
> > +	# Invalid packing size of ControlValue struct on m68k
> > +	depends on !BR2_m68k
> >  	select BR2_PACKAGE_GNUTLS
> >  	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
> >  	help
> > -- 
> > 2.25.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-09-04 20:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  9:51 [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Kieran Bingham
2020-09-04  9:51 ` [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k Kieran Bingham
2020-09-04 12:50   ` Thomas Petazzoni
2020-09-04 12:52     ` Kieran Bingham
2020-09-04 12:52   ` Thomas Petazzoni
2020-09-04 20:33   ` Yann E. MORIN
2020-09-04 20:36     ` Yann E. MORIN [this message]
2020-09-05 12:31   ` Peter Korsgaard
2020-09-04  9:51 ` [Buildroot] [PATCH 2/3] package/libcamera: Update requirements for C++17 Kieran Bingham
2020-09-04 12:51   ` Thomas Petazzoni
2020-09-04 12:55     ` Kieran Bingham
2020-09-04 13:53       ` Thomas Petazzoni
2020-09-04 13:56       ` Yann E. MORIN
2020-09-04  9:51 ` [Buildroot] [PATCH 3/3] package/libcamera: bump version to e59713c6 Kieran Bingham
2020-11-17 17:47 ` [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Eugen.Hristev at microchip.com
2020-11-17 21:20   ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200904203613.GM14354@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox