buildroot.buildroot.org archive mirror
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k
Date: Sat, 05 Sep 2020 14:31:41 +0200	[thread overview]
Message-ID: <87ft7wjtg2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200904095148.844292-2-kieran.bingham@ideasonboard.com> (Kieran Bingham's message of "Fri, 4 Sep 2020 10:51:45 +0100")

>>>>> "Kieran" == Kieran Bingham <kieran.bingham@ideasonboard.com> writes:

 > The ControlValue structure is currently defined with a 16-bit hole
 > (causing unaligned access to the numElements_ field, though that's a
 > separate topic).

 > This structure has a static assertion to ensure that its size does not
 > change without due care, as it forms part of our ABI and is used in
 > Serialisation between the pipeline handlers and IPA componenents.

 > The m68k architecture is the only target which fails this assertion,
 > which is likely because it can pack the structure more efficiently,
 > producing a different binary size.

 > This is likely an area we will tackle before stabilising our ABI, but
 > until then, disable m68k builds as libcamera is not expected to be
 > supported on this target.

 > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Committed to 2020.08.x, thanks.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2020-09-05 12:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  9:51 [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Kieran Bingham
2020-09-04  9:51 ` [Buildroot] [PATCH 1/3] package/libcamera: Prevent builds on m68k Kieran Bingham
2020-09-04 12:50   ` Thomas Petazzoni
2020-09-04 12:52     ` Kieran Bingham
2020-09-04 12:52   ` Thomas Petazzoni
2020-09-04 20:33   ` Yann E. MORIN
2020-09-04 20:36     ` Yann E. MORIN
2020-09-05 12:31   ` Peter Korsgaard [this message]
2020-09-04  9:51 ` [Buildroot] [PATCH 2/3] package/libcamera: Update requirements for C++17 Kieran Bingham
2020-09-04 12:51   ` Thomas Petazzoni
2020-09-04 12:55     ` Kieran Bingham
2020-09-04 13:53       ` Thomas Petazzoni
2020-09-04 13:56       ` Yann E. MORIN
2020-09-04  9:51 ` [Buildroot] [PATCH 3/3] package/libcamera: bump version to e59713c6 Kieran Bingham
2020-11-17 17:47 ` [Buildroot] [PATCH 0/3] libcamera: Fix and update libcamera package Eugen.Hristev at microchip.com
2020-11-17 21:20   ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft7wjtg2.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).