Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package
Date: Sat, 5 Sep 2020 21:22:09 +0200	[thread overview]
Message-ID: <20200905212209.1e476db9@windsurf.home> (raw)
In-Reply-To: <87v9gsus6t.fsf@posteo.net>

Hello,

On Sat, 05 Sep 2020 18:03:22 +0200
Alexander Egorenkov <egorenar-dev@posteo.net> wrote:

> > Hmm, i checked the usr/include/linux/elf.h and it defines
> > PN_XNUM but makedumpfile doesn't include this one and takes the one from
> > glibc which is much bigger but doesn't contain this define,
> > unfortunately. One option would be to patch makedumpfile and define
> > PN_XNUM if it not yet defined, not sure whether this the way you want to
> > go ? At least we wouldn't possibly break any other packages. What do you
> > think ?
> > This is just stupid, why would elfutils override glibc's elf.h, sigh.
> 
> I checked glibc and it defines the PN_XNUM constant, it seems that
> uClibc doesn't. Another possible solution would be to make makedumpfile
> depend on glibc, what do you think ? That would mean no uClibc support
> for this package.

Indeed, I hadn't noticed that glibc and musl define PN_XNUM, but not
uClibc. Good catch.

I guess the simplest then is to do what OpenSuse is doing:
https://build.opensuse.org/package/view_file/Kernel:kdump/makedumpfile/makedumpfile-PN_XNUM.patch?expand=1.
I had already seen it, found it not a great solution, but it's indeed
the simplest.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-09-05 19:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 11:12 [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package Alexander Egorenkov
2020-09-03 21:26 ` Thomas Petazzoni
2020-09-05 15:35   ` Alexander Egorenkov
2020-09-05 16:03     ` Alexander Egorenkov
2020-09-05 19:22       ` Thomas Petazzoni [this message]
2020-09-05 19:41         ` Alexander Egorenkov
2020-09-05 16:17   ` Alexander Egorenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200905212209.1e476db9@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox