Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar-dev@posteo.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package
Date: Sat, 05 Sep 2020 18:17:54 +0200	[thread overview]
Message-ID: <87sgbwuril.fsf@posteo.net> (raw)
In-Reply-To: <20200903232648.6be84338@windsurf.home>


> [PATCH 1/1] shouldn't be there, it should be just [PATCH]. This is
> verified by "make check-package" in Buildroot.
>

Fixed. I didn't want to touch it because it came from upstream.
Hmm, i run 'make check-package' but it didn't catch it, but the check
found trailing spaces in makedumpfile/Config.in :)

>
> Minor nit: we need you to add your own Signed-off-by, right after the
> other Signed-off-by that are already there.


Fixed.

Thanks for feedback
Regards
Alex

      parent reply	other threads:[~2020-09-05 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 11:12 [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package Alexander Egorenkov
2020-09-03 21:26 ` Thomas Petazzoni
2020-09-05 15:35   ` Alexander Egorenkov
2020-09-05 16:03     ` Alexander Egorenkov
2020-09-05 19:22       ` Thomas Petazzoni
2020-09-05 19:41         ` Alexander Egorenkov
2020-09-05 16:17   ` Alexander Egorenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgbwuril.fsf@posteo.net \
    --to=egorenar-dev@posteo.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox