From: Alexander Egorenkov <egorenar-dev@posteo.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package
Date: Sat, 05 Sep 2020 18:03:22 +0200 [thread overview]
Message-ID: <87v9gsus6t.fsf@posteo.net> (raw)
In-Reply-To: <87y2louth0.fsf@posteo.net>
Alexander Egorenkov <egorenar-dev@posteo.net> writes:
>> elf_info.c: In function ?get_elf64_phnum?:
>> elf_info.c:1050:23: error: ?PN_XNUM? undeclared (first use in this function)
>> if (ehdr->e_phnum == PN_XNUM) {
>> ^
>> elf_info.c:1050:23: note: each undeclared identifier is reported only once for each function it appears in
>> make[1]: *** [Makefile:90: elf_info.o] Error 1
>>
>> PN_XNUM is defined in libelf/elf.h in the elfutils code base, but it
>> seems like this header file is only installed if elfutils is built with
>> --enable-install-elfh. However, I am not sure what would be the impact
>> of installing elf.h. Indeed, the kernel headers also have an elf.h file
>> in usr/include/linux/elf.h.
>>
>> Could you have a look into this ?
>
> Hmm, i checked the usr/include/linux/elf.h and it defines
> PN_XNUM but makedumpfile doesn't include this one and takes the one from
> glibc which is much bigger but doesn't contain this define,
> unfortunately. One option would be to patch makedumpfile and define
> PN_XNUM if it not yet defined, not sure whether this the way you want to
> go ? At least we wouldn't possibly break any other packages. What do you
> think ?
> This is just stupid, why would elfutils override glibc's elf.h, sigh.
>
> Thanks for feedback
> Regards
> Alex
I checked glibc and it defines the PN_XNUM constant, it seems that
uClibc doesn't. Another possible solution would be to make makedumpfile
depend on glibc, what do you think ? That would mean no uClibc support
for this package.
Regards
Alex
next prev parent reply other threads:[~2020-09-05 16:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 11:12 [Buildroot] [PATCH v3 1/1] package/makedumpfile: new package Alexander Egorenkov
2020-09-03 21:26 ` Thomas Petazzoni
2020-09-05 15:35 ` Alexander Egorenkov
2020-09-05 16:03 ` Alexander Egorenkov [this message]
2020-09-05 19:22 ` Thomas Petazzoni
2020-09-05 19:41 ` Alexander Egorenkov
2020-09-05 16:17 ` Alexander Egorenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9gsus6t.fsf@posteo.net \
--to=egorenar-dev@posteo.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox