From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pax-utils: needs wchar
Date: Sat, 31 Oct 2020 21:42:11 +0100 [thread overview]
Message-ID: <20201031214211.69a71de5@windsurf> (raw)
In-Reply-To: <20201031150836.100678-1-fontaine.fabrice@gmail.com>
On Sat, 31 Oct 2020 16:08:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> pax-utils uses asprintf and so needs wchar since version 1.2.4 and
> https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=9c0ec154d782795daa3b7d2ae273bbda2b36ae83
In fact, it seems like the build problem comes from gnulib, which is
bundled in pax-utils. Usage of wctomb() was recently added in gnulib as
of commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c. And it seems like
there is code to not use wctomb() when wchar support is not available,
but that logic doesn't seem to work.
I don't really care about pax-utils being not available with wchar
disabled, but since gnulib is also used in lots of other projects, I'm
fearing that we might see this issue elsewhere.
Could you check if the pax-utils copy of gnulib lib/vasnprintf.c
includes commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c and report a
bug to upstream gnulib ?
In the mean time, I have applied your patch, with an extended commit
log.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-10-31 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 15:08 [Buildroot] [PATCH 1/1] package/pax-utils: needs wchar Fabrice Fontaine
2020-10-31 20:42 ` Thomas Petazzoni [this message]
2020-10-31 20:52 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031214211.69a71de5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox