[Buildroot] [PATCH 1/1] package/pax-utils: needs wchar

[Buildroot] [PATCH 1/1] package/pax-utils: needs wchar

[Fabrice Fontaine]

pax-utils uses asprintf and so needs wchar since version 1.2.4 and
https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=9c0ec154d782795daa3b7d2ae273bbda2b36ae83

Fixes:
 - http://autobuild.buildroot.org/results/613840edba8ea161bb900f3b56d8d3605961c78f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pax-utils/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/pax-utils/Config.in b/package/pax-utils/Config.in
index 58100e482a..ebcca98500 100644
--- a/package/pax-utils/Config.in
+++ b/package/pax-utils/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_PAX_UTILS
 	bool "pax-utils"
+	depends on BR2_USE_WCHAR
 	help
 	  ELF related utils for ELF 32/64 binaries that can check files
 	  for security relevant properties.
 
 	  http://www.gentoo.org/proj/en/hardened/pax-utils.xml
+
+comment "pax-utils needs a toolchain w/ wchar"
+	depends on !BR2_USE_WCHAR
-- 
2.28.0

[Buildroot] [PATCH 1/1] package/pax-utils: needs wchar

[Thomas Petazzoni]

On Sat, 31 Oct 2020 16:08:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> pax-utils uses asprintf and so needs wchar since version 1.2.4 and
> https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=9c0ec154d782795daa3b7d2ae273bbda2b36ae83

In fact, it seems like the build problem comes from gnulib, which is
bundled in pax-utils. Usage of wctomb() was recently added in gnulib as
of commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c. And it seems like
there is code to not use wctomb() when wchar support is not available,
but that logic doesn't seem to work.

I don't really care about pax-utils being not available with wchar
disabled, but since gnulib is also used in lots of other projects, I'm
fearing that we might see this issue elsewhere.

Could you check if the pax-utils copy of gnulib lib/vasnprintf.c
includes commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c and report a
bug to upstream gnulib ?

In the mean time, I have applied your patch, with an extended commit
log.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/pax-utils: needs wchar

[Fabrice Fontaine]

Hi Thomas,

Le sam. 31 oct. 2020 ? 21:42, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Sat, 31 Oct 2020 16:08:36 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > pax-utils uses asprintf and so needs wchar since version 1.2.4 and
> > https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=9c0ec154d782795daa3b7d2ae273bbda2b36ae83
>
> In fact, it seems like the build problem comes from gnulib, which is
> bundled in pax-utils. Usage of wctomb() was recently added in gnulib as
> of commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c. And it seems like
> there is code to not use wctomb() when wchar support is not available,
> but that logic doesn't seem to work.
>
> I don't really care about pax-utils being not available with wchar
> disabled, but since gnulib is also used in lots of other projects, I'm
> fearing that we might see this issue elsewhere.
>
> Could you check if the pax-utils copy of gnulib lib/vasnprintf.c
> includes commit 5cdec0ff5ecf34474d90d8b57f50a148449cda0c and report a
> bug to upstream gnulib ?
pax-utils copy of gnulib does not include commit
5cdec0ff5ecf34474d90d8b57f50a148449cda0c (there is no
ENABLE_WCHAR_FALLBACK or wctomb_fallback).
So we should be able to drop wchar dependency as soon as pax-utils
refresh gnulib.
>
> In the mean time, I have applied your patch, with an extended commit
> log.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice