* [Buildroot] [PATCH v2 2/7] package/network-manager: add optional iwd support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 3/7] package/network-manager: add optional libaudit support James Hilliard
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index ea47e0797e..5d836d0bbc 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -42,6 +42,13 @@ else
NETWORK_MANAGER_CONF_OPTS += --without-ofono
endif
+ifeq ($(BR2_PACKAGE_IWD),y)
+NETWORK_MANAGER_DEPENDENCIES += iwd
+NETWORK_MANAGER_CONF_OPTS += --with-iwd=yes
+else
+NETWORK_MANAGER_CONF_OPTS += --with-iwd=no
+endif
+
ifeq ($(BR2_PACKAGE_LIBCURL),y)
NETWORK_MANAGER_DEPENDENCIES += libcurl
NETWORK_MANAGER_CONF_OPTS += --enable-concheck
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 3/7] package/network-manager: add optional libaudit support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 2/7] package/network-manager: add optional iwd support James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 4/7] package/network-manager: add optional libpsl support James Hilliard
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 5d836d0bbc..c07be6d19d 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -49,6 +49,13 @@ else
NETWORK_MANAGER_CONF_OPTS += --with-iwd=no
endif
+ifeq ($(BR2_PACKAGE_AUDIT),y)
+NETWORK_MANAGER_DEPENDENCIES += audit
+NETWORK_MANAGER_CONF_OPTS += --with-libaudit=yes
+else
+NETWORK_MANAGER_CONF_OPTS += --with-libaudit=no
+endif
+
ifeq ($(BR2_PACKAGE_LIBCURL),y)
NETWORK_MANAGER_DEPENDENCIES += libcurl
NETWORK_MANAGER_CONF_OPTS += --enable-concheck
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 4/7] package/network-manager: add optional libpsl support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 2/7] package/network-manager: add optional iwd support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 3/7] package/network-manager: add optional libaudit support James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 5/7] package/network-manager: add optional selinux support James Hilliard
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index c07be6d19d..25dcb563c1 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -63,6 +63,13 @@ else
NETWORK_MANAGER_CONF_OPTS += --disable-concheck
endif
+ifeq ($(BR2_PACKAGE_LIBPSL),y)
+NETWORK_MANAGER_DEPENDENCIES += libpsl
+NETWORK_MANAGER_CONF_OPTS += --with-libpsl=yes
+else
+NETWORK_MANAGER_CONF_OPTS += --with-libpsl=no
+endif
+
ifeq ($(BR2_PACKAGE_READLINE),y)
NETWORK_MANAGER_DEPENDENCIES += readline
NETWORK_MANAGER_CONF_OPTS += --with-nmcli=yes
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 5/7] package/network-manager: add optional selinux support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
` (2 preceding siblings ...)
2021-12-05 0:54 ` [Buildroot] [PATCH v2 4/7] package/network-manager: add optional libpsl support James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 6/7] package/network-manager: add optional polkit support James Hilliard
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 25dcb563c1..4ed66c2f9d 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -70,6 +70,13 @@ else
NETWORK_MANAGER_CONF_OPTS += --with-libpsl=no
endif
+ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
+NETWORK_MANAGER_DEPENDENCIES += libselinux
+NETWORK_MANAGER_CONF_OPTS += --with-selinux=yes
+else
+NETWORK_MANAGER_CONF_OPTS += --with-selinux=no
+endif
+
ifeq ($(BR2_PACKAGE_READLINE),y)
NETWORK_MANAGER_DEPENDENCIES += readline
NETWORK_MANAGER_CONF_OPTS += --with-nmcli=yes
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 6/7] package/network-manager: add optional polkit support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
` (3 preceding siblings ...)
2021-12-05 0:54 ` [Buildroot] [PATCH v2 5/7] package/network-manager: add optional selinux support James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support James Hilliard
2021-12-05 10:08 ` [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 Thomas Petazzoni
6 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 4ed66c2f9d..14bf0d4dd1 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -105,6 +105,13 @@ else
NETWORK_MANAGER_CONF_OPTS += --without-modem-manager-1
endif
+ifeq ($(BR2_PACKAGE_POLKIT),y)
+NETWORK_MANAGER_DEPENDENCIES += polkit
+NETWORK_MANAGER_CONF_OPTS += --enable-polkit=yes
+else
+NETWORK_MANAGER_CONF_OPTS += --enable-polkit=no
+endif
+
ifeq ($(BR2_PACKAGE_DHCP_CLIENT),y)
NETWORK_MANAGER_CONF_OPTS += --with-dhclient=/sbin/dhclient
endif
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
` (4 preceding siblings ...)
2021-12-05 0:54 ` [Buildroot] [PATCH v2 6/7] package/network-manager: add optional polkit support James Hilliard
@ 2021-12-05 0:54 ` James Hilliard
2021-12-05 10:09 ` Thomas Petazzoni
2021-12-05 10:08 ` [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 Thomas Petazzoni
6 siblings, 1 reply; 10+ messages in thread
From: James Hilliard @ 2021-12-05 0:54 UTC (permalink / raw)
To: buildroot; +Cc: James Hilliard
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/network-manager/network-manager.mk | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 14bf0d4dd1..7a268d72c8 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -112,6 +112,21 @@ else
NETWORK_MANAGER_CONF_OPTS += --enable-polkit=no
endif
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+NETWORK_MANAGER_DEPENDENCIES += systemd
+NETWORK_MANAGER_CONF_OPTS += \
+ --with-systemd-journal=yes \
+ --with-config-logging-backend-default=journal \
+ --with-session-tracking=systemd \
+ --with-suspend-resume=systemd
+else
+NETWORK_MANAGER_CONF_OPTS += \
+ --with-systemd-journal=no \
+ --with-config-logging-backend-default=syslog \
+ --with-session-tracking=no \
+ --with-suspend-resume=upower
+endif
+
ifeq ($(BR2_PACKAGE_DHCP_CLIENT),y)
NETWORK_MANAGER_CONF_OPTS += --with-dhclient=/sbin/dhclient
endif
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support
2021-12-05 0:54 ` [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support James Hilliard
@ 2021-12-05 10:09 ` Thomas Petazzoni
2021-12-05 11:14 ` James Hilliard
0 siblings, 1 reply; 10+ messages in thread
From: Thomas Petazzoni @ 2021-12-05 10:09 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
Hello James,
On Sat, 4 Dec 2021 17:54:12 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/network-manager/network-manager.mk | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index 14bf0d4dd1..7a268d72c8 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -112,6 +112,21 @@ else
> NETWORK_MANAGER_CONF_OPTS += --enable-polkit=no
> endif
>
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +NETWORK_MANAGER_DEPENDENCIES += systemd
> +NETWORK_MANAGER_CONF_OPTS += \
> + --with-systemd-journal=yes \
=yes not needed
> + --with-config-logging-backend-default=journal \
> + --with-session-tracking=systemd \
> + --with-suspend-resume=systemd
> +else
> +NETWORK_MANAGER_CONF_OPTS += \
> + --with-systemd-journal=no \
--without-systemd-journal
> + --with-config-logging-backend-default=syslog \
> + --with-session-tracking=no \
--without-session-tracking
> + --with-suspend-resume=upower
Are you sure about this? We don't forcefully enable upower when systemd
is disabled, so is this working?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support
2021-12-05 10:09 ` Thomas Petazzoni
@ 2021-12-05 11:14 ` James Hilliard
0 siblings, 0 replies; 10+ messages in thread
From: James Hilliard @ 2021-12-05 11:14 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
On Sun, Dec 5, 2021 at 3:09 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello James,
>
> On Sat, 4 Dec 2021 17:54:12 -0700
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/network-manager/network-manager.mk | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> > index 14bf0d4dd1..7a268d72c8 100644
> > --- a/package/network-manager/network-manager.mk
> > +++ b/package/network-manager/network-manager.mk
> > @@ -112,6 +112,21 @@ else
> > NETWORK_MANAGER_CONF_OPTS += --enable-polkit=no
> > endif
> >
> > +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> > +NETWORK_MANAGER_DEPENDENCIES += systemd
> > +NETWORK_MANAGER_CONF_OPTS += \
> > + --with-systemd-journal=yes \
>
> =yes not needed
>
> > + --with-config-logging-backend-default=journal \
> > + --with-session-tracking=systemd \
> > + --with-suspend-resume=systemd
> > +else
> > +NETWORK_MANAGER_CONF_OPTS += \
> > + --with-systemd-journal=no \
>
> --without-systemd-journal
>
> > + --with-config-logging-backend-default=syslog \
> > + --with-session-tracking=no \
>
> --without-session-tracking
>
> > + --with-suspend-resume=upower
>
> Are you sure about this? We don't forcefully enable upower when systemd
> is disabled, so is this working?
Should be the default for non-systemd installs:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.32.12/configure.ac#L494-495
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
` (5 preceding siblings ...)
2021-12-05 0:54 ` [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support James Hilliard
@ 2021-12-05 10:08 ` Thomas Petazzoni
6 siblings, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2021-12-05 10:08 UTC (permalink / raw)
To: James Hilliard; +Cc: buildroot
On Sat, 4 Dec 2021 17:54:06 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/network-manager/network-manager.hash | 4 ++--
> package/network-manager/network-manager.mk | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Thanks! I've applied the entire series except the last patch to next,
after changing the --with-XYZ=yes/--with-XYZ=no to
--with-XYZ/--without-XYZ, which we normally use in Buildroot for
autotools based packages.
Because this was not consistent in network-manager.mk, I also did a
follow-up commit that fixes up the options that were not consistent
with this rule. And also, I've added a commit that orders the
conditional blocks alphabetically.
Make sure to rebase on the latest next branch before sending further
updates on network-manager.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 10+ messages in thread