Re: [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Mon, 24 Jan 2022 19:44:29 +0200
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:

> > Is there a reason behind this?  
> 
> As I understand that's because libiberty is static only. Buildroot does
> not copy static libraries to $(TARGET_DIR) because they are only used at
> build time, but not at run-time.

True, but it doesn't make sense to do that in
BINUTILS_INSTALL_TARGET_CMDS. It should go in
BINUTILS_INSTALL_STAGING_CMDS, where it is already present, as Romain
pointed out.

So basically:

        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install

needs to be dropped from BINUTILS_INSTALL_TARGET_CMDS, if indeed
libiberty is only installed as a static library.

However, taking a step back:

# We just want libbfd, libiberty and libopcodes,
# not the full-blown binutils in staging
define BINUTILS_INSTALL_STAGING_CMDS
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
endef

# If we don't want full binutils on target
ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
define BINUTILS_INSTALL_TARGET_CMDS
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
        $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
endef
endif

This is *extremely* suspicious. Indeed, we get the libraries
unconditionally installed in staging, so any other library or program
that we build after binutils can potentially link against thosze
libraries.

But we only install them conditionally in $(TARGET_DIR) if
BR2_PACKAGE_BINUTILS_TARGET=y.

This seems very bad to me. Both target and staging installations should
be done under the same condition.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot