From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Jonathan Borne <jborne@kalray.eu>
Cc: ysionneaux@kalray.eu, jmaselbas@kalray.eu,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
Baruch Siach via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory
Date: Wed, 26 Jan 2022 16:52:49 +0100 [thread overview]
Message-ID: <20220126165249.0445bdc9@windsurf> (raw)
In-Reply-To: <608336144.1670038.1643211044586.JavaMail.zimbra@kalray.eu>
On Wed, 26 Jan 2022 16:30:44 +0100 (CET)
Jonathan Borne <jborne@kalray.eu> wrote:
> Double negation is a bit confusing indeed,
> maybe the message could be changed to
>
> # If we don't want full binutils on target
> ifeq ($(BR2_PACKAGE_BINUTILS_TARGET),n)
This is never going to be true, as disabled options have an empty
value. To work, it should be:
ifeq ($(BR2_PACKAGE_BINUTILS_TARGET),)
> Agreed! So if I understand correctly, as was suggested by Romain and Thomas,
> we could indeed get rid of
>
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
>
> in BINUTILS_INSTALL_TARGET_CMDS.
Yes!
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-01-26 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 17:35 [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory Jonathan Borne via buildroot
2022-01-24 17:35 ` [Buildroot] [RFC PATCH 1/1] " Jonathan Borne via buildroot
2022-01-24 17:44 ` [Buildroot] [RFC PATCH 0/1] " Baruch Siach via buildroot
2022-01-24 18:12 ` Romain Naour
2022-01-24 21:02 ` Thomas Petazzoni
2022-01-24 21:21 ` Yann E. MORIN
2022-01-24 21:53 ` Thomas Petazzoni
2022-01-26 15:30 ` Jonathan Borne via buildroot
2022-01-26 15:52 ` Thomas Petazzoni [this message]
2022-01-26 17:14 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126165249.0445bdc9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=jborne@kalray.eu \
--cc=jmaselbas@kalray.eu \
--cc=yann.morin.1998@free.fr \
--cc=ysionneaux@kalray.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox