Re: [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Jonathan Borne <jborne@kalray.eu>,
	jmaselbas@kalray.eu, ysionneaux@kalray.eu,
	Baruch Siach via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [RFC PATCH 0/1] Fix binutils/libiberty target install directory
Date: Mon, 24 Jan 2022 22:53:56 +0100	[thread overview]
Message-ID: <20220124225356.03c1c658@windsurf> (raw)
In-Reply-To: <20220124212149.GJ2502@scaer>

On Mon, 24 Jan 2022 22:21:49 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > # We just want libbfd, libiberty and libopcodes,
> > # not the full-blown binutils in staging
> > define BINUTILS_INSTALL_STAGING_CMDS
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(STAGING_DIR) install
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(STAGING_DIR) install
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
> > endef
> > 
> > # If we don't want full binutils on target
> > ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)
> > define BINUTILS_INSTALL_TARGET_CMDS
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/bfd DESTDIR=$(TARGET_DIR) install
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/opcodes DESTDIR=$(TARGET_DIR) install
> >         $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)/libiberty DESTDIR=$(STAGING_DIR) install
> > endef
> > endif
> > 
> > This is *extremely* suspicious. Indeed, we get the libraries
> > unconditionally installed in staging, so any other library or program
> > that we build after binutils can potentially link against thosze
> > libraries.
> > 
> > But we only install them conditionally in $(TARGET_DIR) if
> > BR2_PACKAGE_BINUTILS_TARGET=y.
> > 
> > This seems very bad to me. Both target and staging installations should
> > be done under the same condition.  
> 
> Not really. You missed the fact that binutils is an autotools package.
> 
> As such, when BR2_PACKAGE_BINUTILS_TARGET=n, then the full binutils are
> instaleld in target, so the libs will be installed in target.

Aah, indeed, the condition is:

ifneq ($(BR2_PACKAGE_BINUTILS_TARGET),y)

> So whatever gets in staging is present in target, but target can be a
> superset of what is in staging, so whatever links to a binutils lib from
> staging will find it in target.

Correct!

Thanks for pointing me at my own mistake :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot