Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Clément Léger" <clement.leger@bootlin.com>
Cc: Etienne Carriere <etienne.carriere@linaro.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 1/8] package/pkg-generic: host variant inherits target download settings
Date: Fri, 18 Mar 2022 23:33:15 +0100	[thread overview]
Message-ID: <20220318223315.GU283544@scaer> (raw)
In-Reply-To: <20220318132427.48737-2-clement.leger@bootlin.com>

Clément, All,

On 2022-03-18 14:24 +0100, Clément Léger spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> It seems reasonable to expect that the download of the host and target
> variants should usually be exactly the same and thus reuse the target
> package values for the host package. This commits add support to
> inherit host _DL_SUBDIR, _DOWNLOAD_DEPENDENCIES, _DL_ENV and
> _DOwNLOAD_POST_PROCESS variables from target ones. These variables can
> still be overriden if necessary for the host package.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>

As Thomas also hinted he agreed on the principle: applied to master,
thanks.

Regards,
Yann E. MORIN.

> ---
>  package/pkg-generic.mk | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index b3a7e1d60e..79fcf603d3 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -540,6 +540,30 @@ ifndef $(2)_SUBDIR
>   endif
>  endif
>  
> +ifndef $(2)_DL_SUBDIR
> + ifdef $(3)_DL_SUBDIR
> +  $(2)_DL_SUBDIR = $$($(3)_DL_SUBDIR)
> + endif
> +endif
> +
> +ifndef $(2)_DOWNLOAD_DEPENDENCIES
> + ifdef $(3)_DOWNLOAD_DEPENDENCIES
> +  $(2)_DOWNLOAD_DEPENDENCIES = $$(filter-out $(1),$$($(3)_DOWNLOAD_DEPENDENCIES))
> + endif
> +endif
> +
> +ifndef $(2)_DL_ENV
> + ifdef $(3)_DL_ENV
> +  $(2)_DL_ENV = $$($(3)_DL_ENV)
> + endif
> +endif
> +
> +ifndef $(2)_DOWNLOAD_POST_PROCESS
> + ifdef $(3)_DOWNLOAD_POST_PROCESS
> +  $(2)_DOWNLOAD_POST_PROCESS = $$($(3)_DOWNLOAD_POST_PROCESS)
> + endif
> +endif
> +
>  ifndef $(2)_STRIP_COMPONENTS
>   ifdef $(3)_STRIP_COMPONENTS
>    $(2)_STRIP_COMPONENTS = $$($(3)_STRIP_COMPONENTS)
> -- 
> 2.34.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-03-18 22:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 13:24 [Buildroot] [PATCH v5 0/8] boot/optee-os: support new optee-os 3.16.0 build dependencies Clément Léger via buildroot
2022-03-18 13:24 ` [Buildroot] [PATCH v5 1/8] package/pkg-generic: host variant inherits target download settings Clément Léger via buildroot
2022-03-18 22:33   ` Yann E. MORIN [this message]
2022-03-18 13:24 ` [Buildroot] [PATCH v5 2/8] package/python-cryptography: enable host package Clément Léger via buildroot
2022-03-18 22:32   ` Yann E. MORIN
2022-03-18 13:24 ` [Buildroot] [PATCH v5 3/8] boot/optee-os: add support to build with python-cryptography Clément Léger via buildroot
2022-03-18 22:32   ` Yann E. MORIN
2022-03-19  9:17     ` Thomas Petazzoni via buildroot
2022-03-19  9:46       ` Yann E. MORIN
2022-03-18 13:24 ` [Buildroot] [PATCH v5 4/8] boot/optee-os: bump to version 3.16.0 Clément Léger via buildroot
2022-03-18 22:40   ` Yann E. MORIN
2022-03-21  7:46     ` Clément Léger via buildroot
2022-03-18 13:24 ` [Buildroot] [PATCH v5 5/8] package/optee-test: " Clément Léger via buildroot
2022-03-18 13:24 ` [Buildroot] [PATCH v5 6/8] package/optee-examples: " Clément Léger via buildroot
2022-03-18 13:24 ` [Buildroot] [PATCH v5 7/8] package/optee-client: " Clément Léger via buildroot
2022-03-18 13:24 ` [Buildroot] [PATCH v5 8/8] package/optee-benchmark: " Clément Léger via buildroot
2022-03-18 22:46 ` [Buildroot] [PATCH v5 0/8] boot/optee-os: support new optee-os 3.16.0 build dependencies Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220318223315.GU283544@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=clement.leger@bootlin.com \
    --cc=etienne.carriere@linaro.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox