Re: [Buildroot] [PATCH v5 3/8] boot/optee-os: add support to build with python-cryptography

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Etienne Carriere" <etienne.carriere@linaro.org>,
	"Clément Léger" <clement.leger@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 3/8] boot/optee-os: add support to build with python-cryptography
Date: Sat, 19 Mar 2022 10:46:51 +0100	[thread overview]
Message-ID: <20220319094651.GA1566358@scaer> (raw)
In-Reply-To: <20220319101749.265ebceb@windsurf>

Thomas, All,

On 2022-03-19 10:17 +0100, Thomas Petazzoni spake thusly:
> On Fri, 18 Mar 2022 23:32:21 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> 
> > > diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> > > index ea16550b72..02b5d7c86f 100644
> > > --- a/boot/optee-os/Config.in
> > > +++ b/boot/optee-os/Config.in
> > > @@ -1,6 +1,7 @@
> > >  config BR2_TARGET_OPTEE_OS
> > >  	bool "optee_os"
> > >  	depends on BR2_ARM_CPU_ARMV8A || BR2_ARM_CPU_ARMV7A
> > > +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS  
> > 
> > That's wrong: 3.15.0 still does not need host-python-cryptography.
> > 
> > Furthermore, even after we bump to 3.16.0, since we can choose an
> > arbitrary git tree at an arbitrary commit, it is still possible to
> > point to a version of optee-os that does not require it either.
> > 
> > So, that dependency only really belongs...
> > 
> > >  	help
> > >  	  OP-TEE OS provides the secure world boot image and the trust
> > >  	  application development kit of the OP-TEE project. OP-TEE OS
> > > @@ -61,6 +62,14 @@ config BR2_TARGET_OPTEE_OS_NEEDS_DTC
> > >  	  Select this option if your OP-TEE OS platform configuration
> > >  	  requires the Device Tree compiler to be available.
> > >  
> > > +config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
> > > +	bool "OP-TEE OS needs host-python-cryptography"  
> > 
> > ... here.
> 
> Yes and no. Because as soon as the BR2_TARGET_OPTEE_OS_LATEST gets
> bumped to 3.16.0, then our default selection for OP-TEE (unless you
> chose a custom Git version) will require python-cryptography. So to
> keep things simple, I asked Clément to add this dependency to the
> whole package.

But that's the point: you can still choose a custom git tree that points
to an earlier, pre-3.16.0 tree, which will still be buildable without
pytho-cryptography.

But yes, you got a point: I forgot to guard the default clause in the
choice, with the same dependency. I'll submit a patch.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot