Re: [Buildroot] [PATCH v5 3/8] boot/optee-os: add support to build with python-cryptography

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 18 Mar 2022 23:32:21 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > diff --git a/boot/optee-os/Config.in b/boot/optee-os/Config.in
> > index ea16550b72..02b5d7c86f 100644
> > --- a/boot/optee-os/Config.in
> > +++ b/boot/optee-os/Config.in
> > @@ -1,6 +1,7 @@
> >  config BR2_TARGET_OPTEE_OS
> >  	bool "optee_os"
> >  	depends on BR2_ARM_CPU_ARMV8A || BR2_ARM_CPU_ARMV7A
> > +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS  
> 
> That's wrong: 3.15.0 still does not need host-python-cryptography.
> 
> Furthermore, even after we bump to 3.16.0, since we can choose an
> arbitrary git tree at an arbitrary commit, it is still possible to
> point to a version of optee-os that does not require it either.
> 
> So, that dependency only really belongs...
> 
> >  	help
> >  	  OP-TEE OS provides the secure world boot image and the trust
> >  	  application development kit of the OP-TEE project. OP-TEE OS
> > @@ -61,6 +62,14 @@ config BR2_TARGET_OPTEE_OS_NEEDS_DTC
> >  	  Select this option if your OP-TEE OS platform configuration
> >  	  requires the Device Tree compiler to be available.
> >  
> > +config BR2_TARGET_OPTEE_OS_NEEDS_PYTHON_CRYPTOGRAPHY
> > +	bool "OP-TEE OS needs host-python-cryptography"  
> 
> ... here.

Yes and no. Because as soon as the BR2_TARGET_OPTEE_OS_LATEST gets
bumped to 3.16.0, then our default selection for OP-TEE (unless you
chose a custom Git version) will require python-cryptography. So to
keep things simple, I asked Clément to add this dependency to the
whole package.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot