* [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS @ 2022-04-27 13:14 Noah Huetter 2022-04-27 22:55 ` Alistair Francis 2022-07-26 22:15 ` Thomas Petazzoni via buildroot 0 siblings, 2 replies; 7+ messages in thread From: Noah Huetter @ 2022-04-27 13:14 UTC (permalink / raw) To: buildroot; +Cc: Alistair Francis, Noah Huetter Signed-off-by: Noah Huetter <noahhuetter@gmail.com> --- boot/opensbi/Config.in | 6 ++++++ boot/opensbi/opensbi.mk | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in index f1443498d9..ff095ea800 100644 --- a/boot/opensbi/Config.in +++ b/boot/opensbi/Config.in @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH must be set in the U-Boot configuration for this file to be produced. +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS + string "Custom make options" + help + List of custom make options passed at build time. Can be + used for example to pass a BUILD_INFO= value. + endif diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk index 8e055633a8..d007ae1299 100644 --- a/boot/opensbi/opensbi.mk +++ b/boot/opensbi/opensbi.mk @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) endif OPENSBI_MAKE_ENV = \ - CROSS_COMPILE=$(TARGET_CROSS) + CROSS_COMPILE=$(TARGET_CROSS) \ + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) ifneq ($(OPENSBI_PLAT),) -- 2.35.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-04-27 13:14 [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS Noah Huetter @ 2022-04-27 22:55 ` Alistair Francis 2022-05-12 6:50 ` Noah Hütter 2022-07-26 22:15 ` Thomas Petazzoni via buildroot 1 sibling, 1 reply; 7+ messages in thread From: Alistair Francis @ 2022-04-27 22:55 UTC (permalink / raw) To: Noah Huetter; +Cc: Alistair Francis, buildroot On Wed, Apr 27, 2022 at 11:14 PM Noah Huetter <noahhuetter@gmail.com> wrote: > > Signed-off-by: Noah Huetter <noahhuetter@gmail.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > boot/opensbi/Config.in | 6 ++++++ > boot/opensbi/opensbi.mk | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in > index f1443498d9..ff095ea800 100644 > --- a/boot/opensbi/Config.in > +++ b/boot/opensbi/Config.in > @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH > must be set in the U-Boot configuration for this file to be > produced. > > +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS > + string "Custom make options" > + help > + List of custom make options passed at build time. Can be > + used for example to pass a BUILD_INFO= value. > + > endif > diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk > index 8e055633a8..d007ae1299 100644 > --- a/boot/opensbi/opensbi.mk > +++ b/boot/opensbi/opensbi.mk > @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) > endif > > OPENSBI_MAKE_ENV = \ > - CROSS_COMPILE=$(TARGET_CROSS) > + CROSS_COMPILE=$(TARGET_CROSS) \ > + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) > > OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) > ifneq ($(OPENSBI_PLAT),) > -- > 2.35.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-04-27 22:55 ` Alistair Francis @ 2022-05-12 6:50 ` Noah Hütter 2022-05-12 21:57 ` Arnout Vandecappelle 0 siblings, 1 reply; 7+ messages in thread From: Noah Hütter @ 2022-05-12 6:50 UTC (permalink / raw) To: Alistair Francis; +Cc: Alistair Francis, buildroot [-- Attachment #1.1.1: Type: text/plain, Size: 1922 bytes --] Hi Alistair, Is there any action needed from my side to get this committed? Noah On 4/28/22 00:55, Alistair Francis wrote: > On Wed, Apr 27, 2022 at 11:14 PM Noah Huetter <noahhuetter@gmail.com> wrote: >> >> Signed-off-by: Noah Huetter <noahhuetter@gmail.com> > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > Alistair > >> --- >> boot/opensbi/Config.in | 6 ++++++ >> boot/opensbi/opensbi.mk | 3 ++- >> 2 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in >> index f1443498d9..ff095ea800 100644 >> --- a/boot/opensbi/Config.in >> +++ b/boot/opensbi/Config.in >> @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH >> must be set in the U-Boot configuration for this file to be >> produced. >> >> +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS >> + string "Custom make options" >> + help >> + List of custom make options passed at build time. Can be >> + used for example to pass a BUILD_INFO= value. >> + >> endif >> diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk >> index 8e055633a8..d007ae1299 100644 >> --- a/boot/opensbi/opensbi.mk >> +++ b/boot/opensbi/opensbi.mk >> @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) >> endif >> >> OPENSBI_MAKE_ENV = \ >> - CROSS_COMPILE=$(TARGET_CROSS) >> + CROSS_COMPILE=$(TARGET_CROSS) \ >> + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) >> >> OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) >> ifneq ($(OPENSBI_PLAT),) >> -- >> 2.35.1 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot -- Noah Huetter https://beeblebrox.ch/ Fingerprint: A251 8391 5989 094E 0747 6B68 362A 1C58 456D DA0F [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-05-12 6:50 ` Noah Hütter @ 2022-05-12 21:57 ` Arnout Vandecappelle 2022-05-13 9:42 ` Noah Hütter 0 siblings, 1 reply; 7+ messages in thread From: Arnout Vandecappelle @ 2022-05-12 21:57 UTC (permalink / raw) To: Noah Hütter, Alistair Francis; +Cc: Alistair Francis, buildroot On 12/05/2022 08:50, Noah Hütter wrote: > Hi Alistair, > > Is there any action needed from my side to get this committed? It's just one of the +-200 pending patches that are not trivial. > > Noah > > On 4/28/22 00:55, Alistair Francis wrote: >> On Wed, Apr 27, 2022 at 11:14 PM Noah Huetter <noahhuetter@gmail.com> wrote: >>> >>> Signed-off-by: Noah Huetter <noahhuetter@gmail.com> >> >> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> >> >> Alistair >> >>> --- >>> boot/opensbi/Config.in | 6 ++++++ >>> boot/opensbi/opensbi.mk | 3 ++- >>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in >>> index f1443498d9..ff095ea800 100644 >>> --- a/boot/opensbi/Config.in >>> +++ b/boot/opensbi/Config.in >>> @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH >>> must be set in the U-Boot configuration for this file to be >>> produced. >>> >>> +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS >>> + string "Custom make options" >>> + help >>> + List of custom make options passed at build time. Can be >>> + used for example to pass a BUILD_INFO= value. In this case, it's not trivial because the use case is not clear. Almost every package has some random make, cmake, meson or whatever options that you could pass to it. What makes OpenSBI so special that you need to pass a freeform list of additional options? Regards, Arnout >>> + >>> endif >>> diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk >>> index 8e055633a8..d007ae1299 100644 >>> --- a/boot/opensbi/opensbi.mk >>> +++ b/boot/opensbi/opensbi.mk >>> @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) >>> endif >>> >>> OPENSBI_MAKE_ENV = \ >>> - CROSS_COMPILE=$(TARGET_CROSS) >>> + CROSS_COMPILE=$(TARGET_CROSS) \ >>> + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) >>> >>> OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) >>> ifneq ($(OPENSBI_PLAT),) >>> -- >>> 2.35.1 >>> >>> _______________________________________________ >>> buildroot mailing list >>> buildroot@buildroot.org >>> https://lists.buildroot.org/mailman/listinfo/buildroot > > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-05-12 21:57 ` Arnout Vandecappelle @ 2022-05-13 9:42 ` Noah Hütter 2022-05-13 20:05 ` Arnout Vandecappelle 0 siblings, 1 reply; 7+ messages in thread From: Noah Hütter @ 2022-05-13 9:42 UTC (permalink / raw) To: Arnout Vandecappelle, Alistair Francis; +Cc: Alistair Francis, buildroot [-- Attachment #1.1.1: Type: text/plain, Size: 3022 bytes --] On 5/12/22 23:57, Arnout Vandecappelle wrote: > > > On 12/05/2022 08:50, Noah Hütter wrote: >> Hi Alistair, >> >> Is there any action needed from my side to get this committed? > > It's just one of the +-200 pending patches that are not trivial. Thanks for the update, I didn't want to put pressure on anyone, I'm a first time contributor and want to make no mistakes :). >> >> Noah >> >> On 4/28/22 00:55, Alistair Francis wrote: >>> On Wed, Apr 27, 2022 at 11:14 PM Noah Huetter <noahhuetter@gmail.com> >>> wrote: >>>> >>>> Signed-off-by: Noah Huetter <noahhuetter@gmail.com> >>> >>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> >>> >>> Alistair >>> >>>> --- >>>> boot/opensbi/Config.in | 6 ++++++ >>>> boot/opensbi/opensbi.mk | 3 ++- >>>> 2 files changed, 8 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/boot/opensbi/Config.in b/boot/opensbi/Config.in >>>> index f1443498d9..ff095ea800 100644 >>>> --- a/boot/opensbi/Config.in >>>> +++ b/boot/opensbi/Config.in >>>> @@ -119,4 +119,10 @@ config BR2_TARGET_OPENSBI_FW_FDT_PATH >>>> must be set in the U-Boot configuration for this file to be >>>> produced. >>>> >>>> +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS >>>> + string "Custom make options" >>>> + help >>>> + List of custom make options passed at build time. Can be >>>> + used for example to pass a BUILD_INFO= value. > > In this case, it's not trivial because the use case is not clear. > Almost every package has some random make, cmake, meson or whatever > options that you could pass to it. What makes OpenSBI so special that > you need to pass a freeform list of additional options? In my specific case as described in the help, the value to `BUILD_INFO`. From looking at other packages I deduced that the _CUSTOM_MAKEOPTS is a common config to packages and added it to OpenSBI. Did I overlook something? Best, Noah >>>> + >>>> endif >>>> diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk >>>> index 8e055633a8..d007ae1299 100644 >>>> --- a/boot/opensbi/opensbi.mk >>>> +++ b/boot/opensbi/opensbi.mk >>>> @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) >>>> endif >>>> >>>> OPENSBI_MAKE_ENV = \ >>>> - CROSS_COMPILE=$(TARGET_CROSS) >>>> + CROSS_COMPILE=$(TARGET_CROSS) \ >>>> + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) >>>> >>>> OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) >>>> ifneq ($(OPENSBI_PLAT),) >>>> -- >>>> 2.35.1 >>>> >>>> _______________________________________________ >>>> buildroot mailing list >>>> buildroot@buildroot.org >>>> https://lists.buildroot.org/mailman/listinfo/buildroot >> >> >> _______________________________________________ >> buildroot mailing list >> buildroot@buildroot.org >> https://lists.buildroot.org/mailman/listinfo/buildroot [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 495 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-05-13 9:42 ` Noah Hütter @ 2022-05-13 20:05 ` Arnout Vandecappelle 0 siblings, 0 replies; 7+ messages in thread From: Arnout Vandecappelle @ 2022-05-13 20:05 UTC (permalink / raw) To: Noah Hütter, Alistair Francis; +Cc: Alistair Francis, buildroot On 13/05/2022 11:42, Noah Hütter wrote: > > > On 5/12/22 23:57, Arnout Vandecappelle wrote: >> >> >> On 12/05/2022 08:50, Noah Hütter wrote: [snip] >>>>> +config BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS >>>>> + string "Custom make options" >>>>> + help >>>>> + List of custom make options passed at build time. Can be >>>>> + used for example to pass a BUILD_INFO= value. >> >> In this case, it's not trivial because the use case is not clear. Almost >> every package has some random make, cmake, meson or whatever options that you >> could pass to it. What makes OpenSBI so special that you need to pass a >> freeform list of additional options? > > In my specific case as described in the help, the value to `BUILD_INFO`. Yes, but why is it absolutely necessary to set BUILD_INFO? Are there other variables that are going to be need to be set, or is it just the one? In the latter case, it would be better to have BR2_TARGET_OPENSBI_BUILD_INFO. > From > looking at other packages I deduced that the _CUSTOM_MAKEOPTS is a common config > to packages and added it to OpenSBI. Did I overlook something? There's just one that has this, uboot. It was added by this commit: commit cc151c3993090a52d1fef8532f52d74ee6d924c9 Author: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Date: Fri Apr 26 17:19:46 2019 boot/uboot: add option to pass custom variables to U-Boot build U-Boot supports a number of environment variables to pass specific information. The following patches were submitted in the past to one some specific Config.in option to pass some of these variables: - http://patchwork.ozlabs.org/patch/881197/ proposed an option to pass a custom EXT_DTB= variable - http://patchwork.ozlabs.org/patch/1018245/ proposed an option to pass a custom DEVICE_TREE= variable Instead of adding one Config.in option for each of those variables, let's provide a generic mechanism to pass arbitrary variables during U-Boot build step. I have to say that that commit message isn't really good enough either, it should really have copied the explanations in the two referred patches as to why those two variables would need to be used. What we're really looking for is: - A "proof" that this is for a relevant use case and not just some corner case that nobody other than yourself is ever going to need. - A "design document" that this is really the way to implement this feature, that other alternatives are less appropriate (cfr. the "Instead of ... let's ..." sentence above). - And all this documented in the commit message, so a few years down the line if someone changes it, we remember the reasons why we made those choices. Note that it doesn't have to be very wordy, it's possible to cover those bases in just a few words. But the gist of it needs to be there. Regards, Arnout > > Best, > Noah > >>>>> + >>>>> endif >>>>> diff --git a/boot/opensbi/opensbi.mk b/boot/opensbi/opensbi.mk >>>>> index 8e055633a8..d007ae1299 100644 >>>>> --- a/boot/opensbi/opensbi.mk >>>>> +++ b/boot/opensbi/opensbi.mk >>>>> @@ -31,7 +31,8 @@ BR_NO_CHECK_HASH_FOR += $(OPENSBI_SOURCE) >>>>> endif >>>>> >>>>> OPENSBI_MAKE_ENV = \ >>>>> - CROSS_COMPILE=$(TARGET_CROSS) >>>>> + CROSS_COMPILE=$(TARGET_CROSS) \ >>>>> + $(call qstrip,$(BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS)) >>>>> >>>>> OPENSBI_PLAT = $(call qstrip,$(BR2_TARGET_OPENSBI_PLAT)) >>>>> ifneq ($(OPENSBI_PLAT),) >>>>> -- >>>>> 2.35.1 >>>>> >>>>> _______________________________________________ >>>>> buildroot mailing list >>>>> buildroot@buildroot.org >>>>> https://lists.buildroot.org/mailman/listinfo/buildroot >>> >>> >>> _______________________________________________ >>> buildroot mailing list >>> buildroot@buildroot.org >>> https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS 2022-04-27 13:14 [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS Noah Huetter 2022-04-27 22:55 ` Alistair Francis @ 2022-07-26 22:15 ` Thomas Petazzoni via buildroot 1 sibling, 0 replies; 7+ messages in thread From: Thomas Petazzoni via buildroot @ 2022-07-26 22:15 UTC (permalink / raw) To: Noah Huetter; +Cc: Alistair Francis, buildroot On Wed, 27 Apr 2022 15:14:00 +0200 Noah Huetter <noahhuetter@gmail.com> wrote: > Signed-off-by: Noah Huetter <noahhuetter@gmail.com> > --- > boot/opensbi/Config.in | 6 ++++++ > boot/opensbi/opensbi.mk | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) Applied to master after changing the name to BR2_TARGET_OPENSBI_ADDITIONAL_VARIABLES. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-26 22:15 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-04-27 13:14 [Buildroot] [PATCH 1/1] boot/opensbi: introduce BR2_TARGET_OPENSBI_CUSTOM_MAKEOPTS Noah Huetter 2022-04-27 22:55 ` Alistair Francis 2022-05-12 6:50 ` Noah Hütter 2022-05-12 21:57 ` Arnout Vandecappelle 2022-05-13 9:42 ` Noah Hütter 2022-05-13 20:05 ` Arnout Vandecappelle 2022-07-26 22:15 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox