Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Samuel Martin <s.martin49@gmail.com>,
	Sen Hastings <sen@phobosdpl.com>,
	buildroot@buildroot.org, Norbert Lange <nolange79@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH v5 2/2] package/pkg-meson: use meson to build/install packages
Date: Wed, 27 Jul 2022 13:25:23 +0200	[thread overview]
Message-ID: <20220727112523.GA1134587@scaer> (raw)
In-Reply-To: <20220727071557.3434892-2-james.hilliard1@gmail.com>

James, All,

On 2022-07-27 01:15 -0600, James Hilliard spake thusly:
> As of version 0.54.0 meson has had the ability to build and install
> packages rather than having to run ninja directly as before.
[--SNIP--]
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 47aaddf849..6efc8d636f 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
[--SNIP--]
> @@ -777,10 +777,7 @@ endef
>  HOST_SYSTEMD_CONF_OPTS = \
>  	-Dsplit-bin=true \
>  	-Dsplit-usr=false \
> -	--prefix=/usr \
> -	--libdir=lib \
> -	--sysconfdir=/etc \
> -	--localstatedir=/var \
> +	-Drootprefix=$(HOST_DIR) \

Have you read the explanations in 35c11a027c8 (package/systemd: add host
variant)? This change must expand on how it does not break things, with
a very good and detailed commit log, and as a separate patch.

Also, if the HOST_SYSTEMD_FIX_RPATH hook still needed, then?

Regards,
Yann E. MORIN.

>  	-Dutmp=false \
>  	-Dhibernate=false \
> @@ -852,8 +849,6 @@ HOST_SYSTEMD_DEPENDENCIES = \
>  	host-gperf \
>  	host-python-jinja2
>  
> -HOST_SYSTEMD_NINJA_ENV = DESTDIR=$(HOST_DIR)
> -
>  # Fix RPATH After installation
>  # * systemd provides a install_rpath instruction to meson because the binaries
>  #   need to link with libsystemd which is not in a standard path
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-07-27 11:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27  7:15 [Buildroot] [PATCH v5 1/2] support/misc/toolchainfile.cmake.in: don't set PKG_CONFIG_SYSROOT_DIR James Hilliard
2022-07-27  7:15 ` [Buildroot] [PATCH v5 2/2] package/pkg-meson: use meson to build/install packages James Hilliard
2022-07-27  9:00   ` Arnout Vandecappelle
2022-07-27 18:33     ` James Hilliard
2022-07-27 19:18       ` Yann E. MORIN
2022-07-28  1:48         ` James Hilliard
2022-07-27 11:25   ` Yann E. MORIN [this message]
2022-07-27 22:13     ` James Hilliard
2022-08-07 13:54 ` [Buildroot] [PATCH v5 1/2] support/misc/toolchainfile.cmake.in: don't set PKG_CONFIG_SYSROOT_DIR Thomas Petazzoni via buildroot
2022-08-08  7:15   ` James Hilliard
2022-08-12  5:08     ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220727112523.GA1134587@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=james.hilliard1@gmail.com \
    --cc=nolange79@gmail.com \
    --cc=s.martin49@gmail.com \
    --cc=sen@phobosdpl.com \
    --cc=thomas.de_schampheleire@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox