Re: [Buildroot] [PATCH v5 1/2] support/misc/toolchainfile.cmake.in: don't set PKG_CONFIG_SYSROOT_DIR

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello James,

On Wed, 27 Jul 2022 01:15:56 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> This doesn't appear to be required and seems to break for packages
> using meson's pkgconfig.relocatable format.

Thanks for your contribution. However, if you want us to merge this can
of contribution needs much, much, much better commit logs and
explanations.

An explanation that starts with "this doesn't appear to be required"
and continues with "seems to break" is the opposite of a convincing
explanation.

Here is the sort of commit log that we need:

"""
Defining PKG_CONFIG_SYSROOT_DIR in the CMake toolchain file is not
needed because it is already passed...

In addition, passing this in the CMake toolchain file causes breakage
of the following defconfig, once meson's pkgconfig.relocatable is
enabled, with the following failure:

[...]

This failure occurs because ...
"""

Note: I agree that passing PKG_CONFIG_SYSROOT_DIR in the CMake
toolchain file is probably not needed because our pkg-config wrapper
already passes the right value. However, I fail to see how that can
make a difference. How something in the CMake toolchain file can affect
the build of Meson based packages?

We very much appreciate all the improvements you are submitting, many
of them are very relevant and very useful. However, to have them
merged, we need detailed and convincing argumentation, no vague commit
logs that seem to indicate the change is actually papering over a
problem rather than addressing it for real.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot