Re: [Buildroot] [PATCH v5 2/2] package/pkg-meson: use meson to build/install packages

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Samuel Martin <s.martin49@gmail.com>,
	Sen Hastings <sen@phobosdpl.com>,
	buildroot <buildroot@buildroot.org>,
	Norbert Lange <nolange79@gmail.com>,
	Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Subject: Re: [Buildroot] [PATCH v5 2/2] package/pkg-meson: use meson to build/install packages
Date: Wed, 27 Jul 2022 21:18:55 +0200	[thread overview]
Message-ID: <20220727191855.GA1265196@scaer> (raw)
In-Reply-To: <CADvTj4qO6bzEjEG4Hs8Cy9McBqs0Vj4Pq37ZTw+h468OeCZLvA@mail.gmail.com>

James, All,

On 2022-07-27 12:33 -0600, James Hilliard spake thusly:
> On Wed, Jul 27, 2022 at 5:08 AM Arnout Vandecappelle <arnout@mind.be> wrote:
> > On 27/07/2022 09:15, James Hilliard wrote:
[--SNIP--]
> > > We need to set --pkgconfig.relocatable so that pkg-config files are
> > > not generated with absolute paths which cause issues with per-package
> > > directories.
> >   This still doesn't explain how it is related to using meson rather than ninja.
> > Are you saying that when calling ninja directly, PPD work perfectly fine, but if
> > it's installed with meson, it doesn't? Then I'd really like to have a little
> > more insight into what meson does to break it.
> Well, the issue seems to be that without --pkgconfig.relocatable meson install
> messes up the paths during install due to generating absolute pkgconfig paths
> while ninja doesn't.

But does that actually causes any real issue and build breakage?

For the non-PPD case, that should not be an issue, as the HOST_DIR (and
STAGING_DIR, below it) are constant throughout the build.

For the PPD case, we have a prepare hook that fixes the paths in all
text files, see b06294e9897e (core/pkg-generic: fixup all PPD paths in a
generic fashion). So this should be covered.

For the SDK, there is a script that does something very similar to the
PPD case, so again there should be no issue.

What is it that you actually want to achieve with relative paths, that
is currently broken with absolute paths?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot