Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled
Date: Sat, 30 Jul 2022 17:40:36 +0200	[thread overview]
Message-ID: <20220730174036.48ca64aa@windsurf> (raw)
In-Reply-To: <20220730105534.645046-1-bernd.kuhls@t-online.de>

Hello Bernd,

On Sat, 30 Jul 2022 12:55:34 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> The vp8 encoder depends on c++ support since commit
> 06a1a05b55aa64720d4ede9b07c385cc8f06625d
> 
> src/transcoding/codec/codecs/libs/libvpx.c:23:10: fatal error: vpx/vp8cx.h: No such file or directory
>    23 | #include <vpx/vp8cx.h>
> 
> Fixes:
> http://autobuild.buildroot.net/results/152/152dec2f7148a23fa1a434d2c6ad31de6d1b2466/
> http://autobuild.buildroot.net/results/009/0090b100eca4f94d2f0081ce0db7ff9b4ae0ca79/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/tvheadend/Config.in    | 3 ++-
>  package/tvheadend/tvheadend.mk | 7 +++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in
> index c033b29819..99a24ec011 100644
> --- a/package/tvheadend/Config.in
> +++ b/package/tvheadend/Config.in
> @@ -66,7 +66,8 @@ config BR2_PACKAGE_TVHEADEND_TRANSCODING
>  	select BR2_PACKAGE_FFMPEG_AVRESAMPLE
>  	select BR2_PACKAGE_FFMPEG_GPL # needed for x264 support
>  	select BR2_PACKAGE_FFMPEG_SWSCALE
> -	select BR2_PACKAGE_LIBVPX
> +	# vp8 encoder needs c++
> +	select BR2_PACKAGE_LIBVPX if BR2_INSTALL_LIBSTDCPP
>  	select BR2_PACKAGE_X264
>  	help
>  	  Enable transcoding support.
> diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk
> index 1d1a714505..8ceb7493c8 100644
> --- a/package/tvheadend/tvheadend.mk
> +++ b/package/tvheadend/tvheadend.mk
> @@ -47,6 +47,12 @@ TVHEADEND_DEPENDENCIES += rpi-userland
>  else
>  TVHEADEND_CONF_OPTS += --disable-omx
>  endif
> +ifeq ($(BR2_PACKAGE_LIBVPX)$(BR2_INSTALL_LIBSTDCPP),yy)
> +TVHEADEND_CONF_OPTS += --enable-libvpx
> +TVHEADEND_DEPENDENCIES += libvpx
> +else
> +TVHEADEND_CONF_OPTS += --disable-libvpx
> +endif

It is apparently an optional dependency, so why do we select it in
Config.in?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-07-30 15:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 10:55 [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled Bernd Kuhls
2022-07-30 15:40 ` Thomas Petazzoni via buildroot [this message]
2022-07-30 16:28   ` Arnout Vandecappelle
2022-08-01 20:25     ` Thomas Petazzoni via buildroot
     [not found] ` <20220730174036.48ca64aa__27858.7368129351$1659195663$gmane$org@windsurf>
2022-07-30 16:41   ` Bernd Kuhls
2022-08-01 20:37     ` Thomas Petazzoni via buildroot
2022-08-01 20:36 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220730174036.48ca64aa@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd.kuhls@t-online.de \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox