Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@uclibc.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled
Date: Mon, 1 Aug 2022 22:37:16 +0200	[thread overview]
Message-ID: <20220801223716.047dc5df@windsurf> (raw)
In-Reply-To: <pan$ececc$42d5a99c$43b7bc8f$13a84de7@ID-313208.user.individual.net>

On Sat, 30 Jul 2022 18:41:00 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> from the perspective of the build system, yes, libvpx is an optional 
> dependency. When it comes to the user perspective of the transcoding 
> feature, tvheadend by default includes codec-specific profiles, which 
> include vp8:
> https://github.com/tvheadend/tvheadend/blob/master/data/conf/transcoder/
> profiles
> 
> So users who enable the transcoding option are expecting vp8 support, 
> therefore I enabled it in Config.in:
> https://git.busybox.net/buildroot/commit/package/tvheadend?
> id=a9a14dc4357d32f705a52a5da73c782576ce6bc8

Thanks for the extra explanation, it would have been good to have it in
the commit log in the first place. Indeed, we normally prefer to keep
dependencies minimal in Buildroot in general, but I understand that
sometimes dependency that are optional from a build perspective are in
fact somewhat mandatory to make the package usable in practice.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-01 20:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 10:55 [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled Bernd Kuhls
2022-07-30 15:40 ` Thomas Petazzoni via buildroot
2022-07-30 16:28   ` Arnout Vandecappelle
2022-08-01 20:25     ` Thomas Petazzoni via buildroot
     [not found] ` <20220730174036.48ca64aa__27858.7368129351$1659195663$gmane$org@windsurf>
2022-07-30 16:41   ` Bernd Kuhls
2022-08-01 20:37     ` Thomas Petazzoni via buildroot [this message]
2022-08-01 20:36 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801223716.047dc5df@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@uclibc.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox