From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled
Date: Mon, 1 Aug 2022 22:25:35 +0200 [thread overview]
Message-ID: <20220801222535.1064c89d@windsurf> (raw)
In-Reply-To: <bf923353-f8b8-e93e-b911-f337f0f46da4@mind.be>
On Sat, 30 Jul 2022 18:28:43 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > It is apparently an optional dependency, so why do we select it in
> > Config.in?
>
> It is select'ed by transcoding support, but in the .mk file the optional
> dependency is always added just in case there's something else in tvheadend that
> starts using it.
This is not what's happening: Bernd's patch adds:
+ifeq ($(BR2_PACKAGE_LIBVPX)$(BR2_INSTALL_LIBSTDCPP),yy)
+TVHEADEND_CONF_OPTS += --enable-libvpx
+TVHEADEND_DEPENDENCIES += libvpx
+else
+TVHEADEND_CONF_OPTS += --disable-libvpx
+endif
inside the
ifeq ($(BR2_PACKAGE_TVHEADEND_TRANSCODING),y)
...
endif
condition.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-01 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 10:55 [Buildroot] [PATCH 1/1] package/tvheadend: fix build error with c++ disabled Bernd Kuhls
2022-07-30 15:40 ` Thomas Petazzoni via buildroot
2022-07-30 16:28 ` Arnout Vandecappelle
2022-08-01 20:25 ` Thomas Petazzoni via buildroot [this message]
[not found] ` <20220730174036.48ca64aa__27858.7368129351$1659195663$gmane$org@windsurf>
2022-07-30 16:41 ` Bernd Kuhls
2022-08-01 20:37 ` Thomas Petazzoni via buildroot
2022-08-01 20:36 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801222535.1064c89d@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=bernd.kuhls@t-online.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox