Re: [Buildroot] [PATCH 3/6] package/python-zlmdb: add new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Emile,

I have also applied this patch, though with some changes. See below.

On Sun,  3 Apr 2022 19:19:50 -0300
Emile Cormier <emile.cormier.jr@gmail.com> wrote:

> From: ecorm <ecorm@users.noreply.github.com>

I fixed this bogus From: value.

> 
> Required by python-crossbar.

Added an empty new line here.

> Signed-off-by: Emile Cormier <emile.cormier.jr@gmail.com>
> ---
>  DEVELOPERS                             |  5 +++++
>  package/Config.in                      |  1 +
>  package/python-zlmdb/Config.in         | 16 ++++++++++++++++
>  package/python-zlmdb/python-zlmdb.hash |  5 +++++
>  package/python-zlmdb/python-zlmdb.mk   | 14 ++++++++++++++
>  5 files changed, 41 insertions(+)
>  create mode 100644 package/python-zlmdb/Config.in
>  create mode 100644 package/python-zlmdb/python-zlmdb.hash
>  create mode 100644 package/python-zlmdb/python-zlmdb.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index a66b9d7eee..7f04663077 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -746,6 +746,11 @@ N:	Eloi Bail <eloi.bail@savoirfairelinux.com>
>  F:	package/bayer2rgb-neon/
>  F:	package/gstreamer1/gst1-plugins-bayer2rgb-neon/
>  
> +N:	Emile Cormier <emile.cormier.jr@gmail.com>
> +F:	package/python-autobahn/
> +F:	package/python-crossbar/
> +F:	package/python-zlmdb/

Reduce this to just adding package/python-zlmdb/. Entries for existing
packages should be added in a separate commit.

> diff --git a/package/python-zlmdb/Config.in b/package/python-zlmdb/Config.in
> new file mode 100644
> index 0000000000..9eaab3a7a7
> --- /dev/null
> +++ b/package/python-zlmdb/Config.in
> @@ -0,0 +1,16 @@
> +config BR2_PACKAGE_PYTHON_ZLMDB
> +	bool "python-zlmdb"
> +	select BR2_PACKAGE_PYTHON_CBOR2 # runtime
> +	select BR2_PACKAGE_PYTHON_CFFI # runtime
> +	select BR2_PACKAGE_PYTHON_CLICK # runtime
> +	select BR2_PACKAGE_PYTHON_FLATBUFFERS # runtime
> +	select BR2_PACKAGE_PYTHON_LMDB # runtime
> +	select BR2_PACKAGE_PYTHON_NUMPY # runtime

This one has some depends on that we need to replicate.

> +	select BR2_PACKAGE_PYTHON_PYNACL # runtime
> +	select BR2_PACKAGE_PYTHON_PYYAML # runtime
> +	select BR2_PACKAGE_PYTHON_TXAIO # runtime
> +	help
> +	  Object-relational zero-copy in-memory database layer for
> +	  LMDB.
> +
> +	  https://github.com/crossbario/zlmdb

So the final Config.in file looks like this:

config BR2_PACKAGE_PYTHON_ZLMDB
        bool "python-zlmdb"
        depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS # python-numpy
        depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy
        select BR2_PACKAGE_PYTHON_CBOR2 # runtime
        select BR2_PACKAGE_PYTHON_CFFI # runtime
        select BR2_PACKAGE_PYTHON_CLICK # runtime
        select BR2_PACKAGE_PYTHON_FLATBUFFERS # runtime
        select BR2_PACKAGE_PYTHON_LMDB # runtime
        select BR2_PACKAGE_PYTHON_NUMPY # runtime
        select BR2_PACKAGE_PYTHON_PYNACL # runtime
        select BR2_PACKAGE_PYTHON_PYYAML # runtime
        select BR2_PACKAGE_PYTHON_TXAIO # runtime
        help
          Object-relational zero-copy in-memory database layer for
          LMDB.

          https://github.com/crossbario/zlmdb

comment "python-zlmdb needs glibc or musl"
        depends on BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS
        depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)

Another thing that this package really needs is a test case, in
support/testing/tests/package/. I was trying to look for some
documentation, but apart from a pretty obscure reference document that
doesn't have much explanations, I couldn't find anything.

Do you have some simple example on how to use zlmdb? This would allow
us to add a test case for this package that has a lot of runtime
dependencies.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot