Re: [Buildroot] [PATCH 5/6] package/python-autobahn: add missing subpackages

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Emile,

I have applied, with a few changes, see below.

On Sun,  3 Apr 2022 19:19:52 -0300
Emile Cormier <emile.cormier.jr@gmail.com> wrote:

> From: ecorm <ecorm@users.noreply.github.com>
> 
> Added missing python-autobahn subpackages required by python-crossbar.
> Signed-off-by: Emile Cormier <emile.cormier.jr@gmail.com>

Fixed up the From: and missing empty line, as usual.

> +if BR2_PACKAGE_PYTHON_AUTOBAHN
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_TWISTED
> +	bool "Twisted support"
> +	select BR2_PACKAGE_PYTHON_ATTRS # runtime
> +	select BR2_PACKAGE_PYTHON_TWISTED # runtime
> +	select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE # runtime
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_ACCELERATE
> +	bool "C-based WebSocket acceleration"
> +	select BR2_PACKAGE_PYTHON_WSACCEL # runtime
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_COMPRESS
> +	bool "Non-standard WebSocket compression support"
> +	select BR2_PACKAGE_PYTHON_SNAPPY # runtime
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_SERIALIZATION
> +	bool "Accelerated JSON, MessagePack, CBOR, UBJSON, and FlatBuffers serialization support"
> +	select BR2_PACKAGE_PYTHON_CBOR # runtime

I do see the cbor2 dependency being expressed in setup.py, but not the
cbor dependency. Also, I only cbor2 being imported in the autobahn code
base, so I dropped this line. Of course, if there is something I
missed, let me know.

> +	select BR2_PACKAGE_PYTHON_CBOR2 # runtime
> +	select BR2_PACKAGE_PYTHON_FLATBUFFERS # runtime
> +	select BR2_PACKAGE_PYTHON_MSGPACK # runtime
> +	select BR2_PACKAGE_PYTHON_UBJSON # runtime
> +	select BR2_PACKAGE_PYTHON_UJSON # runtime
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_ENCRYPTION
> +	bool "TLS and WAMP-cryptosign encryption/authentication support"
> +	select BR2_PACKAGE_PYTHON_PYNACL # runtime
> +	select BR2_PACKAGE_PYTHON_PYOPENSSL # runtime
> +	select BR2_PACKAGE_PYTHON_PYQRCODE # runtime
> +	select BR2_PACKAGE_PYTHON_PYTRIE # runtime
> +	select BR2_PACKAGE_PYTHON_SERVICE_IDENTITY # runtime
> +
> +config BR2_PACKAGE_PYTHON_AUTOBAHN_SCRAM
> +	bool "WAMP-SCRAM authentication support"
> +	select BR2_PACKAGE_PYTHON_ARGON2_CFFI # runtime
> +	select BR2_PACKAGE_PYTHON_PASSLIB # runtime

The other thing I changed is to sort those sub-options alphabetically
by their option name.

Applied with those changes!

Thanks,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot