Re: [Buildroot] [PATCH 5/6] package/python-autobahn: add missing subpackages

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Emile Cormier <emile.cormier.jr@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Mauro Condarelli <mc5686@mclink.it>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 5/6] package/python-autobahn: add missing subpackages
Date: Sun, 7 Aug 2022 19:18:43 +0200	[thread overview]
Message-ID: <20220807191843.465aa42d@windsurf> (raw)
In-Reply-To: <CAM70yxBzagJt5b-3_vKO=AaknpvLbKhyLMPhbs=VC5XO0RgbOQ@mail.gmail.com>

Hello Emile,

On Sun, 7 Aug 2022 13:46:21 -0300
Emile Cormier <emile.cormier.jr@gmail.com> wrote:

> Are you sure you were checking in the 22.1.1  version of Autobahn?

No, I'm checking in version 22.6.1, because that's the one we have in
Buildroot now.

> The cbor dependency is here:
> https://github.com/crossbario/autobahn-python/blob/dc626948d5ffbd741ec1e3a7906870eae1a4c69b/setup.py#L82
> 
> "import cbor" is used in both these places:
> https://github.com/crossbario/autobahn-python/blob/dc626948d5ffbd741ec1e3a7906870eae1a4c69b/autobahn/wamp/message.py#L36
> https://github.com/crossbario/autobahn-python/blob/dc626948d5ffbd741ec1e3a7906870eae1a4c69b/autobahn/wamp/serializer.py#L660

Looking at 22.6.1, I think cbor is really no longer used:

$ git grep "import.*cbor.*"
autobahn/wamp/message.py:    import cbor2
autobahn/wamp/serializer.py:    import cbor2
autobahn/xbr/_buyer.py:import cbor2
autobahn/xbr/_cli.py:import cbor2
autobahn/xbr/_seller.py:import cbor2
autobahn/xbr/templates/py-autobahn/test_obj.py.jinja2:import cbor2

Am I missing something?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot