[Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Julien Olivain]

Octave package test can occasionally fail due to timeout.
This commit slightly increase timeout values to reduce those failures.

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
 support/testing/tests/package/test_octave.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/support/testing/tests/package/test_octave.py b/support/testing/tests/package/test_octave.py
index 82a70e09c2..2d808e0cca 100644
--- a/support/testing/tests/package/test_octave.py
+++ b/support/testing/tests/package/test_octave.py
@@ -34,6 +34,7 @@ class TestOctave(infra.basetest.BRTest):
                            kernel=kern,
                            kernel_cmdline=["console=ttyAMA0"],
                            options=["-M", "virt", "-cpu", "cortex-a57", "-m", "512M", "-initrd", img])
+        self.emulator.timeout_multiplier *= 2
         self.emulator.login()
 
         # Check Euler identity
@@ -76,4 +77,4 @@ class TestOctave(infra.basetest.BRTest):
 
         for mod in octave_modules:
             cmd = self.octave_cmd('assert(test(\"{}\"),true)'.format(mod))
-            self.assertRunOk(cmd)
+            self.assertRunOk(cmd, timeout=10)
-- 
2.37.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/octave: bump to version 7.2.0

[Julien Olivain]

For change log since 7.1.0, see:
- https://octave.org/news/release/2022/07/28/octave-7.2.0-released.html

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
Commit tested with:

    make check-package
    ...
    0 warnings generated

    ./utils/test-pkg -p octave
    ...
    6 builds, 4 skipped, 0 build failed, 0 legal-info failed, 0 show-info failed

    support/testing/run-tests \
        -d dl \
        -o output_folder \
        tests.package.test_octave.TestOctave
    ...
    OK
---
 package/octave/octave.hash | 2 +-
 package/octave/octave.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/octave/octave.hash b/package/octave/octave.hash
index 72d47cdf54..81d7311eeb 100644
--- a/package/octave/octave.hash
+++ b/package/octave/octave.hash
@@ -1,3 +1,3 @@
 # Locally computed
-sha256  9e8d1f4d64fa1bcfa30a571e240dc83715dbaede1de96a982bdc89cac7ced42c  octave-7.1.0.tar.lz
+sha256  009388289b82fdcc920a2371355049cb6958c735ee9aa3893a256df4a6bf7515  octave-7.2.0.tar.lz
 sha256  3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986  COPYING
diff --git a/package/octave/octave.mk b/package/octave/octave.mk
index 4e828eb734..b28617438a 100644
--- a/package/octave/octave.mk
+++ b/package/octave/octave.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OCTAVE_VERSION = 7.1.0
+OCTAVE_VERSION = 7.2.0
 OCTAVE_SITE = https://ftp.gnu.org/gnu/octave
 OCTAVE_SOURCE = octave-$(OCTAVE_VERSION).tar.lz
 OCTAVE_LICENSE = GPL-3.0+
-- 
2.37.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Thomas Petazzoni via buildroot]

Hello Julien,

On Sun,  7 Aug 2022 18:55:37 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Octave package test can occasionally fail due to timeout.
> This commit slightly increase timeout values to reduce those failures.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  support/testing/tests/package/test_octave.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/package/test_octave.py b/support/testing/tests/package/test_octave.py
> index 82a70e09c2..2d808e0cca 100644
> --- a/support/testing/tests/package/test_octave.py
> +++ b/support/testing/tests/package/test_octave.py
> @@ -34,6 +34,7 @@ class TestOctave(infra.basetest.BRTest):
>                             kernel=kern,
>                             kernel_cmdline=["console=ttyAMA0"],
>                             options=["-M", "virt", "-cpu", "cortex-a57", "-m", "512M", "-initrd", img])
> +        self.emulator.timeout_multiplier *= 2

Thanks for the patch.

I know a few other tests are tweaking timeout_multiplier, but I think
it's wrong. The idea of timeout_multiplier is that it's defined on the
command line, when running the tests, to indicate that you're running
on a "slow" machine that requires a timeout factor.

Tests should only tweak the timeout value, and the timeout_multiplier
will be applied to these timeouts.

So I think we should remove these tweaks on timeout_multiplier in test
cases, rather than add more.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/octave: bump to version 7.2.0

[Thomas Petazzoni via buildroot]

On Sun,  7 Aug 2022 18:55:38 +0200
Julien Olivain <ju.o@free.fr> wrote:

> For change log since 7.1.0, see:
> - https://octave.org/news/release/2022/07/28/octave-7.2.0-released.html
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> Commit tested with:

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Julien Olivain]

Hi Thomas,

On 07/08/2022 19:22, Thomas Petazzoni wrote:
> Hello Julien,
> 
> On Sun,  7 Aug 2022 18:55:37 +0200
> Julien Olivain <ju.o@free.fr> wrote:
> 
>> Octave package test can occasionally fail due to timeout.
>> This commit slightly increase timeout values to reduce those failures.
>> 
>> Signed-off-by: Julien Olivain <ju.o@free.fr>
>> ---
>>  support/testing/tests/package/test_octave.py | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/support/testing/tests/package/test_octave.py 
>> b/support/testing/tests/package/test_octave.py
>> index 82a70e09c2..2d808e0cca 100644
>> --- a/support/testing/tests/package/test_octave.py
>> +++ b/support/testing/tests/package/test_octave.py
>> @@ -34,6 +34,7 @@ class TestOctave(infra.basetest.BRTest):
>>                             kernel=kern,
>>                             kernel_cmdline=["console=ttyAMA0"],
>>                             options=["-M", "virt", "-cpu", 
>> "cortex-a57", "-m", "512M", "-initrd", img])
>> +        self.emulator.timeout_multiplier *= 2
> 
> Thanks for the patch.
> 
> I know a few other tests are tweaking timeout_multiplier, but I think
> it's wrong. The idea of timeout_multiplier is that it's defined on the
> command line, when running the tests, to indicate that you're running
> on a "slow" machine that requires a timeout factor.
> 
> Tests should only tweak the timeout value, and the timeout_multiplier
> will be applied to these timeouts.
> 
> So I think we should remove these tweaks on timeout_multiplier in test
> cases, rather than add more.

Thanks for the clarification.  I'll resend an updated patch without this
timeout_multiplier modification.

I'll use run-tests --timeout-multiplier 2 on my end, instead.

> Best regards,
> 
> Thomas

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/1] support/testing: octave: increase test timeout

[Julien Olivain]

Octave package test can occasionally fail due to timeout while testing
some octave modules. This commit slightly increase the timeout value
to reduce those failures.

Signed-off-by: Julien Olivain <ju.o@free.fr>
---
Changes v1 -> v2:
- removed tweak of self.emulator.timeout_multiplier,
  suggested by Thomas.
---
 support/testing/tests/package/test_octave.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/package/test_octave.py b/support/testing/tests/package/test_octave.py
index 82a70e09c2..cdbe2688df 100644
--- a/support/testing/tests/package/test_octave.py
+++ b/support/testing/tests/package/test_octave.py
@@ -76,4 +76,4 @@ class TestOctave(infra.basetest.BRTest):
 
         for mod in octave_modules:
             cmd = self.octave_cmd('assert(test(\"{}\"),true)'.format(mod))
-            self.assertRunOk(cmd)
+            self.assertRunOk(cmd, timeout=10)
-- 
2.37.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] support/testing: octave: increase test timeout

[Thomas Petazzoni via buildroot]

On Mon,  8 Aug 2022 22:14:24 +0200
Julien Olivain <ju.o@free.fr> wrote:

> Octave package test can occasionally fail due to timeout while testing
> some octave modules. This commit slightly increase the timeout value
> to reduce those failures.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> Changes v1 -> v2:
> - removed tweak of self.emulator.timeout_multiplier,
>   suggested by Thomas.
> ---
>  support/testing/tests/package/test_octave.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] support/testing: octave: increase test timeout

[Peter Korsgaard]

>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:

 > Octave package test can occasionally fail due to timeout.
 > This commit slightly increase timeout values to reduce those failures.

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed to 2022.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot