[Buildroot] [PATCH 1/1] package/xenomai: always set default version

[Buildroot] [PATCH 1/1] package/xenomai: always set default version

[Fabrice Fontaine]

Always set a default value for BR2_PACKAGE_XENOMAI_VERSION to avoid a
build failure when BR2_PACKAGE_XENOMAI_VERSION is empty with
BR2_PACKAGE_XENOMAI_CUSTOM_{GIT,VERSION}

Fixes:
 - http://autobuild.buildroot.org/results/d80c295a848b5be69324f5dfbd269b046dc68e8c
 - http://autobuild.buildroot.org/results/4e57a499b43208e546dd962ca04b43408c0c082c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/xenomai/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
index ec6d9e5d29..5c179eec72 100644
--- a/package/xenomai/Config.in
+++ b/package/xenomai/Config.in
@@ -73,8 +73,8 @@ config BR2_PACKAGE_XENOMAI_VERSION
 	string "Custom Xenomai version" if \
 		!BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
 		!BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
-	default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
 	default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
+	default "3.0.10"
 
 config BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL_URL
 	string "URL of custom tarball"
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version

[Thomas Petazzoni via buildroot]

On Mon,  8 Aug 2022 23:54:04 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Always set a default value for BR2_PACKAGE_XENOMAI_VERSION to avoid a
> build failure when BR2_PACKAGE_XENOMAI_VERSION is empty with
> BR2_PACKAGE_XENOMAI_CUSTOM_{GIT,VERSION}
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d80c295a848b5be69324f5dfbd269b046dc68e8c
>  - http://autobuild.buildroot.org/results/4e57a499b43208e546dd962ca04b43408c0c082c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/xenomai/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index ec6d9e5d29..5c179eec72 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -73,8 +73,8 @@ config BR2_PACKAGE_XENOMAI_VERSION
>  	string "Custom Xenomai version" if \
>  		!BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
>  		!BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> -	default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
>  	default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> +	default "3.0.10"

Meh, I don't like how Xenomai handles things differently than all other
packages that have a configurable version.

IMO, we should make Xenomai look like the other packages, which means:

 - Dropping default "https://gitlab.denx.de/Xenomai/xenomai.git"

 - Not have any default value for BR2_PACKAGE_XENOMAI_VERSION

We really want consistency on how this "custom version" thing is
handled.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 2226 bytes --]

Le mar. 9 août 2022 à 13:39, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a écrit :

> On Mon,  8 Aug 2022 23:54:04 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Always set a default value for BR2_PACKAGE_XENOMAI_VERSION to avoid a
> > build failure when BR2_PACKAGE_XENOMAI_VERSION is empty with
> > BR2_PACKAGE_XENOMAI_CUSTOM_{GIT,VERSION}
> >
> > Fixes:
> >  -
> http://autobuild.buildroot.org/results/d80c295a848b5be69324f5dfbd269b046dc68e8c
> >  -
> http://autobuild.buildroot.org/results/4e57a499b43208e546dd962ca04b43408c0c082c
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/xenomai/Config.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> > index ec6d9e5d29..5c179eec72 100644
> > --- a/package/xenomai/Config.in
> > +++ b/package/xenomai/Config.in
> > @@ -73,8 +73,8 @@ config BR2_PACKAGE_XENOMAI_VERSION
> >       string "Custom Xenomai version" if \
> >               !BR2_PACKAGE_XENOMAI_LATEST_VERSION && \
> >               !BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> > -     default "3.0.10" if BR2_PACKAGE_XENOMAI_LATEST_VERSION
> >       default "custom" if BR2_PACKAGE_XENOMAI_CUSTOM_TARBALL
> > +     default "3.0.10"
>
> Meh, I don't like how Xenomai handles things differently than all other
> packages that have a configurable version.
>

> IMO, we should make Xenomai look like the other packages, which means:
>
>  - Dropping default "https://gitlab.denx.de/Xenomai/xenomai.git"
>
Indeed, other packages don't set any values for git repository.

>
>  - Not have any default value for BR2_PACKAGE_XENOMAI_VERSION
>

This will not be really consistent with other packages.
arm-trusted-firmware, barebox, optee-os, opensbi and uboot all have default
values for
BR2_TARGET_{ARM_TRUSTED_FIRMWARE,BAREBOX,OPENSBI,OPTEE_OS,UBOOT}_VERSION

We really want consistency on how this "custom version" thing is
> handled.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 3857 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/xenomai: always set default version

[Thomas Petazzoni via buildroot]

Hello,

On Tue, 9 Aug 2022 14:12:53 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> >  - Not have any default value for BR2_PACKAGE_XENOMAI_VERSION
> >  
> 
> This will not be really consistent with other packages.
> arm-trusted-firmware, barebox, optee-os, opensbi and uboot all have default
> values for
> BR2_TARGET_{ARM_TRUSTED_FIRMWARE,BAREBOX,OPENSBI,OPTEE_OS,UBOOT}_VERSION

Well, not really for Git/Mercurial/SVN:

config BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION
        string "Custom repository version"
        help
          Revision to use in the typical format used by
          Git/Mercurial/Subversion E.G. a sha id, a tag, branch, ..

So no default version.

And:

config BR2_TARGET_UBOOT_VERSION
        string
        default "2022.04"       if BR2_TARGET_UBOOT_LATEST_VERSION
        default BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE \
                if BR2_TARGET_UBOOT_CUSTOM_VERSION
        default "custom"        if BR2_TARGET_UBOOT_CUSTOM_TARBALL
        default BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION \
                if BR2_TARGET_UBOOT_CUSTOM_GIT || BR2_TARGET_UBOOT_CUSTOM_HG || BR2_TARGET_UBOOT_CUSTOM_SVN

which only means that BR2_TARGET_BOOT_VERSION is automatically set to
BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION when Git/Mercurial/SVN is used.

I wouldn't call that having a default version :-)

I think we should use the same pattern everywhere.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot