[Buildroot] [PATCH 00/33] fix typos

[Buildroot] [PATCH 00/33] fix typos

[Ricardo Martincoski]

NOTICE: these patches were not build-tested!

Ricardo Martincoski (33):
1) typos on help and internal variables, found by code inspection:
  package/tclap: fix typo on help
  package/ti-gfx: fix typo on help
  package/gcnano-binaries: fix typo on help
  package/ace: fix typo on variable names
2) for consistency:
  package/c-capnproto: use space after depends on
  package/kvm-unit-tests: do not use "select...if SYMBOL=y"
  Config.in.legacy: add missing select
3) typos on symbols used by packages:
  package/libvncserver: fix typo on BR2_nios2
  package/libgpg-error: fix typo for BR2_aarch64_be
  package/freeswitch: fix typo on BR2_powerpc64le
  package/uclibc: drop old SPARC symbols
  package/tcf-agent: drop bogus BR2_powerpcle
  package/qemu: fix typo on STAGING_DIR
  package/tesseract-ocr: fix typo on BR2_PACKAGE_TESSERACT_OCR_LANG_GER
  package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON
  package/kodi: fix typo on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
  package/sconeserver: fix typo on BR2_STATIC_LIBS
  package/libglvnd: fix typo on BR2_PACKAGE_XORGPROTO
  boot/optee-os: fix typo on BR2_TARGET_OPTEE_OS_LATEST
  package/busybox: fix typo on BR2_PACKAGE_NETCAT_OPENBSD
  package/jquery-ui-themes: fix typo on
    BR2_PACKAGE_JQUERY_UI_THEMES_VADER
  package/gstreamer1/gst1-plugins-bad: fix typo on
    BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
  package/pcsc-lite: fix typo on BR2_PACKAGE_PCSC_LITE_*
4) bogus symbols referenced by packages
  package/zeek: drop bogus PYTHON3_HASHLIB
  package/cups: drop bogus libpaper dependency
  package/ranger: drop bogus BR2_PACKAGE_PYTHON_PYC_ONLY
  package/openocd: drop bogus BR2_PACKAGE_OPENOCD_ZY1000*
  package/directfb: drop bogus BR2_PACKAGE_DIRECTFB_CYBER5K
  package/x11r7/xserver_xorg-server: drop bogus
    BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS
  package/gstreamer1/gst1-plugins-good: drop bogus
    BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB
  package/libsepol: drop bogus BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6
  package/python-pygame: drop bogus
    BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC
5) the WIP script that found (2), (3) and (4)
  utils/check-symbols: new script

 Config.in.legacy                              |   1 +
 boot/optee-os/optee-os.mk                     |   2 +-
 package/ace/ace.mk                            |  14 +-
 package/busybox/busybox.mk                    |   2 +-
 package/c-capnproto/Config.in                 |   2 +-
 package/cups/cups.mk                          |   8 +-
 package/directfb/directfb.mk                  |   1 -
 package/freeswitch/freeswitch.mk              |   2 +-
 package/gcnano-binaries/Config.in             |   2 +-
 package/gstreamer1/gst1-plugins-bad/Config.in |   4 +-
 .../gst1-plugins-good/gst1-plugins-good.mk    |   4 -
 package/jquery-ui-themes/Config.in            |   2 +-
 package/kodi/Config.in                        |   2 +-
 package/kvm-unit-tests/Config.in              |   2 +-
 package/libglvnd/Config.in                    |   2 +-
 package/libgpg-error/Config.in                |   4 +-
 package/libsepol/Config.in                    |   1 -
 package/libvncserver/Config.in                |   2 +-
 package/openocd/openocd.mk                    |   2 -
 package/pcsc-lite/pcsc-lite.mk                |   4 +-
 package/python-pygame/Config.in               |   6 -
 package/qemu/qemu.mk                          |   2 +-
 package/ranger/ranger.mk                      |   2 +-
 package/sconeserver/Config.in                 |   2 +-
 package/tcf-agent/Config.in                   |   2 +-
 package/tclap/Config.in                       |   2 +-
 package/tesseract-ocr/tesseract-ocr.mk        |   2 +-
 package/ti-gfx/Config.in                      |   2 +-
 package/uclibc/Config.in                      |   3 +-
 package/wolftpm/wolftpm.mk                    |   2 +-
 package/x11r7/xserver_xorg-server/Config.in   |   6 +-
 package/zeek/Config.in                        |   1 -
 support/misc/gitlab-ci.yml.in                 |   8 ++
 support/scripts/generate-gitlab-ci-yml        |   2 +-
 utils/check-symbols                           |  50 +++++++
 utils/checksymbolslib/__init__.py             |   0
 utils/checksymbolslib/db.py                   |  63 +++++++++
 utils/checksymbolslib/file.py                 |  75 +++++++++++
 utils/checksymbolslib/kconfig.py              | 126 ++++++++++++++++++
 utils/checksymbolslib/makefile.py             |  47 +++++++
 utils/checksymbolslib/test_db.py              |  34 +++++
 utils/checksymbolslib/test_file.py            |  61 +++++++++
 utils/checksymbolslib/test_kconfig.py         |  46 +++++++
 43 files changed, 548 insertions(+), 59 deletions(-)
 create mode 100755 utils/check-symbols
 create mode 100644 utils/checksymbolslib/__init__.py
 create mode 100644 utils/checksymbolslib/db.py
 create mode 100644 utils/checksymbolslib/file.py
 create mode 100644 utils/checksymbolslib/kconfig.py
 create mode 100644 utils/checksymbolslib/makefile.py
 create mode 100644 utils/checksymbolslib/test_db.py
 create mode 100644 utils/checksymbolslib/test_file.py
 create mode 100644 utils/checksymbolslib/test_kconfig.py

-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 01/33] package/tclap: fix typo on help

[Ricardo Martincoski]

libary -> library

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/tclap/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/tclap/Config.in b/package/tclap/Config.in
index 560cf33174..64b0b74c8a 100644
--- a/package/tclap/Config.in
+++ b/package/tclap/Config.in
@@ -8,7 +8,7 @@ config BR2_PACKAGE_TCLAP
 	  This is a small, flexible library that provides a simple
 	  interface for defining and accessing command line
 	  arguments. It was initially inspired by the user friendly
-	  CLAP libary. The difference is that this library is
+	  CLAP library. The difference is that this library is
 	  templatized, so the argument class is type independent. Type
 	  independence avoids identical-except-for-type objects, such
 	  as IntArg, FloatArg, and StringArg. While the library is not
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/33] package/tclap: fix typo on help

[Thomas Huth]

Am Sun, 14 Aug 2022 20:38:13 -0300
schrieb Ricardo Martincoski <ricardo.martincoski@gmail.com>:

> libary -> library
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
>  package/tclap/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/tclap/Config.in b/package/tclap/Config.in
> index 560cf33174..64b0b74c8a 100644
> --- a/package/tclap/Config.in
> +++ b/package/tclap/Config.in
> @@ -8,7 +8,7 @@ config BR2_PACKAGE_TCLAP
>  	  This is a small, flexible library that provides a simple
>  	  interface for defining and accessing command line
>  	  arguments. It was initially inspired by the user friendly
> -	  CLAP libary. The difference is that this library is
> +	  CLAP library. The difference is that this library is
>  	  templatized, so the argument class is type independent. Type
>  	  independence avoids identical-except-for-type objects, such
>  	  as IntArg, FloatArg, and StringArg. While the library is not

Reviewed-by: Thomas Huth <huth@tuxfamily.org>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/33] package/tclap: fix typo on help

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > libary -> library
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 02/33] package/ti-gfx: fix typo on help

[Ricardo Martincoski]

libaries -> libraries

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/ti-gfx/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ti-gfx/Config.in b/package/ti-gfx/Config.in
index 76aabcb8c4..40f46335a3 100644
--- a/package/ti-gfx/Config.in
+++ b/package/ti-gfx/Config.in
@@ -45,7 +45,7 @@ config BR2_PACKAGE_TI_GFX_DEMOS
 config BR2_PACKAGE_TI_GFX_EGLIMAGE
 	bool "install eglimage version of libraries"
 	help
-	  Installs OpenGL libaries which support the eglimage api.
+	  Installs OpenGL libraries which support the eglimage api.
 
 choice
 	prompt "Target"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 02/33] package/ti-gfx: fix typo on help

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > libaries -> libraries
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 03/33] package/gcnano-binaries: fix typo on help

[Ricardo Martincoski]

libaries -> libraries

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/gcnano-binaries/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gcnano-binaries/Config.in b/package/gcnano-binaries/Config.in
index ade19e2121..89f909f2c3 100644
--- a/package/gcnano-binaries/Config.in
+++ b/package/gcnano-binaries/Config.in
@@ -22,7 +22,7 @@ config BR2_PACKAGE_GCNANO_BINARIES
 	select BR2_PACKAGE_LIBDRM
 	select BR2_PACKAGE_WAYLAND
 	help
-	  Driver and libaries for stm vivante gcnano gpu.
+	  Driver and libraries for stm vivante gcnano gpu.
 	  https://github.com/STMicroelectronics/gcnano-binaries/
 
 if BR2_PACKAGE_GCNANO_BINARIES
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 03/33] package/gcnano-binaries: fix typo on help

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > libaries -> libraries
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 04/33] package/ace: fix typo on variable names

[Ricardo Martincoski]

LIBARIES -> LIBRARIES

Cc: Matt Weber <matthew.weber@collins.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/ace/ace.mk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/package/ace/ace.mk b/package/ace/ace.mk
index 3f7fe5e994..29555eea74 100644
--- a/package/ace/ace.mk
+++ b/package/ace/ace.mk
@@ -15,7 +15,7 @@ ACE_CPE_ID_PRODUCT = adaptive_communication_environment
 
 # Note: We are excluding examples, apps and tests
 # Only compiling ACE libraries (no TAO)
-ACE_LIBARIES = ace ACEXML Kokyu netsvcs protocols/ace
+ACE_LIBRARIES = ace ACEXML Kokyu netsvcs protocols/ace
 
 ACE_CPPFLAGS = $(TARGET_CPPFLAGS) -std=c++11
 
@@ -31,7 +31,7 @@ ACE_MAKE_OPTS = \
 	DEFFLAGS="$(ACE_CPPFLAGS)"
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
-ACE_LIBARIES += ace/SSL
+ACE_LIBRARIES += ace/SSL
 ACE_DEPENDENCIES += openssl
 define ACE_CONFIGURE_SSL
 	echo "ssl = 1" >> $(@D)/include/makeinclude/platform_macros.GNU
@@ -51,25 +51,25 @@ define ACE_CONFIGURE_CMDS
 endef
 
 define ACE_BUILD_CMDS
-	$(foreach lib,$(ACE_LIBARIES), \
+	$(foreach lib,$(ACE_LIBRARIES), \
 		$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)/$(lib) \
 			$(ACE_MAKE_OPTS) all
 	)
 endef
 
-define  ACE_LIBARIES_INSTALL
+define  ACE_LIBRARIES_INSTALL
 	mkdir -p $(1)/usr/share/ace
-	$(foreach lib,$(ACE_LIBARIES), \
+	$(foreach lib,$(ACE_LIBRARIES), \
 		$(MAKE) -C $(@D)/$(lib) $(ACE_MAKE_OPTS) DESTDIR=$(1) install
 	)
 endef
 
 define  ACE_INSTALL_TARGET_CMDS
-	$(call ACE_LIBARIES_INSTALL,$(TARGET_DIR))
+	$(call ACE_LIBRARIES_INSTALL,$(TARGET_DIR))
 endef
 
 define  ACE_INSTALL_STAGING_CMDS
-	$(call ACE_LIBARIES_INSTALL,$(STAGING_DIR))
+	$(call ACE_LIBRARIES_INSTALL,$(STAGING_DIR))
 endef
 
 $(eval $(generic-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 04/33] package/ace: fix typo on variable names

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > LIBARIES -> LIBRARIES
 > Cc: Matt Weber <matthew.weber@collins.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 05/33] package/c-capnproto: use space after depends on

[Ricardo Martincoski]

This is the only use in the tree without the space.
Do like the other 2k+ uses in the tree and add the space:
-depends on!BR2_...
+depends on !BR2_...

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/c-capnproto/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/c-capnproto/Config.in b/package/c-capnproto/Config.in
index 41a59d7a22..c472128c3f 100644
--- a/package/c-capnproto/Config.in
+++ b/package/c-capnproto/Config.in
@@ -18,7 +18,7 @@ config BR2_PACKAGE_C_CAPNPROTO
 
 comment "c-capnproto needs host and target gcc >= 5 w/ C++14, threads, atomic, ucontext and not gcc bug 64735"
 	depends on BR2_USE_MMU
-	depends on!BR2_HOST_GCC_AT_LEAST_5 || \
+	depends on !BR2_HOST_GCC_AT_LEAST_5 || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
 		!BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS || \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 05/33] package/c-capnproto: use space after depends on

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > This is the only use in the tree without the space.
 > Do like the other 2k+ uses in the tree and add the space:
 > -depends on!BR2_...
 > +depends on !BR2_...

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 06/33] package/kvm-unit-tests: do not use "select...if SYMBOL=y"

[Ricardo Martincoski]

All other occurrencies in the tree simply do:
select SYMBOL1 if SYMBOL2
instead of
select SYMBOL1 if SYMBOL2=y

So do the same here for consistency.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/kvm-unit-tests/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in
index 7658877ce9..02ea8dd58c 100644
--- a/package/kvm-unit-tests/Config.in
+++ b/package/kvm-unit-tests/Config.in
@@ -20,7 +20,7 @@ config BR2_PACKAGE_KVM_UNIT_TESTS
 	# x86-64 we use the host gcc (see .mk file for details)
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 || !BR2_i386
 	depends on BR2_HOSTARCH = "x86_64" || !BR2_x86_64
-	select BR2_HOSTARCH_NEEDS_IA32_COMPILER if BR2_x86_64=y
+	select BR2_HOSTARCH_NEEDS_IA32_COMPILER if BR2_x86_64
 	help
 	  kvm-unit-tests is a project as old as KVM. As its name
 	  suggests, it's purpose is to provide unit tests for KVM. The
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 06/33] package/kvm-unit-tests: do not use "select...if SYMBOL=y"

[Thomas Huth]

Am Sun, 14 Aug 2022 20:38:18 -0300
schrieb Ricardo Martincoski <ricardo.martincoski@gmail.com>:

> All other occurrencies in the tree simply do:
> select SYMBOL1 if SYMBOL2
> instead of
> select SYMBOL1 if SYMBOL2=y
> 
> So do the same here for consistency.
> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
>  package/kvm-unit-tests/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/kvm-unit-tests/Config.in b/package/kvm-unit-tests/Config.in
> index 7658877ce9..02ea8dd58c 100644
> --- a/package/kvm-unit-tests/Config.in
> +++ b/package/kvm-unit-tests/Config.in
> @@ -20,7 +20,7 @@ config BR2_PACKAGE_KVM_UNIT_TESTS
>  	# x86-64 we use the host gcc (see .mk file for details)
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 || !BR2_i386
>  	depends on BR2_HOSTARCH = "x86_64" || !BR2_x86_64
> -	select BR2_HOSTARCH_NEEDS_IA32_COMPILER if BR2_x86_64=y
> +	select BR2_HOSTARCH_NEEDS_IA32_COMPILER if BR2_x86_64
>  	help
>  	  kvm-unit-tests is a project as old as KVM. As its name
>  	  suggests, it's purpose is to provide unit tests for KVM. The

Reviewed-by: Thomas Huth <huth@tuxfamily.org>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 06/33] package/kvm-unit-tests: do not use "select...if SYMBOL=y"

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > All other occurrencies in the tree simply do:
 > select SYMBOL1 if SYMBOL2
 > instead of
 > select SYMBOL1 if SYMBOL2=y

 > So do the same here for consistency.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 07/33] Config.in.legacy: add missing select

[Ricardo Martincoski]

BR2_LINUX_KERNEL_CUSTOM_LOCAL was moved to legacy handling during release
2016.11 but does not select BR2_LEGACY.
Add the select, like done by all other symbols in the file.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 Config.in.legacy | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Config.in.legacy b/Config.in.legacy
index 80c443d9fb..03814c0378 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -3953,6 +3953,7 @@ config BR2_PACKAGE_ELEMENTARY
 
 config BR2_LINUX_KERNEL_CUSTOM_LOCAL
 	bool "Linux kernel local directory option removed"
+	select BR2_LEGACY
 	help
 	  The option to select a local directory as the source of the
 	  Linux kernel has been removed. It hurts reproducibility of
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 07/33] Config.in.legacy: add missing select

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > BR2_LINUX_KERNEL_CUSTOM_LOCAL was moved to legacy handling during release
 > 2016.11 but does not select BR2_LEGACY.
 > Add the select, like done by all other symbols in the file.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 08/33] package/libvncserver: fix typo on BR2_nios2

[Ricardo Martincoski]

From time to time we have a reference added to the inexistent BR2_nios:
$ git log --oneline -G'BR2_nios\>'
726dcc6eee package/libvncserver: needs dynamic library
8cd840b7e8 package/ffmpeg: fix typo "nios" -> "nios2"
bd2544d3d3 package/ffmpeg: simplify BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS logic
de7523259b libplayer: fix typo on BR2_nios2
615d65d3c6 mplayer: add missing reverse dependencies for nios2 and sh2a

Fix the last commit, from 2019, like it was done before.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/libvncserver/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libvncserver/Config.in b/package/libvncserver/Config.in
index 6189b379d2..f284894555 100644
--- a/package/libvncserver/Config.in
+++ b/package/libvncserver/Config.in
@@ -27,5 +27,5 @@ endif
 
 comment "libvncserver needs a toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_nios
+	depends on !BR2_nios2
 	depends on BR2_STATIC_LIBS
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 08/33] package/libvncserver: fix typo on BR2_nios2

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > From time to time we have a reference added to the inexistent BR2_nios:
 > $ git log --oneline -G'BR2_nios\>'
 > 726dcc6eee package/libvncserver: needs dynamic library
 > 8cd840b7e8 package/ffmpeg: fix typo "nios" -> "nios2"
 > bd2544d3d3 package/ffmpeg: simplify BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS logic
 > de7523259b libplayer: fix typo on BR2_nios2
 > 615d65d3c6 mplayer: add missing reverse dependencies for nios2 and sh2a

 > Fix the last commit, from 2019, like it was done before.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 09/33] package/libgpg-error: fix typo for BR2_aarch64_be

[Ricardo Martincoski]

The typo was introduced in 2016 by commit
'2f89476ad9 package/libgpg-error: bump to version 1.23'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/libgpg-error/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/libgpg-error/Config.in b/package/libgpg-error/Config.in
index 03157dd9fe..5a2c14ead8 100644
--- a/package/libgpg-error/Config.in
+++ b/package/libgpg-error/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
 	bool
 	# see src/syscfg/
 	default y if \
-		BR2_aarch64	|| BR2_aarch64_eb	|| \
+		BR2_aarch64	|| BR2_aarch64_be	|| \
 		BR2_arm		|| BR2_armeb		|| \
 		BR2_i386	|| BR2_mips		|| \
 		BR2_mipsel	|| BR2_mips64		|| \
@@ -28,7 +28,7 @@ config BR2_PACKAGE_LIBGPG_ERROR
 config BR2_PACKAGE_LIBGPG_ERROR_SYSCFG
 	string
 	default "aarch64-unknown-linux-gnu" \
-		if BR2_aarch64 || BR2_aarch64_eb
+		if BR2_aarch64 || BR2_aarch64_be
 	default "arm-unknown-linux-gnueabi" \
 		if BR2_arm || BR2_armeb
 	default "i686-pc-linux-gnu" \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 09/33] package/libgpg-error: fix typo for BR2_aarch64_be

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was introduced in 2016 by commit
 > '2f89476ad9 package/libgpg-error: bump to version 1.23'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 10/33] package/freeswitch: fix typo on BR2_powerpc64le

[Ricardo Martincoski]

The typo was added by commit from 2016
'0480bbc1a0 package/freeswitch: new package'

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/freeswitch/freeswitch.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/freeswitch/freeswitch.mk b/package/freeswitch/freeswitch.mk
index c576e5f267..24c1ee4dd4 100644
--- a/package/freeswitch/freeswitch.mk
+++ b/package/freeswitch/freeswitch.mk
@@ -80,7 +80,7 @@ FREESWITCH_CONF_OPTS = \
 
 # zrtp supports a limited set of archs, sparc support is also broken due
 # to a broken ld call by gcc, see libs/libzrtp/include/zrtp_config.h
-ifeq ($(BR2_i386)$(BR2_arm)$(BR2_armeb)$(BR2_aarch64)$(BR2_aarch64_be)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpcle)$(BR2_x86_64),y)
+ifeq ($(BR2_i386)$(BR2_arm)$(BR2_armeb)$(BR2_aarch64)$(BR2_aarch64_be)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_powerpc)$(BR2_powerpc64)$(BR2_powerpc64le)$(BR2_x86_64),y)
 FREESWITCH_LICENSE_FILES += libs/libzrtp/src/zrtp_legal.c
 FREESWITCH_CONF_OPTS += --enable-zrtp
 else
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 10/33] package/freeswitch: fix typo on BR2_powerpc64le

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added by commit from 2016
 > '0480bbc1a0 package/freeswitch: new package'

 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 11/33] package/uclibc: drop old SPARC symbols

[Ricardo Martincoski]

BR2_sparc_v7 was removed in 2013 in commit '16bcf46a63 arch/sparc: drop
old SUN-specific variants'.

BR2_sparc_sparchfleon and BR2_sparc_sparchfleonv8 were moved to legacy
handling in 2014 in commit '43b78e7285 arch: sparc: Add leon3 cpu type
and remove sparc{s,h}fleon{,v8}' and later removed from legacy handling
in 2020.

So drop the remaining references for these symbols.

Cc: Waldemar Brodkorb <wbx@openadk.org>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/uclibc/Config.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/package/uclibc/Config.in b/package/uclibc/Config.in
index ba8b5885ec..2555487f06 100644
--- a/package/uclibc/Config.in
+++ b/package/uclibc/Config.in
@@ -159,8 +159,7 @@ config BR2_UCLIBC_SH_TYPE
 
 config BR2_UCLIBC_SPARC_TYPE
 	string
-	default "V7"	if BR2_sparc_v7 || BR2_sparc_sparchfleon || BR2_sparc_sparcsfleon
-	default "V8"	if BR2_sparc_v8 || BR2_sparc_sparchfleonv8 || BR2_sparc_sparcsfleonv8
+	default "V8"	if BR2_sparc_v8
 	depends on BR2_UCLIBC_TARGET_ARCH = "sparc"
 
 config BR2_UCLIBC_POWERPC_TYPE
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 11/33] package/uclibc: drop old SPARC symbols

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > BR2_sparc_v7 was removed in 2013 in commit '16bcf46a63 arch/sparc: drop
 > old SUN-specific variants'.

 > BR2_sparc_sparchfleon and BR2_sparc_sparchfleonv8 were moved to legacy
 > handling in 2014 in commit '43b78e7285 arch: sparc: Add leon3 cpu type
 > and remove sparc{s,h}fleon{,v8}' and later removed from legacy handling
 > in 2020.

 > So drop the remaining references for these symbols.

 > Cc: Waldemar Brodkorb <wbx@openadk.org>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 12/33] package/tcf-agent: drop bogus BR2_powerpcle

[Ricardo Martincoski]

The inexistent symbol is referenced by commit from 2018:
'd0d04b4c5a tcf-agent: new package'

Cc: Eugene Tarassov <eugene@largest.net>
Cc: Norbert Lange <nolange79@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/tcf-agent/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/tcf-agent/Config.in b/package/tcf-agent/Config.in
index 50e58642b0..8c7aab0c0b 100644
--- a/package/tcf-agent/Config.in
+++ b/package/tcf-agent/Config.in
@@ -27,7 +27,7 @@ config BR2_PACKAGE_TCF_AGENT_ARCH
 	default "i686"       if BR2_i386 && BR2_ARCH="i686"
 	default "i386"       if BR2_i386 && !BR2_ARCH="i686"
 	default "x86_64"     if BR2_x86_64
-	default "powerpc"    if BR2_powerpc || BR2_powerpcle
+	default "powerpc"    if BR2_powerpc
 	default "ppc64"      if BR2_powerpc64 || BR2_powerpc64le
 	default "microblaze" if BR2_microblaze || BR2_microblazeel
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 12/33] package/tcf-agent: drop bogus BR2_powerpcle

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The inexistent symbol is referenced by commit from 2018:
 > 'd0d04b4c5a tcf-agent: new package'

 > Cc: Eugene Tarassov <eugene@largest.net>
 > Cc: Norbert Lange <nolange79@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 13/33] package/qemu: fix typo on STAGING_DIR

[Ricardo Martincoski]

Since this commit from 2010:
'87b81bb56f toolchain: move sysroot to host dir'
BR2_STAGING_DIR does not exist anymore.
So fix the typo added in 2014 with commit:
8956c336eb package/qemu: add SDL frontends

Cc: Romain Naour <romain.naour@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/qemu/qemu.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 9e1bec3836..f86c4c41ac 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -72,7 +72,7 @@ endif
 ifeq ($(BR2_PACKAGE_QEMU_SDL),y)
 QEMU_OPTS += --enable-sdl
 QEMU_DEPENDENCIES += sdl2
-QEMU_VARS += SDL2_CONFIG=$(BR2_STAGING_DIR)/usr/bin/sdl2-config
+QEMU_VARS += SDL2_CONFIG=$(STAGING_DIR)/usr/bin/sdl2-config
 else
 QEMU_OPTS += --disable-sdl
 endif
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 13/33] package/qemu: fix typo on STAGING_DIR

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > Since this commit from 2010:
 > '87b81bb56f toolchain: move sysroot to host dir'
 > BR2_STAGING_DIR does not exist anymore.
 > So fix the typo added in 2014 with commit:
 > 8956c336eb package/qemu: add SDL frontends

 > Cc: Romain Naour <romain.naour@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 14/33] package/tesseract-ocr: fix typo on BR2_PACKAGE_TESSERACT_OCR_LANG_GER

[Ricardo Martincoski]

The typo was added in 2017 by commit
'd1103eeab3 tesseract-ocr: new package'

Cc: Gilles Talis <gilles.talis@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/tesseract-ocr/tesseract-ocr.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/tesseract-ocr/tesseract-ocr.mk b/package/tesseract-ocr/tesseract-ocr.mk
index a7498931fb..5e9da0c648 100644
--- a/package/tesseract-ocr/tesseract-ocr.mk
+++ b/package/tesseract-ocr/tesseract-ocr.mk
@@ -39,7 +39,7 @@ ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_FRA),y)
 TESSERACT_OCR_DATA_FILES += fra.traineddata
 endif
 
-ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_DEU),y)
+ifeq ($(BR2_PACKAGE_TESSERACT_OCR_LANG_GER),y)
 TESSERACT_OCR_DATA_FILES += deu.traineddata
 endif
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 14/33] package/tesseract-ocr: fix typo on BR2_PACKAGE_TESSERACT_OCR_LANG_GER

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added in 2017 by commit
 > 'd1103eeab3 tesseract-ocr: new package'

 > Cc: Gilles Talis <gilles.talis@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON

[Ricardo Martincoski]

The typo was added by commit 'd0dcc62c4b package/wolftpm: Add config
options for TPM 2.0 extra capabilities'

Cc: Dimitar Tomov <dimi@tpm.dev>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/wolftpm/wolftpm.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
index d3f693a62e..7e8a108585 100644
--- a/package/wolftpm/wolftpm.mk
+++ b/package/wolftpm/wolftpm.mk
@@ -41,7 +41,7 @@ else
 WOLFTPM_CONF_OPTS += --disable-st33
 endif
 
-ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y)
+ifeq ($(BR2_PACKAGE_WOLFTPM_NUVOTON),y)
 WOLFTPM_CONF_OPTS += --enable-nuvoton
 else
 WOLFTPM_CONF_OPTS += --disable-nuvoton
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON

[Dimi Tomov]

This is intended and not a typo.

If you rename BR2_PACKAGE_WOLFTPM_NUVOTON to ... NPCT750 it would not 
match the actual wolfTPM options that is "--enable-nuvoton".

Here is our motivation:
--enable-st33 enables capabilities ONLY for STMicroelectronics ST33.
--enable-nuvoton enables capabilities ONLY for NPCT750.

I remember that the reason behind choosing nuvoton over npct750 for the 
config name is because of the difficulty to remember it in comparison 
with st33.

Also, the package/wolftpm/Config.in clearly explains in one sentence 
what this option does.

Thank you for addressing this Ricardo.

Regards,
Dimi
-- 
Founder of TPM.dev

On 2022-08-15 02:38 AM, Ricardo Martincoski wrote:
> The typo was added by commit 'd0dcc62c4b package/wolftpm: Add config
> options for TPM 2.0 extra capabilities'
> 
> Cc: Dimitar Tomov <dimi@tpm.dev>
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
> ---
>  package/wolftpm/wolftpm.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/wolftpm/wolftpm.mk b/package/wolftpm/wolftpm.mk
> index d3f693a62e..7e8a108585 100644
> --- a/package/wolftpm/wolftpm.mk
> +++ b/package/wolftpm/wolftpm.mk
> @@ -41,7 +41,7 @@ else
>  WOLFTPM_CONF_OPTS += --disable-st33
>  endif
> 
> -ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y)
> +ifeq ($(BR2_PACKAGE_WOLFTPM_NUVOTON),y)
>  WOLFTPM_CONF_OPTS += --enable-nuvoton
>  else
>  WOLFTPM_CONF_OPTS += --disable-nuvoton
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON

[Yann E. MORIN]

Dimi, Al,,

On 2022-08-15 20:46 +0300, Dimi Tomov spake thusly:
> This is intended and not a typo.
> 
> If you rename BR2_PACKAGE_WOLFTPM_NUVOTON to ... NPCT750 it would not match
> the actual wolfTPM options that is "--enable-nuvoton".

I am afraid you got it wrong. The option is still named
BR2_PACKAGE_WOLFTPM_NUVOTON.

However, in the .mk, it was referenced as BR2_PACKAGE_WOLFTPM_NPCT750
which does not exist and is not defined anywhere.

So, all the patch does is use the correct option from Kconfig:

> >-ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y)
> >+ifeq ($(BR2_PACKAGE_WOLFTPM_NUVOTON),y)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 15/33] package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON

[Dimi Tomov]

Oh, indeed. Thank you Yani.

Thank you for this fix Ricardo.

Dimi

Sent from my iPhone

> On 15 Aug 2022, at 21:03, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> 
> Dimi, Al,,
> 
> On 2022-08-15 20:46 +0300, Dimi Tomov spake thusly:
>> This is intended and not a typo.
>> 
>> If you rename BR2_PACKAGE_WOLFTPM_NUVOTON to ... NPCT750 it would not match
>> the actual wolfTPM options that is "--enable-nuvoton".
> 
> I am afraid you got it wrong. The option is still named
> BR2_PACKAGE_WOLFTPM_NUVOTON.
> 
> However, in the .mk, it was referenced as BR2_PACKAGE_WOLFTPM_NPCT750
> which does not exist and is not defined anywhere.
> 
> So, all the patch does is use the correct option from Kconfig:
> 
>>> -ifeq ($(BR2_PACKAGE_WOLFTPM_NPCT750),y)
>>> +ifeq ($(BR2_PACKAGE_WOLFTPM_NUVOTON),y)
> 
> Regards,
> Yann E. MORIN.
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 16/33] package/kodi: fix typo on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11

[Ricardo Martincoski]

Typo was added in 2021 by commit
148e695e37 package/kodi: bump version to 19.0-Matrix

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/kodi/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 4c6e01745c..90710683db 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -250,7 +250,7 @@ config BR2_PACKAGE_KODI_LIBUSB
 
 config BR2_PACKAGE_KODI_LIBVDPAU
 	bool "vdpau"
-	depends on BR2_PACKAGE_KODI_PLATFORM_X11 && \
+	depends on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11 && \
 		BR2_PACKAGE_KODI_RENDER_SYSTEM_GL
 	select BR2_PACKAGE_LIBVDPAU
 	help
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 16/33] package/kodi: fix typo on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > Typo was added in 2021 by commit
 > 148e695e37 package/kodi: bump version to 19.0-Matrix

 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 17/33] package/sconeserver: fix typo on BR2_STATIC_LIBS

[Ricardo Martincoski]

The typo was added by this commit from 2015:
'db989f89c9 gpsd: requires shared library support'

Cc: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/sconeserver/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sconeserver/Config.in b/package/sconeserver/Config.in
index eed777ae96..3040dddbbb 100644
--- a/package/sconeserver/Config.in
+++ b/package/sconeserver/Config.in
@@ -55,7 +55,7 @@ config BR2_PACKAGE_SCONESERVER_LOCATION
 
 comment "location support needs a toolchain w/ theads, dynamic library"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBRARY
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
 
 config BR2_PACKAGE_SCONESERVER_MATHS
 	bool "maths"
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 17/33] package/sconeserver: fix typo on BR2_STATIC_LIBS

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added by this commit from 2015:
 > 'db989f89c9 gpsd: requires shared library support'

 > Cc: Simon Dawson <spdawson@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 18/33] package/libglvnd: fix typo on BR2_PACKAGE_XORGPROTO

[Ricardo Martincoski]

The typo was added in 2020 by commit
'0378e2e5d9 package/libglvnd: new package'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/libglvnd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libglvnd/Config.in b/package/libglvnd/Config.in
index d020c21465..f471e289bd 100644
--- a/package/libglvnd/Config.in
+++ b/package/libglvnd/Config.in
@@ -24,7 +24,7 @@ config BR2_PACKAGE_LIBGLVND_DISPATCH_GL
 	depends on BR2_PACKAGE_XORG7 # libx11, libXext, xorgproto
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXEXT
-	select BR2_PACKAGE_XLIB_XORGPROTO
+	select BR2_PACKAGE_XORGPROTO
 	select BR2_PACKAGE_HAS_LIBGL
 
 config BR2_PACKAGE_LIBGLVND_DISPATCH_EGL
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 18/33] package/libglvnd: fix typo on BR2_PACKAGE_XORGPROTO

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added in 2020 by commit
 > '0378e2e5d9 package/libglvnd: new package'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 19/33] boot/optee-os: fix typo on BR2_TARGET_OPTEE_OS_LATEST

[Ricardo Martincoski]

The typo was added by commit
'9c79b369d6 boot/optee-os: add support for custom tarball URL'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 boot/optee-os/optee-os.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/boot/optee-os/optee-os.mk b/boot/optee-os/optee-os.mk
index fa6ee93137..136c4b2401 100644
--- a/boot/optee-os/optee-os.mk
+++ b/boot/optee-os/optee-os.mk
@@ -24,7 +24,7 @@ else
 OPTEE_OS_SITE = $(call github,OP-TEE,optee_os,$(OPTEE_OS_VERSION))
 endif
 
-ifeq ($(BR2_TARGET_OPTEE_OS):$(BR2_TARGET_OPTEE_OS_LATEST_VERSION),y:)
+ifeq ($(BR2_TARGET_OPTEE_OS):$(BR2_TARGET_OPTEE_OS_LATEST),y:)
 BR_NO_CHECK_HASH_FOR += $(OPTEE_OS_SOURCE)
 endif
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 20/33] package/busybox: fix typo on BR2_PACKAGE_NETCAT_OPENBSD

[Ricardo Martincoski]

The typo was added in 2018 by commit
'f3da9ffff0 package/busybox: invert dependency with netcat-openbsd'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/busybox/busybox.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index 3e49de0a84..920f55c7fc 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -48,7 +48,7 @@ BUSYBOX_DEPENDENCIES = \
 	$(if $(BR2_PACKAGE_MTD),mtd) \
 	$(if $(BR2_PACKAGE_NET_TOOLS),net-tools) \
 	$(if $(BR2_PACKAGE_NETCAT),netcat) \
-	$(if $(BR2_PACKAGE_NETCAT_OPENSBSD),netcat-openbsd) \
+	$(if $(BR2_PACKAGE_NETCAT_OPENBSD),netcat-openbsd) \
 	$(if $(BR2_PACKAGE_NMAP),nmap) \
 	$(if $(BR2_PACKAGE_NTP),ntp) \
 	$(if $(BR2_PACKAGE_PCIUTILS),pciutils) \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 20/33] package/busybox: fix typo on BR2_PACKAGE_NETCAT_OPENBSD

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added in 2018 by commit
 > 'f3da9ffff0 package/busybox: invert dependency with netcat-openbsd'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 21/33] package/jquery-ui-themes: fix typo on BR2_PACKAGE_JQUERY_UI_THEMES_VADER

[Ricardo Martincoski]

The typo was added in 2018 by commit
'94c146282f jquery-ui-themes: rename options to have proper prefix'

Cc: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/jquery-ui-themes/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/jquery-ui-themes/Config.in b/package/jquery-ui-themes/Config.in
index 29359544ac..b372d40b60 100644
--- a/package/jquery-ui-themes/Config.in
+++ b/package/jquery-ui-themes/Config.in
@@ -112,6 +112,6 @@ config BR2_PACKAGE_JQUERY_UI_THEMES_THEME
 	default "trontastic"		if BR2_PACKAGE_JQUERY_UI_THEMES_TRONTASTIC
 	default "ui-darkness"		if BR2_PACKAGE_JQUERY_UI_THEMES_UI_DARKNESS
 	default "ui-lightness"		if BR2_PACKAGE_JQUERY_UI_THEMES_UI_LIGHTNESS
-	default "vader"			if BR2_PACKAGE_JQUERY_UI_THEMES_UI_VADER
+	default "vader"			if BR2_PACKAGE_JQUERY_UI_THEMES_VADER
 
 endif
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 21/33] package/jquery-ui-themes: fix typo on BR2_PACKAGE_JQUERY_UI_THEMES_VADER

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added in 2018 by commit
 > '94c146282f jquery-ui-themes: rename options to have proper prefix'

 > Cc: Simon Dawson <spdawson@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 22/33] package/gstreamer1/gst1-plugins-bad: fix typo on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS

[Ricardo Martincoski]

The typo was added by commit 'bad657ddfc openal: fix atomic handling' from
2016.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/gstreamer1/gst1-plugins-bad/Config.in b/package/gstreamer1/gst1-plugins-bad/Config.in
index cd5a2c7b11..bcb4cb1545 100644
--- a/package/gstreamer1/gst1-plugins-bad/Config.in
+++ b/package/gstreamer1/gst1-plugins-bad/Config.in
@@ -527,11 +527,11 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPENAL
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
-	depends on BR2_PAKCAGE_OPENAL_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
 	select BR2_PACKAGE_OPENAL
 
 comment "openal plugin needs a toolchain w/ NPTL, C++, gcc >= 4.9"
-	depends on BR2_PAKCAGE_OPENAL_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL \
 		|| !BR2_INSTALL_LIBSTDCPP \
 		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 22/33] package/gstreamer1/gst1-plugins-bad: fix typo on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added by commit 'bad657ddfc openal: fix atomic handling' from
 > 2016.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 23/33] package/pcsc-lite: fix typo on BR2_PACKAGE_PCSC_LITE_*

[Ricardo Martincoski]

The typo was added in 2012 by commit
'8c345d91cf pcsc-lite: new package'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/pcsc-lite/pcsc-lite.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
index d007d8da2f..34950dd866 100644
--- a/package/pcsc-lite/pcsc-lite.mk
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -37,11 +37,11 @@ else
 PCSC_LITE_CONF_OPTS += --disable-libsystemd
 endif
 
-ifeq ($(PACKAGE_PCSC_LITE_DEBUGATR),y)
+ifeq ($(BR2_PACKAGE_PCSC_LITE_DEBUGATR),y)
 PCSC_LITE_CONF_OPTS += --enable-debugatr
 endif
 
-ifeq ($(PACKAGE_PCSC_LITE_EMBEDDED),y)
+ifeq ($(BR2_PACKAGE_PCSC_LITE_EMBEDDED),y)
 PCSC_LITE_CONF_OPTS += --enable-embedded
 endif
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 23/33] package/pcsc-lite: fix typo on BR2_PACKAGE_PCSC_LITE_*

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The typo was added in 2012 by commit
 > '8c345d91cf pcsc-lite: new package'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 24/33] package/zeek: drop bogus PYTHON3_HASHLIB

[Ricardo Martincoski]

Package python3-hashlib does not exist in the tree.
So drop the reference to it added by commit:
'ea36681572 package/zeek: new package'

Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/zeek/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/zeek/Config.in b/package/zeek/Config.in
index 123fedb339..f2a769621f 100644
--- a/package/zeek/Config.in
+++ b/package/zeek/Config.in
@@ -26,7 +26,6 @@ config BR2_PACKAGE_ZEEK_ZEEKCTL
 	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
 	select BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_PYTHON3_CURSES
-	select BR2_PACKAGE_PYTHON3_HASHLIB
 	select BR2_PACKAGE_PYTHON3_SQLITE
 	select BR2_PACKAGE_PYTHON3_ZLIB
 	help
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 25/33] package/cups: drop bogus libpaper dependency

[Ricardo Martincoski]

The inexistent package libpaper is referenced since 2016, from commit:
'd37ce8e1a4 package/cups: Un-deprecate, and update CUPS to 2.1.2'

Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Cc: Olivier Schonken <olivier.schonken@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/cups/cups.mk | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/package/cups/cups.mk b/package/cups/cups.mk
index 2bd5f3bbb6..fed2aa809f 100644
--- a/package/cups/cups.mk
+++ b/package/cups/cups.mk
@@ -27,6 +27,7 @@ CUPS_CONF_OPTS = \
 	--with-cups-user=lp \
 	--with-cups-group=lp \
 	--with-system-groups="lpadmin sys root" \
+	--disable-libpaper \
 	--without-rcdir
 CUPS_CONFIG_SCRIPTS = cups-config
 CUPS_DEPENDENCIES = \
@@ -63,13 +64,6 @@ else
 CUPS_CONF_OPTS += --disable-libusb
 endif
 
-ifeq ($(BR2_PACKAGE_LIBPAPER),y)
-CUPS_CONF_OPTS += --enable-libpaper
-CUPS_DEPENDENCIES += libpaper
-else
-CUPS_CONF_OPTS += --disable-libpaper
-endif
-
 ifeq ($(BR2_PACKAGE_AVAHI),y)
 CUPS_DEPENDENCIES += avahi
 CUPS_CONF_OPTS += --enable-avahi
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 25/33] package/cups: drop bogus libpaper dependency

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The inexistent package libpaper is referenced since 2016, from commit:
 > 'd37ce8e1a4 package/cups: Un-deprecate, and update CUPS to 2.1.2'

 > Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>
 > Cc: Olivier Schonken <olivier.schonken@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 26/33] package/ranger: drop bogus BR2_PACKAGE_PYTHON_PYC_ONLY

[Ricardo Martincoski]

The symbol was removed in commit:
'306839586b package/python: drop target package'

Cc: Thijs Vermeir <thijsvermeir@gmail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/ranger/ranger.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ranger/ranger.mk b/package/ranger/ranger.mk
index aaca43862c..91b30f216e 100644
--- a/package/ranger/ranger.mk
+++ b/package/ranger/ranger.mk
@@ -19,7 +19,7 @@ define RANGER_DO_NOT_GENERATE_BYTECODE_AT_RUNTIME
 	$(SED) 's%/usr/bin/python -O%/usr/bin/python%g' $(@D)/scripts/ranger
 endef
 
-ifeq ($(BR2_PACKAGE_PYTHON3_PYC_ONLY)$(BR2_PACKAGE_PYTHON_PYC_ONLY),y)
+ifeq ($(BR2_PACKAGE_PYTHON3_PYC_ONLY),y)
 RANGER_POST_PATCH_HOOKS += RANGER_DO_NOT_GENERATE_BYTECODE_AT_RUNTIME
 endif
 
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 26/33] package/ranger: drop bogus BR2_PACKAGE_PYTHON_PYC_ONLY

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The symbol was removed in commit:
 > '306839586b package/python: drop target package'

 > Cc: Thijs Vermeir <thijsvermeir@gmail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 27/33] package/openocd: drop bogus BR2_PACKAGE_OPENOCD_ZY1000*

[Ricardo Martincoski]

These inexistent symbols are referenced since 2014, from commit:
'aa441aa84c openocd: bump to version 0.8.0'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/openocd/openocd.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
index 9f53ae3ee3..37a06ca848 100644
--- a/package/openocd/openocd.mk
+++ b/package/openocd/openocd.mk
@@ -56,8 +56,6 @@ OPENOCD_CONF_OPTS += \
 	$(if $(BR2_PACKAGE_OPENOCD_VPI),--enable-jtag_vpi,--disable-jtag_vpi) \
 	$(if $(BR2_PACKAGE_OPENOCD_UBLASTER),--enable-usb-blaster,--disable-usb-blaster) \
 	$(if $(BR2_PACKAGE_OPENOCD_AMTJT),--enable-amtjtagaccel,--disable-amjtagaccel) \
-	$(if $(BR2_PACKAGE_OPENOCD_ZY1000_MASTER),--enable-zy1000-master,--disable-zy1000-master) \
-	$(if $(BR2_PACKAGE_OPENOCD_ZY1000),--enable-zy1000,--disable-zy1000) \
 	$(if $(BR2_PACKAGE_OPENOCD_EP93XX),--enable-ep93xx,--disable-ep93xx) \
 	$(if $(BR2_PACKAGE_OPENOCD_AT91RM),--enable-at91rm9200,--disable-at91rm9200) \
 	$(if $(BR2_PACKAGE_OPENOCD_BCM2835),--enable-bcm2835gpio,--disable-bcm2835gpio) \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 27/33] package/openocd: drop bogus BR2_PACKAGE_OPENOCD_ZY1000*

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > These inexistent symbols are referenced since 2014, from commit:
 > 'aa441aa84c openocd: bump to version 0.8.0'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 28/33] package/directfb: drop bogus BR2_PACKAGE_DIRECTFB_CYBER5K

[Ricardo Martincoski]

The inexistent symbol is reference since 2008, see commit '8a12bab608
widen options to configure directfb, patch by Micha Nelissen
<micha@neli.hopto.org>'

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/directfb/directfb.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index 56a396ab99..094e87e7e7 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -67,7 +67,6 @@ endif
 
 DIRECTFB_GFX = \
 	$(if $(BR2_PACKAGE_DIRECTFB_ATI128),ati128) \
-	$(if $(BR2_PACKAGE_DIRECTFB_CYBER5K),cyber5k) \
 	$(if $(BR2_PACKAGE_DIRECTFB_MATROX),matrox) \
 	$(if $(BR2_PACKAGE_DIRECTFB_PXA3XX),pxa3xx) \
 	$(if $(BR2_PACKAGE_DIRECTFB_I830),i830) \
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 28/33] package/directfb: drop bogus BR2_PACKAGE_DIRECTFB_CYBER5K

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The inexistent symbol is reference since 2008, see commit '8a12bab608
 > widen options to configure directfb, patch by Micha Nelissen
 > <micha@neli.hopto.org>'

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 29/33] package/x11r7/xserver_xorg-server: drop bogus BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS

[Ricardo Martincoski]

Commit '09729b5e63 xserver_xorg-server: bump version, improve option
support' from 2010 removed the symbol but forgot to drop references to
it.

Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/x11r7/xserver_xorg-server/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in
index daf4d81702..865917c4ec 100644
--- a/package/x11r7/xserver_xorg-server/Config.in
+++ b/package/x11r7/xserver_xorg-server/Config.in
@@ -12,9 +12,9 @@ config BR2_PACKAGE_XSERVER_XORG_SERVER
 	select BR2_PACKAGE_LIBSHA1 if (!BR2_PACKAGE_OPENSSL && !BR2_PACKAGE_LIBGCRYPT)
 	select BR2_PACKAGE_MCOOKIE
 	select BR2_PACKAGE_PIXMAN
-	select BR2_PACKAGE_XFONT_FONT_ALIAS if !BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS
-	select BR2_PACKAGE_XFONT_FONT_MISC_MISC if !BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS
-	select BR2_PACKAGE_XFONT_FONT_CURSOR_MISC if !BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS
+	select BR2_PACKAGE_XFONT_FONT_ALIAS
+	select BR2_PACKAGE_XFONT_FONT_MISC_MISC
+	select BR2_PACKAGE_XFONT_FONT_CURSOR_MISC
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXAU
 	select BR2_PACKAGE_XLIB_LIBXCURSOR
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 29/33] package/x11r7/xserver_xorg-server: drop bogus BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > Commit '09729b5e63 xserver_xorg-server: bump version, improve option
 > support' from 2010 removed the symbol but forgot to drop references to
 > it.

 > Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 30/33] package/gstreamer1/gst1-plugins-good: drop bogus BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB

[Ricardo Martincoski]

Commit 'dc7ca780a0 package/gstreamer1/gst1-plugins-good: convert package
type to meson' from 2019 removed the symbol, stating:
  Remove BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB
  Existing configs will already have BR2_PACKAGE_ZLIB selected, so no
  legacy entry is needed for BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB

So drop the reference to the symbol.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index 61ffc7b989..de7dcb985d 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -480,10 +480,6 @@ else
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dwavpack=disabled
 endif
 
-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB),y)
-GST1_PLUGINS_GOOD_DEPENDENCIES += zlib
-endif
-
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_BZ2),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += -Dbz2=enabled
 GST1_PLUGINS_GOOD_DEPENDENCIES += bzip2
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 30/33] package/gstreamer1/gst1-plugins-good: drop bogus BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > Commit 'dc7ca780a0 package/gstreamer1/gst1-plugins-good: convert package
 > type to meson' from 2019 removed the symbol, stating:
 >   Remove BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB
 >   Existing configs will already have BR2_PACKAGE_ZLIB selected, so no
 >   legacy entry is needed for BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB

 > So drop the reference to the symbol.

 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 31/33] package/libsepol: drop bogus BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6

[Ricardo Martincoski]

The inexistent symbol is reference since this commit from 2020:
'55784bcbfa package/libsepol: set default policy version'

Cc: Clayton Shotwell <clayton.shotwell@collins.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Matt Weber <matthew.weber@collins.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/libsepol/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/libsepol/Config.in b/package/libsepol/Config.in
index 7516076cd5..5dfd1a41d3 100644
--- a/package/libsepol/Config.in
+++ b/package/libsepol/Config.in
@@ -18,7 +18,6 @@ config BR2_PACKAGE_LIBSEPOL_POLICY_VERSION
 	default 30 if BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3
 	default 29 if BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14
 	default 28 if BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5
-	default 26 if BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6
 	default 25
 	help
 	  The maximum SELinux policy version your kernel supports.
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 31/33] package/libsepol: drop bogus BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The inexistent symbol is reference since this commit from 2020:
 > '55784bcbfa package/libsepol: set default policy version'

 > Cc: Clayton Shotwell <clayton.shotwell@collins.com>
 > Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
 > Cc: Matt Weber <matthew.weber@collins.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 32/33] package/python-pygame: drop bogus BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC

[Ricardo Martincoski]

The symbol does not configure anything, so drop it.
It was added in 2012 by commit 'dda08e492d Add pygame package'

Cc: Asaf Kahlon <asafka7@gmail.com>
Cc: Julien Boibessot <julien.boibessot@armadeus.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
 package/python-pygame/Config.in | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/python-pygame/Config.in b/package/python-pygame/Config.in
index 0a738527ea..57eb020742 100644
--- a/package/python-pygame/Config.in
+++ b/package/python-pygame/Config.in
@@ -41,12 +41,6 @@ config BR2_PACKAGE_PYTHON_PYGAME_MIXER
 	  pygame module for loading and playing sounds.
 	  Will autoselect sdl_mixer.
 
-config BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC
-	bool "pygame.mixer.music"
-	depends on BR2_PACKAGE_PYTHON_PYGAME_MIXER
-	help
-	  pygame module for controlling streamed audio
-
 config BR2_PACKAGE_PYTHON_PYGAME_SCRAP
 	bool "pygame.scrap"
 	depends on BR2_PACKAGE_SDL_X11
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 32/33] package/python-pygame: drop bogus BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC

[Peter Korsgaard]

>>>>> "Ricardo" == Ricardo Martincoski <ricardo.martincoski@gmail.com> writes:

 > The symbol does not configure anything, so drop it.
 > It was added in 2012 by commit 'dda08e492d Add pygame package'

 > Cc: Asaf Kahlon <asafka7@gmail.com>
 > Cc: Julien Boibessot <julien.boibessot@armadeus.com>
 > Cc: Yegor Yefremov <yegorslists@googlemail.com>
 > Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>

Committed to 2022.05.x and 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 33/33] utils/check-symbols: new script

[Ricardo Martincoski]

This is just a WIP!
- it is ugly
- it was not designed for performance (speed, RAM usage, ...)
- it is poorly covered by unit tests
- it has no help/usage
- it has no debug options
- it uses a hand-made database
- it has a long list of false positives, ignored in the DB class
- it does not support yet:
  - rootfs
  - virtual packages
  - barebox
  - linux extensions

... but it gets some initial results

Someone willing to adopt this patch?

Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
https://gitlab.com/RicardoMartincoski/buildroot/-/pipelines/613336397

I don't know what to do with this symbol:
package/fwts/Config.in:config BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
package/fwts/fwts.mk:ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
maybe one of below?
1) make the script to accept 'ifdef' as a valid usage for a menuconfig symbol
2) rework the package to use 'ifeq' like the other ones.
---
 support/misc/gitlab-ci.yml.in          |   8 ++
 support/scripts/generate-gitlab-ci-yml |   2 +-
 utils/check-symbols                    |  50 ++++++++++
 utils/checksymbolslib/__init__.py      |   0
 utils/checksymbolslib/db.py            |  63 +++++++++++++
 utils/checksymbolslib/file.py          |  75 +++++++++++++++
 utils/checksymbolslib/kconfig.py       | 126 +++++++++++++++++++++++++
 utils/checksymbolslib/makefile.py      |  47 +++++++++
 utils/checksymbolslib/test_db.py       |  34 +++++++
 utils/checksymbolslib/test_file.py     |  61 ++++++++++++
 utils/checksymbolslib/test_kconfig.py  |  46 +++++++++
 11 files changed, 511 insertions(+), 1 deletion(-)
 create mode 100755 utils/check-symbols
 create mode 100644 utils/checksymbolslib/__init__.py
 create mode 100644 utils/checksymbolslib/db.py
 create mode 100644 utils/checksymbolslib/file.py
 create mode 100644 utils/checksymbolslib/kconfig.py
 create mode 100644 utils/checksymbolslib/makefile.py
 create mode 100644 utils/checksymbolslib/test_db.py
 create mode 100644 utils/checksymbolslib/test_file.py
 create mode 100644 utils/checksymbolslib/test_kconfig.py

diff --git a/support/misc/gitlab-ci.yml.in b/support/misc/gitlab-ci.yml.in
index 3ac988a519..0ccf36665e 100644
--- a/support/misc/gitlab-ci.yml.in
+++ b/support/misc/gitlab-ci.yml.in
@@ -2,6 +2,10 @@
     script:
         - python3 -m pytest -v utils/checkpackagelib/
 
+.check-check-symbol_base:
+    script:
+        - python3 -m pytest -v utils/checksymbolslib/
+
 .check-DEVELOPERS_base:
     script:
         - utils/get-developers -v
@@ -14,6 +18,10 @@
     script:
         - make check-package
 
+.check-symbol_base:
+    script:
+        - utils/check-symbols
+
 .defconfig_check:
     before_script:
         - DEFCONFIG_NAME=$(echo ${CI_JOB_NAME} | sed -e 's,_check$,,g')
diff --git a/support/scripts/generate-gitlab-ci-yml b/support/scripts/generate-gitlab-ci-yml
index aa43aac019..051b1b5382 100755
--- a/support/scripts/generate-gitlab-ci-yml
+++ b/support/scripts/generate-gitlab-ci-yml
@@ -26,7 +26,7 @@ gen_tests() {
     local do_basics do_defconfigs do_runtime do_testpkg
     local defconfigs_ext cfg tst
 
-    basics=( check-package DEVELOPERS flake8 package )
+    basics=( check-package check-symbol DEVELOPERS flake8 package symbol )
 
     defconfigs=( $(cd configs; LC_ALL=C ls -1 *_defconfig) )
 
diff --git a/utils/check-symbols b/utils/check-symbols
new file mode 100755
index 0000000000..bf55ba915b
--- /dev/null
+++ b/utils/check-symbols
@@ -0,0 +1,50 @@
+#!/usr/bin/env python3
+
+import os
+import sys
+
+import checksymbolslib.file
+from checksymbolslib.db import DB
+
+
+def change_current_dir():
+    base_dir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
+    os.chdir(base_dir)
+
+
+def get_full_db(files_to_process):
+    db = DB()
+    for f in files_to_process:
+        checksymbolslib.file.populate_db_from_file(db, f)
+    return db
+
+
+def print_symbols_without_usage(db):
+    no_usage = db.get_symbols_without_usage()
+    print('no usage ==========')
+    for s in no_usage:
+        print(s, str(no_usage[s]))
+    return len(no_usage)
+
+
+def print_symbols_without_definition(db):
+    no_definition = db.get_symbols_without_definition()
+    print('no definition ==========')
+    for s in no_definition:
+        print(s, str(no_definition[s]))
+    return len(no_definition)
+
+
+def __main__():
+    change_current_dir()
+    all_files = checksymbolslib.file.get_list_of_files_in_the_repo()
+    files_to_process = checksymbolslib.file.get_list_of_files_to_process(all_files)
+    db = get_full_db(files_to_process)
+    w1 = print_symbols_without_usage(db)
+    w2 = print_symbols_without_definition(db)
+    if w1 + w2 > 0:
+        sys.exit(1)
+
+
+if __name__ == '__main__':
+    __main__()
diff --git a/utils/checksymbolslib/__init__.py b/utils/checksymbolslib/__init__.py
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/utils/checksymbolslib/db.py b/utils/checksymbolslib/db.py
new file mode 100644
index 0000000000..71ee9c63ac
--- /dev/null
+++ b/utils/checksymbolslib/db.py
@@ -0,0 +1,63 @@
+class DB:
+    def __init__(self):
+        self.all_symbols = {}
+
+    def __str__(self):
+        return str(self.all_symbols)
+
+    def add_symbol_entry(self, symbol, filename, lineno, entry_type):
+        if symbol not in self.all_symbols:
+            self.all_symbols[symbol] = {}
+        if entry_type not in self.all_symbols[symbol]:
+            self.all_symbols[symbol][entry_type] = {}
+        if filename not in self.all_symbols[symbol][entry_type]:
+            self.all_symbols[symbol][entry_type][filename] = []
+        self.all_symbols[symbol][entry_type][filename].append(lineno)
+
+    def add_symbol_definition(self, symbol, filename, lineno):
+        self.add_symbol_entry(symbol, filename, lineno, 'definition')
+
+    def add_symbol_usage(self, symbol, filename, lineno):
+        self.add_symbol_entry(symbol, filename, lineno, 'usage')
+
+    def add_symbol_helper(self, symbol, filename, lineno):
+        self.add_symbol_entry(symbol, filename, lineno, 'helper')
+
+    def add_symbol_choice(self, symbol, filename, lineno):
+        self.add_symbol_entry(symbol, filename, lineno, 'choice')
+
+    def get_symbols_without_usage(self):
+        found_symbols = {}
+        for symbol in self.all_symbols:
+            if 'usage' not in self.all_symbols[symbol]:
+                if 'helper' in self.all_symbols[symbol]:
+                    continue
+                if 'choice' in self.all_symbols[symbol]:
+                    continue
+                if symbol.startswith('BR2_ROOTFS_'):
+                    continue
+                if symbol in ['BR2_FORCE_HOST_BUILD', 'BR2_PACKAGE_SKELETON', 'BR2_TOOLCHAIN', 'BR2_PACKAGE_HOST_LINUX_HEADERS']:
+                    continue
+                if 'BR2_PACKAGE_PROVIDES_' in symbol:
+                    continue
+                if 'BR2_PACKAGE_HAS_' in symbol:
+                    continue
+                found_symbols[symbol] = self.all_symbols[symbol]['definition']
+        return found_symbols
+
+    def get_symbols_without_definition(self):
+        found_symbols = {}
+        for symbol in self.all_symbols:
+            if 'definition' not in self.all_symbols[symbol]:
+                if 'HOST_' in symbol:
+                    continue
+                if symbol.startswith('BR2_EXTERNAL'):
+                    continue
+                if symbol.startswith('BR2_GRAPH'):
+                    continue
+                if symbol.startswith('BR2_TARGET_ROOTFS_'):
+                    continue
+                if symbol in ['BR2_VERSION_FULL', 'BR2_MAKE', 'BR2_TARGET_BAREBOX', 'BR2_INSTRUMENTATION_SCRIPTS']:
+                    continue
+                found_symbols[symbol] = self.all_symbols[symbol]['usage']
+        return found_symbols
diff --git a/utils/checksymbolslib/file.py b/utils/checksymbolslib/file.py
new file mode 100644
index 0000000000..77891f53de
--- /dev/null
+++ b/utils/checksymbolslib/file.py
@@ -0,0 +1,75 @@
+import re
+import subprocess
+
+import checksymbolslib.kconfig as kconfig
+import checksymbolslib.makefile as makefile
+
+
+file_types = [
+    kconfig,
+    makefile,
+]
+
+
+def get_list_of_files_in_the_repo():
+    cmd = ['git', 'ls-files']
+    p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    stdout = p.communicate()[0]
+    processed_output = [str(line.decode().rstrip()) for line in stdout.splitlines() if line]
+    return processed_output
+
+
+def get_list_of_files_to_process(all_files):
+    files_to_process = []
+    for f in all_files:
+        if f.startswith('support/testing/'):
+            continue
+        if f.startswith('boot/barebox/'):
+            continue
+        if f.startswith('fs/'):
+            continue
+        for t in file_types:
+            if t.check_filename(f):
+                files_to_process.append(f)
+    return files_to_process
+
+
+def cleanup_file_content(file_content_raw):
+    cleaned_up_content = []
+    continuation = False
+    last_line = None
+    first_lineno = None
+    for cur_lineno, cur_line in file_content_raw:
+        if continuation:
+            line = last_line + cur_line
+            lineno = first_lineno
+        else:
+            line = cur_line
+            lineno = cur_lineno
+        continuation = False
+        last_line = None
+        first_lineno = None
+        # remove comments
+        line = re.sub(r'^([^#]*)(#.*)$', r'\1', line)
+        # remove trailing space and indentation
+        line = line.rstrip()
+        if line.endswith('\\'):
+            continuation = True
+            # remove \
+            last_line = re.sub(r'\\', '', line)
+            first_lineno = lineno
+            continue
+        cleaned_up_content.append([lineno, line])
+    return cleaned_up_content
+
+
+def populate_db_from_file(db, filename):
+    file_content_raw = []
+    with open(filename, 'r', errors='surrogateescape') as f:
+        for lineno, text in enumerate(f.readlines()):
+            file_content_raw.append([lineno + 1, text])
+
+    file_content = cleanup_file_content(file_content_raw)
+    for t in file_types:
+        if t.check_filename(filename):
+            t.populate_db(db, filename, file_content)
diff --git a/utils/checksymbolslib/kconfig.py b/utils/checksymbolslib/kconfig.py
new file mode 100644
index 0000000000..baef571e0f
--- /dev/null
+++ b/utils/checksymbolslib/kconfig.py
@@ -0,0 +1,126 @@
+import re
+
+
+def handle_config_line(db, filename, lineno, line):
+    m = re.search(r'^\W*(menu|)config\W+(\w+)\W*$', line)
+    symbol = m.group(2)
+    db.add_symbol_definition(symbol, filename, lineno)
+
+
+def handle_default_line(db, filename, lineno, line):
+    symbols = re.findall(r'(BR2_\w+)', line)
+    for symbol in symbols:
+        db.add_symbol_usage(symbol, filename, lineno)
+
+
+def handle_depends_on_line(db, filename, lineno, line):
+    line = re.sub(r'[!|()&]', '', line)
+    line = re.sub(r'=\W*"\w*"', '', line)
+    line = re.sub(r'^\W*depends on\W', '', line)
+    symbols = line.split()
+    for symbol in symbols:
+        db.add_symbol_usage(symbol, filename, lineno)
+
+
+def handle_if_line(db, filename, lineno, line):
+    line = re.sub(r'[!|()&]', '', line)
+    line = re.sub(r'=\W*"\w*"', '', line)
+    line = re.sub(r'^\W*if\W', '', line)
+    symbols = line.split()
+    for symbol in symbols:
+        db.add_symbol_usage(symbol, filename, lineno)
+
+
+def handle_select_line(db, filename, lineno, line):
+    line = re.sub(r'[!|()&]', '', line)
+    line = re.sub(r'=\W*"\w*"', '', line)
+    line = re.sub(r'^\W*select\W', '', line)
+    line = re.sub(r'\bif\W', '', line)
+    symbols = line.split()
+    for symbol in symbols:
+        db.add_symbol_usage(symbol, filename, lineno)
+
+
+def handle_source_line(db, filename, lineno, line):
+    symbols = re.findall(r'\$(BR2_\w+)', line)
+    for symbol in symbols:
+        db.add_symbol_usage(symbol, filename, lineno)
+
+
+def handle_line(db, filename, lineno, line):
+    line_type_handlers = {
+      r'^\w*(menu|)config\W': handle_config_line,
+      r'^\W*default\W': handle_default_line,
+      r'^\W*depends on\W': handle_depends_on_line,
+      r'^\W*if\W': handle_if_line,
+      r'^\W*select\W': handle_select_line,
+      r'^\W*source\W': handle_source_line,
+    }
+
+    if 'BR2_' not in line:
+        return
+
+    line_type = None
+    # determine line type
+    for possible_type in line_type_handlers.keys():
+        if re.search(possible_type, line):
+            line_type = possible_type
+    # process known line types
+    if line_type:
+        line_type_handlers[line_type](db, filename, lineno, line)
+
+
+def handle_config_helper(db, filename, file_content):
+    state = 'none'
+    symbol = None
+    for lineno, line in file_content:
+        if state == 'none':
+            m = re.search(r'^\W*config\W+(BR2_\w+)', line)
+            if m is None:
+                continue
+            symbol = m.group(1)
+            state = 'config'
+            continue
+        if state == 'config':
+            m = re.search(r'^\W*config\W+(BR2_\w+)', line)
+            if m is not None:
+                symbol = m.group(1)
+                continue
+            if re.search(r'^\t(help)\b', line):
+                state = 'none'
+                symbol = None
+                continue
+            if re.search(r'^\t(select)\b', line):
+                db.add_symbol_helper(symbol, filename, lineno)
+            continue
+
+
+def handle_config_choice(db, filename, file_content):
+    state = 'none'
+    for lineno, line in file_content:
+        if state == 'none':
+            if re.search(r'^\W*choice\W*$', line):
+                state = 'choice'
+                continue
+        if state == 'choice':
+            if re.search(r'^\W*endchoice\W*$', line):
+                state = 'none'
+                continue
+            m = re.search(r'^\W*config\W+(BR2_\w+)', line)
+            if m is not None:
+                symbol = m.group(1)
+                db.add_symbol_choice(symbol, filename, lineno)
+                continue
+
+
+def populate_db(db, filename, file_content):
+    for lineno, line in file_content:
+        handle_line(db, filename, lineno, line)
+    handle_config_helper(db, filename, file_content)
+    handle_config_choice(db, filename, file_content)
+
+
+def check_filename(filename):
+    if 'Config.' in filename:
+        return True
+    return False
diff --git a/utils/checksymbolslib/makefile.py b/utils/checksymbolslib/makefile.py
new file mode 100644
index 0000000000..51cf238bdd
--- /dev/null
+++ b/utils/checksymbolslib/makefile.py
@@ -0,0 +1,47 @@
+import os
+import re
+
+
+def populate_db(db, filename, file_content):
+    for lineno, line in file_content:
+        if line.startswith('$(eval') and line.endswith('-package))'):
+            if filename.startswith('linux/'):
+                continue
+            if '$(virtual-' in line:
+                continue
+            if '$(toolchain-' in line:
+                prefix = 'BR2_'
+            elif filename.startswith('boot/'):
+                prefix = 'BR2_TARGET_'
+            elif '$(host-' in line:
+                prefix = 'BR2_PACKAGE_HOST_'
+            else:
+                prefix = 'BR2_PACKAGE_'
+            package = os.path.basename(filename)[:-3].upper().replace('-', '_')
+            symbol = prefix + package
+            db.add_symbol_usage(symbol, filename, lineno)
+            continue
+        if '$(BR2_' in line:
+            symbols = re.findall(r'\$\((BR2_\w+)\)', line)
+            for symbol in symbols:
+                db.add_symbol_usage(symbol, filename, lineno)
+            continue
+        if line.startswith('BR2_'):
+            if '=' not in line:
+                continue
+            symbols = re.findall(r'(BR2_\w+)\W*[:=]', line)
+            for symbol in symbols:
+                db.add_symbol_definition(symbol, filename, lineno)
+            continue
+
+
+def check_filename(filename):
+    if filename.endswith('.mk'):
+        return True
+    if filename.endswith('.mk.in'):
+        return True
+    if filename.startswith('arch/arch.mk.'):
+        return True
+    if filename in ['Makefile', 'package/Makefile.in']:
+        return True
+    return False
diff --git a/utils/checksymbolslib/test_db.py b/utils/checksymbolslib/test_db.py
new file mode 100644
index 0000000000..9f34435e7a
--- /dev/null
+++ b/utils/checksymbolslib/test_db.py
@@ -0,0 +1,34 @@
+import checksymbolslib.db as m
+
+
+def test_empty_db():
+    db = m.DB()
+    assert str(db) == '{}'
+
+
+def test_one_definition():
+    db = m.DB()
+    db.add_symbol_definition('BR2_foo', 'foo/Config.in', 7)
+    assert str(db) == str({
+        'BR2_foo': {'definition': {'foo/Config.in': [7]}}
+        })
+
+
+def test_three_definitions():
+    db = m.DB()
+    db.add_symbol_definition('BR2_foo', 'foo/Config.in', 7)
+    db.add_symbol_definition('BR2_foo', 'foo/Config.in', 9)
+    db.add_symbol_definition('BR2_bar', 'bar/Config.in', 5)
+    assert str(db) == str({
+        'BR2_foo': {'definition': {'foo/Config.in': [7, 9]}},
+        'BR2_bar': {'definition': {'bar/Config.in': [5]}}
+        })
+
+
+def test_definition_and_usage():
+    db = m.DB()
+    db.add_symbol_definition('BR2_foo', 'foo/Config.in', 7)
+    db.add_symbol_usage('BR2_foo', 'foo/Config.in', 9)
+    assert str(db) == str({
+        'BR2_foo': {'definition': {'foo/Config.in': [7]}, 'usage': {'foo/Config.in': [9]}}
+        })
diff --git a/utils/checksymbolslib/test_file.py b/utils/checksymbolslib/test_file.py
new file mode 100644
index 0000000000..8b4067bb8f
--- /dev/null
+++ b/utils/checksymbolslib/test_file.py
@@ -0,0 +1,61 @@
+import pytest
+import checksymbolslib.file as m
+
+
+def test_get_list_of_files_in_the_repo():
+    all_files = m.get_list_of_files_in_the_repo()
+    assert 'Makefile' in all_files
+    assert 'package/Config.in' in all_files
+
+
+def test_get_list_of_files_to_process_unknown_file_type():
+    all_files = ['a/file/Config.in', 'another/file.mk', 'unknown/file/type']
+    files_to_process = m.get_list_of_files_to_process(all_files)
+    assert ['a/file/Config.in', 'another/file.mk'] == files_to_process
+
+
+def test_get_list_of_files_to_process_runtime_test_infra_fixtures():
+    all_files = ['a/file/Config.in', 'support/testing/a/broken/Config.in', 'another/file.mk']
+    files_to_process = m.get_list_of_files_to_process(all_files)
+    assert ['a/file/Config.in', 'another/file.mk'] == files_to_process
+
+
+cleanup_file_content = [
+    ('empty file',
+     [],
+     []),
+    ('empty line',
+     [[5, '\n']],
+     [[5, '']]),
+    ('trailing space',
+     [[3, '    \n']],
+     [[3, '']]),
+    ('trailing tab',
+     [[3, '\t\n']],
+     [[3, '']]),
+    ('remove comment',
+     [[1, 'foo # very useful comment\n']],
+     [[1, 'foo']]),
+    ('1 continuation',
+     [[1, 'foo \\\n'],
+      [2, 'bar\n']],
+     [[1, 'foo bar']]),
+    ('2 continuations',
+     [[1, 'foo \\\n'],
+      [2, 'bar  \\\n'],
+      [3, 'baz\n']],
+     [[1, 'foo bar  baz']]),
+    ('remove long comments',
+     [[1, '#' * 80 + '\n'],
+      [2, '#' * 80 + '\n'],
+      [3, '\ttext\n']],
+     [[1, ''],
+      [2, ''],
+      [3, '\ttext']]),
+    ]
+
+
+@pytest.mark.parametrize('testname,file_content_raw,expected', cleanup_file_content)
+def test_cleanup_file_content(testname, file_content_raw, expected):
+    cleaned_up_content = m.cleanup_file_content(file_content_raw)
+    assert cleaned_up_content == expected
diff --git a/utils/checksymbolslib/test_kconfig.py b/utils/checksymbolslib/test_kconfig.py
new file mode 100644
index 0000000000..ec43806b7e
--- /dev/null
+++ b/utils/checksymbolslib/test_kconfig.py
@@ -0,0 +1,46 @@
+import pytest
+from unittest.mock import Mock
+from unittest.mock import call
+import checksymbolslib.kconfig as m
+
+
+def test_handle_config_line_config():
+    db = Mock()
+    m.handle_config_line(db, 'Config.in', 5, 'config BR2_FOO')
+    db.add_symbol_definition.assert_called_with('BR2_FOO', 'Config.in', 5)
+
+
+def test_handle_config_line_menuconfig():
+    db = Mock()
+    m.handle_config_line(db, 'Config.in', 7, 'menuconfig BR2_FOO')
+    db.add_symbol_definition.assert_called_with('BR2_FOO', 'Config.in', 7)
+
+
+handle_default_line = [
+    ('with comparison',
+     'package/uboot-tools/Config.in.host',
+     105,
+     '\tdefault BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE if BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE != ""',
+     [call('BR2_TARGET_UBOOT_BOOT_SCRIPT_SOURCE', 'package/uboot-tools/Config.in.host', 105)]),
+    ('with logical operators',
+     'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options',
+     47,
+     '\tdefault y if BR2_i386 && !BR2_x86_i486 && !BR2_x86_i586 && !BR2_x86_x1000 && !BR2_x86_pentium_mmx && !BR2_x86_geode '
+     '&& !BR2_x86_c3 && !BR2_x86_winchip_c6 && !BR2_x86_winchip2',
+     [call('BR2_i386', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_c3', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_geode', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_i486', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_i586', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_pentium_mmx', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_winchip2', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_winchip_c6', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47),
+      call('BR2_x86_x1000', 'toolchain/toolchain-external/toolchain-external-bootlin/Config.in.options', 47)]),
+    ]
+
+
+@pytest.mark.parametrize('testname,filename,lineno,line,expected_calls', handle_default_line)
+def test_handle_default_line(testname, filename, lineno, line, expected_calls):
+    db = Mock()
+    m.handle_default_line(db, filename, lineno, line)
+    db.add_symbol_usage.assert_has_calls(expected_calls, any_order=True)
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 33/33] utils/check-symbols: new script

[Thomas Petazzoni via buildroot]

Hello Ricardo,

On Sun, 14 Aug 2022 20:38:45 -0300
Ricardo Martincoski <ricardo.martincoski@gmail.com> wrote:

> This is just a WIP!
> - it is ugly
> - it was not designed for performance (speed, RAM usage, ...)
> - it is poorly covered by unit tests
> - it has no help/usage
> - it has no debug options
> - it uses a hand-made database
> - it has a long list of false positives, ignored in the DB class
> - it does not support yet:
>   - rootfs
>   - virtual packages
>   - barebox
>   - linux extensions
> 
> ... but it gets some initial results
> 
> Someone willing to adopt this patch?

Does this imply that you are not interested/willing to push this
further up to a point where it can be merged?

> I don't know what to do with this symbol:
> package/fwts/Config.in:config BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
> package/fwts/fwts.mk:ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
> maybe one of below?
> 1) make the script to accept 'ifdef' as a valid usage for a menuconfig symbol
> 2) rework the package to use 'ifeq' like the other ones.

I would say convert to ifeq. However, there is something a bit
"special" done here:

ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
FWTS_MODULE_SUBDIRS = efi_runtime
$(eval $(kernel-module))
endif

i.e the eval kernel-module is done within the condition. Is this the
reason for using ifdef instead of ifeq? I don't really see why, but
maybe I'm missing some aspect of GNU make sorcery. Which is why is in
Cc of this e-mail :-)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 33/33] utils/check-symbols: new script

[Arnout Vandecappelle]

On 15/08/2022 11:33, Thomas Petazzoni via buildroot wrote:
> Hello Ricardo,
> 
> On Sun, 14 Aug 2022 20:38:45 -0300
> Ricardo Martincoski <ricardo.martincoski@gmail.com> wrote:
> 
>> This is just a WIP!
>> - it is ugly
>> - it was not designed for performance (speed, RAM usage, ...)
>> - it is poorly covered by unit tests
>> - it has no help/usage
>> - it has no debug options
>> - it uses a hand-made database
>> - it has a long list of false positives, ignored in the DB class
>> - it does not support yet:
>>    - rootfs
>>    - virtual packages
>>    - barebox
>>    - linux extensions
>>
>> ... but it gets some initial results
>>
>> Someone willing to adopt this patch?
> 
> Does this imply that you are not interested/willing to push this
> further up to a point where it can be merged?
> 
>> I don't know what to do with this symbol:
>> package/fwts/Config.in:config BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
>> package/fwts/fwts.mk:ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
>> maybe one of below?
>> 1) make the script to accept 'ifdef' as a valid usage for a menuconfig symbol
>> 2) rework the package to use 'ifeq' like the other ones.
> 
> I would say convert to ifeq. However, there is something a bit
> "special" done here:
> 
> ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
> FWTS_MODULE_SUBDIRS = efi_runtime
> $(eval $(kernel-module))
> endif
> 
> i.e the eval kernel-module is done within the condition. Is this the
> reason for using ifdef instead of ifeq? I don't really see why, but
> maybe I'm missing some aspect of GNU make sorcery. Which is why is in
> Cc of this e-mail :-)

  I don't know if I'm the missing name in the "why ... is in Cc", but I'll reply 
anyway :-)

  The difference between ifeq and ifdef is that ifdef doesn't expand 
recursively. So if we would have:

BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE = $(if ....)
ifdef BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
...
endif

then it would always be included, even if the $(if ...) expands to nothing.

However, that is not at all the case here, so the ifdef can safely be replaced 
with ifeq.

  In fact, even most of the ifdefs in the infra can replaced with ifeq. But that 
would require just a little bit more thinking to be sure of it...

  Oh and there's another one in pugixml.mk.

  Regards,
  Arnout
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/33] fix typos

[Thomas Petazzoni via buildroot]

Hello Ricardo,

On Sun, 14 Aug 2022 20:38:12 -0300
Ricardo Martincoski <ricardo.martincoski@gmail.com> wrote:

> Ricardo Martincoski (33):
> 1) typos on help and internal variables, found by code inspection:
>   package/tclap: fix typo on help
>   package/ti-gfx: fix typo on help
>   package/gcnano-binaries: fix typo on help
>   package/ace: fix typo on variable names
> 2) for consistency:
>   package/c-capnproto: use space after depends on
>   package/kvm-unit-tests: do not use "select...if SYMBOL=y"
>   Config.in.legacy: add missing select
> 3) typos on symbols used by packages:
>   package/libvncserver: fix typo on BR2_nios2
>   package/libgpg-error: fix typo for BR2_aarch64_be
>   package/freeswitch: fix typo on BR2_powerpc64le
>   package/uclibc: drop old SPARC symbols
>   package/tcf-agent: drop bogus BR2_powerpcle
>   package/qemu: fix typo on STAGING_DIR
>   package/tesseract-ocr: fix typo on BR2_PACKAGE_TESSERACT_OCR_LANG_GER
>   package/wolftpm: fix typo on BR2_PACKAGE_WOLFTPM_NUVOTON
>   package/kodi: fix typo on BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11
>   package/sconeserver: fix typo on BR2_STATIC_LIBS
>   package/libglvnd: fix typo on BR2_PACKAGE_XORGPROTO
>   boot/optee-os: fix typo on BR2_TARGET_OPTEE_OS_LATEST
>   package/busybox: fix typo on BR2_PACKAGE_NETCAT_OPENBSD
>   package/jquery-ui-themes: fix typo on
>     BR2_PACKAGE_JQUERY_UI_THEMES_VADER
>   package/gstreamer1/gst1-plugins-bad: fix typo on
>     BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
>   package/pcsc-lite: fix typo on BR2_PACKAGE_PCSC_LITE_*
> 4) bogus symbols referenced by packages
>   package/zeek: drop bogus PYTHON3_HASHLIB
>   package/cups: drop bogus libpaper dependency
>   package/ranger: drop bogus BR2_PACKAGE_PYTHON_PYC_ONLY
>   package/openocd: drop bogus BR2_PACKAGE_OPENOCD_ZY1000*
>   package/directfb: drop bogus BR2_PACKAGE_DIRECTFB_CYBER5K
>   package/x11r7/xserver_xorg-server: drop bogus
>     BR2_PACKAGE_XSERVER_XORG_SERVER_BUILTIN_FONTS
>   package/gstreamer1/gst1-plugins-good: drop bogus
>     BR2_PACKAGE_GST1_PLUGINS_GOOD_ZLIB
>   package/libsepol: drop bogus BR2_TOOLCHAIN_HEADERS_AT_LEAST_2_6
>   package/python-pygame: drop bogus
>     BR2_PACKAGE_PYTHON_PYGAME_MIXER_MUSIC

Thanks a lot, this is amazing work! I have applied all those 32 patches
to the master branch.

Really great work!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot