Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
@ 2022-08-20 11:33 Fabrice Fontaine
  2022-08-21  9:49 ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Fabrice Fontaine @ 2022-08-20 11:33 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

Add a custom case to make sure that a random configuration with an empty
theme for jquery-ui-themes doesn't fail. It reverts to
BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.

Fixes:
 - http://autobuild.buildroot.org/results/b38f605795b1c60d8253313ce9478c4b1991d390

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 utils/genrandconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/utils/genrandconfig b/utils/genrandconfig
index 85db7ed1e9..9d2ed3f244 100755
--- a/utils/genrandconfig
+++ b/utils/genrandconfig
@@ -547,6 +547,11 @@ def fixup_config(sysinfo, configfile):
         if 'BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT=y\n' in configlines:
             return False
 
+    if 'BR2_PACKAGE_JQUERY_UI_THEMES=y\n' in configlines and \
+       'BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n' in configlines:
+        configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n')
+        configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n')
+
     if 'BR2_TARGET_OPENSBI=y\n' in configlines and \
        'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \
        'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
  2022-08-20 11:33 [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling Fabrice Fontaine
@ 2022-08-21  9:49 ` Yann E. MORIN
  2022-08-21 12:03   ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-08-21  9:49 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
> Add a custom case to make sure that a random configuration with an empty
> theme for jquery-ui-themes doesn't fail. It reverts to
> BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b38f605795b1c60d8253313ce9478c4b1991d390
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  utils/genrandconfig | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/utils/genrandconfig b/utils/genrandconfig
> index 85db7ed1e9..9d2ed3f244 100755
> --- a/utils/genrandconfig
> +++ b/utils/genrandconfig
> @@ -547,6 +547,11 @@ def fixup_config(sysinfo, configfile):
>          if 'BR2_ARCH_HAS_NO_TOOLCHAIN_BUILDROOT=y\n' in configlines:
>              return False
>  
> +    if 'BR2_PACKAGE_JQUERY_UI_THEMES=y\n' in configlines and \
> +       'BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n' in configlines:

I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
Indeed, it is filled from a choice, and unless there is a typo in one of
the config options, there are as many defaults for it as there are
entries in the choice...

And if you look at the .config file, there is actually something
selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
it is empty, it is not set at all!

So, the .config file is not correct.

So, I think the issue is about fixing genrandconfig to generate .config
files that are correct to begin with. Priobably, running "make
olddefconfig" before checking the configuration is required? At least,
when I do that localy, the .config now properly contains
BR2_PACKAGE_JQUERY_UI_THEMES_THEME="vader".

But wait, wait... We already run 'make olddefconfig'! What's going on
here?

Regards,
Yann E. MORIN.

> +        configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n')
> +        configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n')
> +
>      if 'BR2_TARGET_OPENSBI=y\n' in configlines and \
>         'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \
>         'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
  2022-08-21  9:49 ` Yann E. MORIN
@ 2022-08-21 12:03   ` Yann E. MORIN
  2022-08-23  9:30     ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-08-21 12:03 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

Fabrice, All,

On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
> On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
> > Add a custom case to make sure that a random configuration with an empty
> > theme for jquery-ui-themes doesn't fail. It reverts to
> > BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
[--SNIP--]
> I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
> Indeed, it is filled from a choice, and unless there is a typo in one of
> the config options, there are as many defaults for it as there are
> entries in the choice...
> 
> And if you look at the .config file, there is actually something
> selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
> indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
> it is empty, it is not set at all!
> 
> So, the .config file is not correct.

Note: there is a known issue, where choices are not randomised when
starting of a existing config fragment, like we actually do with
randpackageconfig, in which case the first entry in the choice is always
selected. But that case still yie;ds a correct .config, where
BR2_PACKAGE_JQUERY_UI_THEMES_THEME is indeed set. E.g.:

    $ make randconfig  # jquery has no depenency, so whatever config we get is OK
    $ make randpackageconfig
    # after a few iterations, you will end up with:

    $ grep JQUERY_UI_THEMES .config
    BR2_PACKAGE_JQUERY_UI_THEMES=y
    BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y
    [...]
    BR2_PACKAGE_JQUERY_UI_THEMES_THEME="black-tie"

So, for fun, I had the following snippet run:

    while true; do
        ./utils/genrandconfig 2>&1 |grep KCONFIG_SEED=
        if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
            echo 'Got JQuery UI themes...'
            grep BR2_PACKAGE_JQUERY_UI_THEMES_ .config
            grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
            || { echo 'Missing theme...'; break; }
        fi
    done

All I could eventually get was one instance of indeed non-randomised
choice:

    Got JQuery UI themes...
    BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y
    # BR2_PACKAGE_JQUERY_UI_THEMES_BLITZER is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_CUPERTINO is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_DARK_HIVE is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_DOT_LUV is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_EGGPLANT is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_EXCITE_BIKE is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_FLICK is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_HOT_SNEAKS is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_HUMANITY is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_LE_FROG is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_MINT_CHOC is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_OVERCAST is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_PEPPER_GRINDER is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_REDMOND is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_SMOOTHNESS is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_SOUTH_STREET is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_START is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_SUNNY is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_SWANKY_PURSE is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_TRONTASTIC is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_UI_DARKNESS is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_UI_LIGHTNESS is not set
    # BR2_PACKAGE_JQUERY_UI_THEMES_VADER is not set
    BR2_PACKAGE_JQUERY_UI_THEMES_THEME="black-tie"

Also, the script ran for more than two hours before I stopped it, and
jquery UI themes was seldom selectedonly two out of hundreds of
configurations had it... I've restarted it and will let it spin for a
while...

So, I am very puzzled as to why and how we would ever get an unset
BR2_PACKAGE_JQUERY_UI_THEMES_THEME...

Regards,
Yann E. MORIN.

> So, I think the issue is about fixing genrandconfig to generate .config
> files that are correct to begin with. Priobably, running "make
> olddefconfig" before checking the configuration is required? At least,
> when I do that localy, the .config now properly contains
> BR2_PACKAGE_JQUERY_UI_THEMES_THEME="vader".
> 
> But wait, wait... We already run 'make olddefconfig'! What's going on
> here?
> 
> Regards,
> Yann E. MORIN.
> 
> > +        configlines.append('BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE=y\n')
> > +        configlines.remove('BR2_PACKAGE_JQUERY_UI_THEMES_THEME=""\n')
> > +
> >      if 'BR2_TARGET_OPENSBI=y\n' in configlines and \
> >         'BR2_TARGET_OPENSBI_CUSTOM_GIT=y\n' in configlines and \
> >         'BR2_TARGET_OPENSBI_CUSTOM_REPO_URL=""\n' in configlines:
> > -- 
> > 2.35.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
  2022-08-21 12:03   ` Yann E. MORIN
@ 2022-08-23  9:30     ` Yann E. MORIN
  2022-08-23 20:14       ` Arnout Vandecappelle
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2022-08-23  9:30 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

Fabrice, All,

On 2022-08-21 14:03 +0200, Yann E. MORIN spake thusly:
> On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
> > On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
> > > Add a custom case to make sure that a random configuration with an empty
> > > theme for jquery-ui-themes doesn't fail. It reverts to
> > > BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
> [--SNIP--]
> > I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
> > Indeed, it is filled from a choice, and unless there is a typo in one of
> > the config options, there are as many defaults for it as there are
> > entries in the choice...
> > 
> > And if you look at the .config file, there is actually something
> > selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
> > indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
> > it is empty, it is not set at all!
> > 
> > So, the .config file is not correct.
[--SNIP--]
> So, for fun, I had the following snippet run:
>     while true; do
>         ./utils/genrandconfig 2>&1 |grep KCONFIG_SEED=
>         if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
>             echo 'Got JQuery UI themes...'
>             grep BR2_PACKAGE_JQUERY_UI_THEMES_ .config
>             grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
>             || { echo 'Missing theme...'; break; }
>         fi
>     done

This has now been running for almost 48 hours straight, and there has
been 10005 configs generated, 55 with BR2_PACKAGE_JQUERY_UI_THEMES
enabled, of which none with BR2_PACKAGE_JQUERY_UI_THEMES_THEME unset.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
  2022-08-23  9:30     ` Yann E. MORIN
@ 2022-08-23 20:14       ` Arnout Vandecappelle
  2022-08-24  9:32         ` Yann E. MORIN
  0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-08-23 20:14 UTC (permalink / raw)
  To: Yann E. MORIN, Fabrice Fontaine; +Cc: buildroot



On 23/08/2022 11:30, Yann E. MORIN wrote:
> Fabrice, All,
> 
> On 2022-08-21 14:03 +0200, Yann E. MORIN spake thusly:
>> On 2022-08-21 11:49 +0200, Yann E. MORIN spake thusly:
>>> On 2022-08-20 13:33 +0200, Fabrice Fontaine spake thusly:
>>>> Add a custom case to make sure that a random configuration with an empty
>>>> theme for jquery-ui-themes doesn't fail. It reverts to
>>>> BR2_PACKAGE_JQUERY_UI_THEMES_BLACK_TIE in that case.
>> [--SNIP--]
>>> I am not sure how we can end up with an empty BR2_PACKAGE_JQUERY_UI_THEMES_THEME.
>>> Indeed, it is filled from a choice, and unless there is a typo in one of
>>> the config options, there are as many defaults for it as there are
>>> entries in the choice...
>>>
>>> And if you look at the .config file, there is actually something
>>> selected in that choice, BR2_PACKAGE_JQUERY_UI_THEMES_VADER=y, but
>>> indeed BR2_PACKAGE_JQUERY_UI_THEMES_THEME is not even set. It's not that
>>> it is empty, it is not set at all!
>>>
>>> So, the .config file is not correct.
> [--SNIP--]
>> So, for fun, I had the following snippet run:
>>      while true; do
>>          ./utils/genrandconfig 2>&1 |grep KCONFIG_SEED=
>>          if grep -q BR2_PACKAGE_JQUERY_UI_THEMES=y .config; then
>>              echo 'Got JQuery UI themes...'
>>              grep BR2_PACKAGE_JQUERY_UI_THEMES_ .config
>>              grep -q BR2_PACKAGE_JQUERY_UI_THEMES_THEME= .config \
>>              || { echo 'Missing theme...'; break; }
>>          fi
>>      done
> 
> This has now been running for almost 48 hours straight, and there has
> been 10005 configs generated, 55 with BR2_PACKAGE_JQUERY_UI_THEMES
> enabled, of which none with BR2_PACKAGE_JQUERY_UI_THEMES_THEME unset.

  Isn't it simply fixed by commit f008c74061e604069d9716ac97d2a3f78c9f00b3 ? The 
autobuild failure didn't contain that commit yet.

  Patch marked as superseded.

  Regards,
  Arnout

> 
> Regards,
> Yann E. MORIN.
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling
  2022-08-23 20:14       ` Arnout Vandecappelle
@ 2022-08-24  9:32         ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2022-08-24  9:32 UTC (permalink / raw)
  To: Arnout Vandecappelle; +Cc: Fabrice Fontaine, buildroot

ARnout, All,

On 2022-08-23 22:14 +0200, Arnout Vandecappelle spake thusly:
> On 23/08/2022 11:30, Yann E. MORIN wrote:
[--SNIP--]
> >This has now been running for almost 48 hours straight, and there has
> >been 10005 configs generated, 55 with BR2_PACKAGE_JQUERY_UI_THEMES
> >enabled, of which none with BR2_PACKAGE_JQUERY_UI_THEMES_THEME unset.
>  Isn't it simply fixed by commit f008c74061e604069d9716ac97d2a3f78c9f00b3 ?
> The autobuild failure didn't contain that commit yet.

Damn. I only ever looked at the genrandconfig git log, and did not even
think about looking at the pacgae log. Sigh...

Thanks for the heads-up.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-24  9:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-20 11:33 [Buildroot] [PATCH 1/1] utils/genrandconfig: add jquery-ui-themes handling Fabrice Fontaine
2022-08-21  9:49 ` Yann E. MORIN
2022-08-21 12:03   ` Yann E. MORIN
2022-08-23  9:30     ` Yann E. MORIN
2022-08-23 20:14       ` Arnout Vandecappelle
2022-08-24  9:32         ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox