* [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support @ 2022-08-28 13:05 Dmitry Ilyin 2022-08-28 14:01 ` Yann E. MORIN 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Ilyin @ 2022-08-28 13:05 UTC (permalink / raw) To: buildroot; +Cc: Dmitry Ilyin, Fabrice Fontaine This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS builds that support SRTP (required option for AWS WebRTC library) --- package/mbedtls/Config.in | 6 ++++++ package/mbedtls/mbedtls.mk | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in index a39ba65d98..f06a27fc5c 100644 --- a/package/mbedtls/Config.in +++ b/package/mbedtls/Config.in @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION sure CRIME and similar attacks are not applicable to your particular situation. +config BR2_PACKAGE_MBEDTLS_SRTP + bool "enable SRTP support" + help + Enable support for negotiation of DTLS-SRTP (RFC 5764) + through the use_srtp extension. + endif diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk index af87d62b30..9f9aee1fec 100644 --- a/package/mbedtls/mbedtls.mk +++ b/package/mbedtls/mbedtls.mk @@ -72,4 +72,12 @@ else ifeq ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y) MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM endif +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y) +define MBEDTLS_ENABLE_SRTP + $(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define MBEDTLS_SSL_DTLS_SRTP:" \ + $(@D)/include/mbedtls/config.h +endef +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP +endif + $(eval $(cmake-package)) -- 2.37.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support 2022-08-28 13:05 [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support Dmitry Ilyin @ 2022-08-28 14:01 ` Yann E. MORIN 2022-08-28 14:36 ` Dmitry Ilyin 0 siblings, 1 reply; 5+ messages in thread From: Yann E. MORIN @ 2022-08-28 14:01 UTC (permalink / raw) To: Dmitry Ilyin; +Cc: Fabrice Fontaine, buildroot Dmitry, All, On 2022-08-28 16:05 +0300, Dmitry Ilyin spake thusly: > This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS > builds that support SRTP (required option for AWS WebRTC library) You need to sign-off your change: https://buildroot.org/downloads/manual/manual.html#submitting-patches Also, what do you mean by "required option for AWS WebRTC library"? If you are referring to a package that is present in Buildroot, then that package should also be fixed to select that option. The only package I could find in Buildroot, that is both websocket-related and uses mbedtls, is package/libwebsockets/. If that's what you were refering to, then the conditin to use mbedtls should be changed (in a separate, follow-up patch): -else ifeq ($(BR2_PACKAGE_MBEDTLS),y) +else ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP),y) Regards, Yann E. MORIN. > --- > package/mbedtls/Config.in | 6 ++++++ > package/mbedtls/mbedtls.mk | 8 ++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in > index a39ba65d98..f06a27fc5c 100644 > --- a/package/mbedtls/Config.in > +++ b/package/mbedtls/Config.in > @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION > sure CRIME and similar attacks are not applicable to your > particular situation. > > +config BR2_PACKAGE_MBEDTLS_SRTP > + bool "enable SRTP support" > + help > + Enable support for negotiation of DTLS-SRTP (RFC 5764) > + through the use_srtp extension. > + > endif > diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk > index af87d62b30..9f9aee1fec 100644 > --- a/package/mbedtls/mbedtls.mk > +++ b/package/mbedtls/mbedtls.mk > @@ -72,4 +72,12 @@ else ifeq ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y) > MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM > endif > > +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y) > +define MBEDTLS_ENABLE_SRTP > + $(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define MBEDTLS_SSL_DTLS_SRTP:" \ > + $(@D)/include/mbedtls/config.h > +endef > +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP > +endif > + > $(eval $(cmake-package)) > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support 2022-08-28 14:01 ` Yann E. MORIN @ 2022-08-28 14:36 ` Dmitry Ilyin 2022-08-28 15:53 ` Dmitry Ilyin 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Ilyin @ 2022-08-28 14:36 UTC (permalink / raw) To: Yann E. MORIN; +Cc: Fabrice Fontaine, buildroot [-- Attachment #1.1: Type: text/plain, Size: 3781 bytes --] I used git send-email origin/master command to submit the patch using http://underpop.online.fr/b/buildroot/en/submitting-patches.htm.gz manual. The original outgoing/0001-package-mbedtls-add-configurable-SRTP-support.patch file has Signed-off-by: line, but I have no idea how to use this old-school machinery to work properly to appear the line in the mail-list. About mentioned WebRTC library, this is https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/ that I plan to add on final step when its all dependencies will be resolved. вс, 28 авг. 2022 г. в 17:01, Yann E. MORIN <yann.morin.1998@free.fr>: > Dmitry, All, > > On 2022-08-28 16:05 +0300, Dmitry Ilyin spake thusly: > > This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS > > builds that support SRTP (required option for AWS WebRTC library) > > You need to sign-off your change: > https://buildroot.org/downloads/manual/manual.html#submitting-patches > > Also, what do you mean by "required option for AWS WebRTC library"? > > If you are referring to a package that is present in Buildroot, then > that package should also be fixed to select that option. The only > package I could find in Buildroot, that is both websocket-related and > uses mbedtls, is package/libwebsockets/. If that's what you were > refering to, then the conditin to use mbedtls should be changed (in a > separate, follow-up patch): > > -else ifeq ($(BR2_PACKAGE_MBEDTLS),y) > +else ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP),y) > > Regards, > Yann E. MORIN. > > > --- > > package/mbedtls/Config.in | 6 ++++++ > > package/mbedtls/mbedtls.mk | 8 ++++++++ > > 2 files changed, 14 insertions(+) > > > > diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in > > index a39ba65d98..f06a27fc5c 100644 > > --- a/package/mbedtls/Config.in > > +++ b/package/mbedtls/Config.in > > @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION > > sure CRIME and similar attacks are not applicable to your > > particular situation. > > > > +config BR2_PACKAGE_MBEDTLS_SRTP > > + bool "enable SRTP support" > > + help > > + Enable support for negotiation of DTLS-SRTP (RFC 5764) > > + through the use_srtp extension. > > + > > endif > > diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk > > index af87d62b30..9f9aee1fec 100644 > > --- a/package/mbedtls/mbedtls.mk > > +++ b/package/mbedtls/mbedtls.mk > > @@ -72,4 +72,12 @@ else ifeq > ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y) > > MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM > > endif > > > > +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y) > > +define MBEDTLS_ENABLE_SRTP > > + $(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define > MBEDTLS_SSL_DTLS_SRTP:" \ > > + $(@D)/include/mbedtls/config.h > > +endef > > +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP > > +endif > > + > > $(eval $(cmake-package)) > > -- > > 2.37.1 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > > '------------------------------^-------^------------------^--------------------' > -- Best regards, Dmitry Ilyin [-- Attachment #1.2: Type: text/html, Size: 5704 bytes --] [-- Attachment #2: Type: text/plain, Size: 150 bytes --] _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support 2022-08-28 14:36 ` Dmitry Ilyin @ 2022-08-28 15:53 ` Dmitry Ilyin 2022-08-28 18:59 ` Yann E. MORIN 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Ilyin @ 2022-08-28 15:53 UTC (permalink / raw) To: buildroot; +Cc: Dmitry Ilyin, Fabrice Fontaine This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS builds that support SRTP (required option for AWS WebRTC library) Signed-off-by: Dmitry Ilyin <dima@doty.ru> --- package/mbedtls/Config.in | 6 ++++++ package/mbedtls/mbedtls.mk | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in index a39ba65d98..f06a27fc5c 100644 --- a/package/mbedtls/Config.in +++ b/package/mbedtls/Config.in @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION sure CRIME and similar attacks are not applicable to your particular situation. +config BR2_PACKAGE_MBEDTLS_SRTP + bool "enable SRTP support" + help + Enable support for negotiation of DTLS-SRTP (RFC 5764) + through the use_srtp extension. + endif diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk index af87d62b30..9f9aee1fec 100644 --- a/package/mbedtls/mbedtls.mk +++ b/package/mbedtls/mbedtls.mk @@ -72,4 +72,12 @@ else ifeq ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y) MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM endif +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y) +define MBEDTLS_ENABLE_SRTP + $(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define MBEDTLS_SSL_DTLS_SRTP:" \ + $(@D)/include/mbedtls/config.h +endef +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP +endif + $(eval $(cmake-package)) -- 2.37.1 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support 2022-08-28 15:53 ` Dmitry Ilyin @ 2022-08-28 18:59 ` Yann E. MORIN 0 siblings, 0 replies; 5+ messages in thread From: Yann E. MORIN @ 2022-08-28 18:59 UTC (permalink / raw) To: Dmitry Ilyin; +Cc: Fabrice Fontaine, buildroot Dmitry, All, On 2022-08-28 18:53 +0300, Dmitry Ilyin spake thusly: > This adds new BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT option to have MbedTLS > builds that support SRTP (required option for AWS WebRTC library) I've slightly reworded the commit log. > Signed-off-by: Dmitry Ilyin <dima@doty.ru> > --- > package/mbedtls/Config.in | 6 ++++++ > package/mbedtls/mbedtls.mk | 8 ++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/package/mbedtls/Config.in b/package/mbedtls/Config.in > index a39ba65d98..f06a27fc5c 100644 > --- a/package/mbedtls/Config.in > +++ b/package/mbedtls/Config.in > @@ -29,4 +29,10 @@ config BR2_PACKAGE_MBEDTLS_COMPRESSION > sure CRIME and similar attacks are not applicable to your > particular situation. > > +config BR2_PACKAGE_MBEDTLS_SRTP I've renamed the option to BR2_PACKAGE_MBEDTLS_DTLS_SRTP because this is what it drives: support for DTLS-SRTP. > + bool "enable SRTP support" > + help > + Enable support for negotiation of DTLS-SRTP (RFC 5764) > + through the use_srtp extension. > + > endif > diff --git a/package/mbedtls/mbedtls.mk b/package/mbedtls/mbedtls.mk > index af87d62b30..9f9aee1fec 100644 > --- a/package/mbedtls/mbedtls.mk > +++ b/package/mbedtls/mbedtls.mk > @@ -72,4 +72,12 @@ else ifeq ($(BR2_microblaze)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y) > MBEDTLS_POST_CONFIGURE_HOOKS += MBEDTLS_DISABLE_ASM > endif > > +ifeq ($(BR2_PACKAGE_MBEDTLS_SRTP_SUPPORT),y) The variable was not what it is named in the Config.in. Anyway, I also renamed it accordingly. > +define MBEDTLS_ENABLE_SRTP And I have also renamed the hook. Applied to next, thanks. Regards, Yann E. MORIN. > + $(SED) "s://#define MBEDTLS_SSL_DTLS_SRTP:#define MBEDTLS_SSL_DTLS_SRTP:" \ > + $(@D)/include/mbedtls/config.h > +endef > +MBEDTLS_POST_PATCH_HOOKS += MBEDTLS_ENABLE_SRTP > +endif > + > $(eval $(cmake-package)) > -- > 2.37.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-28 18:59 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-08-28 13:05 [Buildroot] [PATCH] package/mbedtls: add configurable SRTP support Dmitry Ilyin 2022-08-28 14:01 ` Yann E. MORIN 2022-08-28 14:36 ` Dmitry Ilyin 2022-08-28 15:53 ` Dmitry Ilyin 2022-08-28 18:59 ` Yann E. MORIN
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox