Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Julien Corjon <corjon.j@ecagroup.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use
Date: Wed, 28 Sep 2022 22:55:27 +0200	[thread overview]
Message-ID: <20220928205527.GH1419013@scaer> (raw)
In-Reply-To: <20220928202429.461673-1-giulio.benetti@benettiengineering.com>

Giulio, All,

On 2022-09-28 22:24 +0200, Giulio Benetti spake thusly:
> Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check
> if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that
> could be openssl or libressl) and for qt5enginio and qt5webkit let's select
> specifically BR2_PACKAGE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL.
> This way we make sure that only openssl is selected and not libressl or
> other future openssl-like implementations.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/
> 
> [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support
> [1]: https://bugreports.qt.io/browse/QTBUG-68374
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  package/qt5/qt5base/qt5base.mk   | 4 ++--
>  package/qt5/qt5enginio/Config.in | 1 +
>  package/qt5/qt5webkit/Config.in  | 1 +
>  3 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index a81892422c..efa0e16e9a 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -229,8 +229,8 @@ else
>  QT5BASE_CONFIGURE_OPTS += -no-eglfs
>  endif
>  
> -QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_OPENSSL),-openssl,-no-openssl)
> -QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_OPENSSL),openssl)
> +QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl)
> +QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl)
>  
>  QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig)
>  QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig)
> diff --git a/package/qt5/qt5enginio/Config.in b/package/qt5/qt5enginio/Config.in
> index b738f0db7c..d421972392 100644
> --- a/package/qt5/qt5enginio/Config.in
> +++ b/package/qt5/qt5enginio/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_QT5ENGINIO
>  	bool "qt5enginio"
>  	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5

BR2_PACKAGE_LIBOPENSSL is part of a choice, so you can't select it.

However, you can achieve the same with:
    select BR2_PACKAGE_OPENSSL
    select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL

By the way, we have a single package, gitlab-runner, that selects
BR2_PACKAGE_LIBOPENSSL, so this should be fixed.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_QT5BASE_GUI
>  	select BR2_PACKAGE_QT5BASE_NETWORK
>  	help
> diff --git a/package/qt5/qt5webkit/Config.in b/package/qt5/qt5webkit/Config.in
> index 26c3897d1d..035e8b19b8 100644
> --- a/package/qt5/qt5webkit/Config.in
> +++ b/package/qt5/qt5webkit/Config.in
> @@ -16,6 +16,7 @@ config BR2_PACKAGE_QT5WEBKIT
>  	select BR2_PACKAGE_LEVELDB
>  	select BR2_PACKAGE_LIBPNG
>  	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBOPENSSL # Only openssl is supported by qt5
>  	select BR2_PACKAGE_QT5BASE_ICU
>  	select BR2_PACKAGE_QT5BASE_GUI
>  	select BR2_PACKAGE_QT5BASE_WIDGETS
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-28 20:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 20:24 [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use Giulio Benetti
2022-09-28 20:55 ` Yann E. MORIN [this message]
2022-09-28 21:25   ` Giulio Benetti
2022-09-29 10:46   ` [Buildroot] [PATCH v2] " Giulio Benetti
2023-02-06 22:45     ` Thomas Petazzoni via buildroot
2023-02-22 19:52       ` Peter Korsgaard
2022-09-29 11:18   ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti
2022-09-29 11:20     ` Giulio Benetti
2022-10-01 16:30       ` Yann E. MORIN
2022-10-01 16:29     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928205527.GH1419013@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=giulio.benetti@benettiengineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox