Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Marcin Niestroj <m.niestroj@grinn-global.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl
Date: Sat, 1 Oct 2022 18:29:29 +0200	[thread overview]
Message-ID: <20221001162929.GD30794@scaer> (raw)
In-Reply-To: <20220929111816.497911-1-giulio.benetti@benettiengineering.com>

Giulio, All,

On 2022-09-29 13:18 +0200, Giulio Benetti spake thusly:
> BR2_PACKAGE_LIBOPENSSL doesn't force selecting libopenssl, to achieve this
> we need to use BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL. So let's modify
> accordingly and improve a bit the comment.

I've reworded the commit log, and drop the comment change: the symbol
name is explicit enough as to what it does.

> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/gitlab-runner/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/gitlab-runner/Config.in b/package/gitlab-runner/Config.in
> index 72c2742562..bfa79ac80e 100644
> --- a/package/gitlab-runner/Config.in
> +++ b/package/gitlab-runner/Config.in
> @@ -13,7 +13,7 @@ config BR2_PACKAGE_GITLAB_RUNNER
>  	select BR2_PACKAGE_LIBCURL_CURL # runtime
>  	select BR2_PACKAGE_LIBCURL_OPENSSL # runtime, for ca-certificates.
>  	select BR2_PACKAGE_OPENSSL # runtime
> -	select BR2_PACKAGE_LIBOPENSSL # runtime
> +	select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL # runtime, force using libopenssl
>  	select BR2_PACKAGE_LIBOPENSSL_BIN # runtime
>  	select BR2_PACKAGE_TAR # runtime
>  	help
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2022-10-01 16:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 20:24 [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use Giulio Benetti
2022-09-28 20:55 ` Yann E. MORIN
2022-09-28 21:25   ` Giulio Benetti
2022-09-29 10:46   ` [Buildroot] [PATCH v2] " Giulio Benetti
2023-02-06 22:45     ` Thomas Petazzoni via buildroot
2023-02-22 19:52       ` Peter Korsgaard
2022-09-29 11:18   ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti
2022-09-29 11:20     ` Giulio Benetti
2022-10-01 16:30       ` Yann E. MORIN
2022-10-01 16:29     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221001162929.GD30794@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=m.niestroj@grinn-global.com \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox