From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
Julien Corjon <corjon.j@ecagroup.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2] package/qt5: fix build failure due to libressl use
Date: Wed, 22 Feb 2023 20:52:24 +0100 [thread overview]
Message-ID: <87o7plqxzb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20230206234520.4a140264@windsurf> (Thomas Petazzoni via buildroot's message of "Mon, 6 Feb 2023 23:45:20 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Thu, 29 Sep 2022 12:46:48 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>> Qt5 only supports openssl, check [0] and [1]. So in qt5base.mk let's check
>> if BR2_PACKAGE_LIBOPENSSL is enabled instead of BR2_PACKAGE_OPENSSL(that
>> could be openssl or libressl) and for qt5enginio and qt5webkit let's select
>> BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of only BR2_PACKAGE_OPENSSL.
>> This way we make sure that only openssl is selected and not libressl or
>> other future openssl-like implementations.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/a956b48b782dbaa055d7146360465e2493a809d9/
>>
>> [0]: https://doc.qt.io/qt-5/ssl.html#enabling-and-disabling-ssl-support
>> [1]: https://bugreports.qt.io/browse/QTBUG-68374
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
V1-> V2:
>> * select BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL instead of BR2_PACKAGE_LIBOPENSSL
>> ---
>> package/qt5/qt5base/qt5base.mk | 4 ++--
>> package/qt5/qt5enginio/Config.in | 1 +
>> package/qt5/qt5webkit/Config.in | 1 +
>> 3 files changed, 4 insertions(+), 2 deletions(-)
> Applied to master, thanks.
Committed to 2022.11.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-22 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 20:24 [Buildroot] [PATCH] package/qt5: fix build failure due to libressl use Giulio Benetti
2022-09-28 20:55 ` Yann E. MORIN
2022-09-28 21:25 ` Giulio Benetti
2022-09-29 10:46 ` [Buildroot] [PATCH v2] " Giulio Benetti
2023-02-06 22:45 ` Thomas Petazzoni via buildroot
2023-02-22 19:52 ` Peter Korsgaard [this message]
2022-09-29 11:18 ` [Buildroot] [PATCH] package/gitlab-runner: fix forcing openssl Giulio Benetti
2022-09-29 11:20 ` Giulio Benetti
2022-10-01 16:30 ` Yann E. MORIN
2022-10-01 16:29 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7plqxzb.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=corjon.j@ecagroup.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox