* [Buildroot] [PATCH 1/7] package/rtl8189es: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 2/7] package/rtl8189fs: " Giulio Benetti
` (6 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Fixes:
http://autobuild.buildroot.net/results/693053491ba61edcff0f75a4f30c13958e7e12ce/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8189es/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8189es/Config.in b/package/rtl8189es/Config.in
index 2e3474e5e1..11dd225436 100644
--- a/package/rtl8189es/Config.in
+++ b/package/rtl8189es/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_RTL8189ES
bool "rtl8189es"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
Wireless driver rtl8189es.
@@ -7,4 +8,5 @@ config BR2_PACKAGE_RTL8189ES
https://github.com/jwrdegoede/rtl8189ES_linux.git
comment "rtl8189es needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 2/7] package/rtl8189fs: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
2022-10-26 13:26 ` [Buildroot] [PATCH 1/7] package/rtl8189es: disable package for s390x architecture Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 3/7] package/rtl8723bu: " Giulio Benetti
` (5 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8189fs/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8189fs/Config.in b/package/rtl8189fs/Config.in
index ae69b79235..78eeed1a4f 100644
--- a/package/rtl8189fs/Config.in
+++ b/package/rtl8189fs/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_RTL8189FS
bool "rtl8189fs"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
Wireless driver rtl8189fs.
@@ -7,4 +8,5 @@ config BR2_PACKAGE_RTL8189FS
https://github.com/jwrdegoede/rtl8189ES_linux.git
comment "rtl8189fs needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 3/7] package/rtl8723bu: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
2022-10-26 13:26 ` [Buildroot] [PATCH 1/7] package/rtl8189es: disable package for s390x architecture Giulio Benetti
2022-10-26 13:26 ` [Buildroot] [PATCH 2/7] package/rtl8189fs: " Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 4/7] package/rtl8723ds: " Giulio Benetti
` (4 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8723bu/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8723bu/Config.in b/package/rtl8723bu/Config.in
index 266a794a7d..7c624fc4d4 100644
--- a/package/rtl8723bu/Config.in
+++ b/package/rtl8723bu/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_RTL8723BU
bool "rtl8723bu"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
rtl8723bu wifi driver
@@ -7,4 +8,5 @@ config BR2_PACKAGE_RTL8723BU
https://github.com/lwfinger/rtl8723bu
comment "rtl8723bu needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 4/7] package/rtl8723ds: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
` (2 preceding siblings ...)
2022-10-26 13:26 ` [Buildroot] [PATCH 3/7] package/rtl8723bu: " Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 5/7] package/rtl8812au-aircrack-ng: " Giulio Benetti
` (3 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8723ds/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8723ds/Config.in b/package/rtl8723ds/Config.in
index ef7dd39a68..e5123a2aae 100644
--- a/package/rtl8723ds/Config.in
+++ b/package/rtl8723ds/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_RTL8723DS
bool "rtl8723ds"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
rtl8723bs wifi driver
@@ -7,4 +8,5 @@ config BR2_PACKAGE_RTL8723DS
https://github.com/lwfinger/rtl8723ds
comment "rtl8723ds needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 5/7] package/rtl8812au-aircrack-ng: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
` (3 preceding siblings ...)
2022-10-26 13:26 ` [Buildroot] [PATCH 4/7] package/rtl8723ds: " Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 6/7] package/rtl8821au: " Giulio Benetti
` (2 subsequent siblings)
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8812au-aircrack-ng/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8812au-aircrack-ng/Config.in b/package/rtl8812au-aircrack-ng/Config.in
index 70cbd15221..d903ab2b3f 100644
--- a/package/rtl8812au-aircrack-ng/Config.in
+++ b/package/rtl8812au-aircrack-ng/Config.in
@@ -1,8 +1,10 @@
comment "rtl8812au-aircrack-ng needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
config BR2_PACKAGE_RTL8812AU_AIRCRACK_NG
bool "rtl8812au-aircrack-ng"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
rtl8812au wifi driver (aircrack-ng repository)
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 6/7] package/rtl8821au: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
` (4 preceding siblings ...)
2022-10-26 13:26 ` [Buildroot] [PATCH 5/7] package/rtl8812au-aircrack-ng: " Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 13:26 ` [Buildroot] [PATCH 7/7] package/wilc-driver: " Giulio Benetti
2022-10-26 19:53 ` [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Thomas Petazzoni via buildroot
7 siblings, 1 reply; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/rtl8821au/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/rtl8821au/Config.in b/package/rtl8821au/Config.in
index 87c191b22a..3d7bbf643d 100644
--- a/package/rtl8821au/Config.in
+++ b/package/rtl8821au/Config.in
@@ -1,8 +1,10 @@
comment "rtl8821au needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
config BR2_PACKAGE_RTL8821AU
bool "rtl8821au"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
rtl8821au wifi driver
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
` (5 preceding siblings ...)
2022-10-26 13:26 ` [Buildroot] [PATCH 6/7] package/rtl8821au: " Giulio Benetti
@ 2022-10-26 13:26 ` Giulio Benetti
2022-10-26 17:32 ` Kris Bahnsen via buildroot
2022-11-06 10:04 ` Peter Korsgaard
2022-10-26 19:53 ` [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Thomas Petazzoni via buildroot
7 siblings, 2 replies; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 13:26 UTC (permalink / raw)
To: buildroot
Cc: Louis Aussedat, Sergey Matyukevich, Angelo Compagnucci,
Giulio Benetti, Kris Bahnsen
s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
package for this architecture.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/wilc-driver/Config.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
index 7ed062bb66..7f970bd38b 100644
--- a/package/wilc-driver/Config.in
+++ b/package/wilc-driver/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_WILC_DRIVER
bool "wilc kernel module"
+ depends on !BR2_s390x
depends on BR2_LINUX_KERNEL
help
External kernel module for WILC1000/3000 devices.
@@ -59,4 +60,5 @@ endif
endif
comment "wilc kernel module needs a Linux kernel to be built"
+ depends on !BR2_s390x
depends on !BR2_LINUX_KERNEL
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
2022-10-26 13:26 ` [Buildroot] [PATCH 7/7] package/wilc-driver: " Giulio Benetti
@ 2022-10-26 17:32 ` Kris Bahnsen via buildroot
2022-10-26 17:53 ` Giulio Benetti
2022-10-26 18:11 ` Giulio Benetti
2022-11-06 10:04 ` Peter Korsgaard
1 sibling, 2 replies; 19+ messages in thread
From: Kris Bahnsen via buildroot @ 2022-10-26 17:32 UTC (permalink / raw)
To: Giulio Benetti, buildroot
Cc: Louis Aussedat, Angelo Compagnucci, Sergey Matyukevich
On Wed, 2022-10-26 at 15:26 +0200, Giulio Benetti wrote:
> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
> package for this architecture.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/wilc-driver/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
> index 7ed062bb66..7f970bd38b 100644
> --- a/package/wilc-driver/Config.in
> +++ b/package/wilc-driver/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_WILC_DRIVER
> bool "wilc kernel module"
> + depends on !BR2_s390x
> depends on BR2_LINUX_KERNEL
> help
> External kernel module for WILC1000/3000 devices.
> @@ -59,4 +60,5 @@ endif
> endif
>
> comment "wilc kernel module needs a Linux kernel to be built"
> + depends on !BR2_s390x
> depends on !BR2_LINUX_KERNEL
I don't know much on the s390x arch, nor Buildroot paradigms for disabling packages
per-architecture, however the change itself looks good to me.
Reviewed-by: Kris Bahnsen <kris@embeddedTS.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
2022-10-26 17:32 ` Kris Bahnsen via buildroot
@ 2022-10-26 17:53 ` Giulio Benetti
2022-10-26 18:11 ` Giulio Benetti
1 sibling, 0 replies; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 17:53 UTC (permalink / raw)
To: kris; +Cc: Louis Aussedat, Angelo Compagnucci, Sergey Matyukevich, buildroot
[-- Attachment #1.1.1: Type: text/html, Size: 16305 bytes --]
[-- Attachment #1.1.2: favicon.ico --]
[-- Type: image/vnd.microsoft.icon, Size: 766 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
2022-10-26 17:32 ` Kris Bahnsen via buildroot
2022-10-26 17:53 ` Giulio Benetti
@ 2022-10-26 18:11 ` Giulio Benetti
1 sibling, 0 replies; 19+ messages in thread
From: Giulio Benetti @ 2022-10-26 18:11 UTC (permalink / raw)
To: kris, buildroot; +Cc: Louis Aussedat, Angelo Compagnucci, Sergey Matyukevich
Hi Kris, All,
sorry for my previous HTML e-mail,
On 26/10/22 19:32, Kris Bahnsen via buildroot wrote:
> On Wed, 2022-10-26 at 15:26 +0200, Giulio Benetti wrote:
>> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
>> package for this architecture.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/wilc-driver/Config.in | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/package/wilc-driver/Config.in b/package/wilc-driver/Config.in
>> index 7ed062bb66..7f970bd38b 100644
>> --- a/package/wilc-driver/Config.in
>> +++ b/package/wilc-driver/Config.in
>> @@ -1,5 +1,6 @@
>> config BR2_PACKAGE_WILC_DRIVER
>> bool "wilc kernel module"
>> + depends on !BR2_s390x
>> depends on BR2_LINUX_KERNEL
>> help
>> External kernel module for WILC1000/3000 devices.
>> @@ -59,4 +60,5 @@ endif
>> endif
>>
>> comment "wilc kernel module needs a Linux kernel to be built"
>> + depends on !BR2_s390x
>> depends on !BR2_LINUX_KERNEL
>
> I don't know much on the s390x arch, nor Buildroot paradigms for disabling packages
> per-architecture, however the change itself looks good to me.
If you check here:
https://elixir.bootlin.com/linux/latest/source/net/Kconfig#L371
You will see that Linux Wireless subsystem is activated only when s390x
is not enabled.
This also created a build failure with another rtlxxxx driver due to that:
http://autobuild.buildroot.net/results/693053491ba61edcff0f75a4f30c13958e7e12ce/
This is why I came in with this patchset that prevents that kind of
build failure.
> Reviewed-by: Kris Bahnsen <kris@embeddedTS.com>
Thank you
Best regards
--
Giulio Benetti
Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Buildroot] [PATCH 7/7] package/wilc-driver: disable package for s390x architecture
2022-10-26 13:26 ` [Buildroot] [PATCH 7/7] package/wilc-driver: " Giulio Benetti
2022-10-26 17:32 ` Kris Bahnsen via buildroot
@ 2022-11-06 10:04 ` Peter Korsgaard
1 sibling, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2022-11-06 10:04 UTC (permalink / raw)
To: Giulio Benetti
Cc: Louis Aussedat, Angelo Compagnucci, Kris Bahnsen,
Sergey Matyukevich, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> s390x doesn't support CONFIG_WIRELESS in Linux so let's disable this
> package for this architecture.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x
2022-10-26 13:26 [Buildroot] [PATCH 0/7] Disable packages with CONFIG_WIRELESS on s390x Giulio Benetti
` (6 preceding siblings ...)
2022-10-26 13:26 ` [Buildroot] [PATCH 7/7] package/wilc-driver: " Giulio Benetti
@ 2022-10-26 19:53 ` Thomas Petazzoni via buildroot
7 siblings, 0 replies; 19+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-10-26 19:53 UTC (permalink / raw)
To: Giulio Benetti
Cc: Louis Aussedat, Angelo Compagnucci, Kris Bahnsen,
Sergey Matyukevich, buildroot
On Wed, 26 Oct 2022 15:26:27 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Linux s390x doesn't support CONFIG_WIRELESS so this patchset disable
> all packages with Linux CONFIG_WIRELESS for s390x architecture.
>
> Giulio Benetti (7):
> package/rtl8189es: disable package for s390x architecture
> package/rtl8189fs: disable package for s390x architecture
> package/rtl8723bu: disable package for s390x architecture
> package/rtl8723ds: disable package for s390x architecture
> package/rtl8812au-aircrack-ng: disable package for s390x architecture
> package/rtl8821au: disable package for s390x architecture
> package/wilc-driver: disable package for s390x architecture
When I saw this, initially I was a bit "meh", and wondered if some more
generic mechanism wouldn't be more relevant, like a
BR2_LINUX_KERNEL_SUPPORTS_WIRELESS or something like this. But then I
thought that this is the first case for which we have a situation like
that, so we're not sure what other cases will look like.
So for now, I applied your patches as-is, and we can revisit later if
we identify similar issues that would encourage us in finding a more
generic solution to the problem.
So: all patches applied as-is. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 19+ messages in thread