Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Anand Gadiyar via buildroot <buildroot@buildroot.org>
Cc: Bryan Brattlof <bb@ti.com>, Andrew Davis <afd@ti.com>,
	Xuanhao Shi <X15000177@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Romain Naour <romain.naour@gmail.com>,
	Anand Gadiyar <gadiyar@ti.com>
Subject: Re: [Buildroot] [PATCH v7 1/3] boot/ti-k3-r5-loader: add new package
Date: Sun, 11 Dec 2022 21:06:00 +0100	[thread overview]
Message-ID: <20221211210600.38a372a8@windsurf> (raw)
In-Reply-To: <20221206171719.747581-2-gadiyar@ti.com>

On Tue, 6 Dec 2022 11:17:17 -0600
Anand Gadiyar via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/boot/ti-k3-r5-loader/Config.in b/boot/ti-k3-r5-loader/Config.in
> new file mode 100644
> index 0000000000..bb6140f8a6
> --- /dev/null
> +++ b/boot/ti-k3-r5-loader/Config.in
> @@ -0,0 +1,32 @@
> +config BR2_TARGET_TI_K3_R5_LOADER
> +	bool "ti-k3-r5-loader"

Added:

	depends on BR2_aarch64

> +	help
> +	  Separate U-Boot build for R5 cores on TI's k3 boards.
> +	  Usually used to build tiboot3.bin with k3-image-gen.
> +
> +if BR2_TARGET_TI_K3_R5_LOADER
> +choice
> +	prompt "K3 R5 Loader configuration"

Simplified to just "Configuration".


> diff --git a/boot/ti-k3-r5-loader/ti-k3-r5-loader.hash b/boot/ti-k3-r5-loader/ti-k3-r5-loader.hash
> new file mode 100644
> index 0000000000..fb6ce7c2a6
> --- /dev/null
> +++ b/boot/ti-k3-r5-loader/ti-k3-r5-loader.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256  6d69d5e4635cb3fa7852bf15f88ca342ef7740196e71961d3572deb58ba44bea  u-boot-2022.10-rc1.tar.bz2

You didn't test the build, as this hash file doesn't match the .mk
file: the .mk file refers to 2022.10, the hash file to 2022.10-rc1.

Another thing: the hash of the license file was missing.

I fixed up those small issues, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-12-11 20:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 17:17 [Buildroot] [PATCH v7 0/3] add support for TI's AM64x boards Anand Gadiyar via buildroot
2022-12-06 17:17 ` [Buildroot] [PATCH v7 1/3] boot/ti-k3-r5-loader: add new package Anand Gadiyar via buildroot
2022-12-06 20:18   ` François Perrad
2022-12-11 20:06   ` Thomas Petazzoni via buildroot [this message]
2022-12-06 17:17 ` [Buildroot] [PATCH v7 2/3] boot/ti-k3-image-gen: " Anand Gadiyar via buildroot
2022-12-06 20:19   ` François Perrad
2022-12-11 20:09   ` Thomas Petazzoni via buildroot
2022-12-11 20:41     ` François Perrad
2022-12-11 21:22       ` Thomas Petazzoni via buildroot
2022-12-12 22:35         ` Gadiyar, Anand via buildroot
2022-12-19 20:56   ` Julien Olivain
2022-12-06 17:17 ` [Buildroot] [PATCH v7 3/3] board/ti/am64x_sk: add new board Anand Gadiyar via buildroot
2022-12-06 20:19   ` François Perrad
2022-12-11 20:12   ` Thomas Petazzoni via buildroot
2022-12-19 21:12   ` Julien Olivain
2022-12-20 19:29     ` Gadiyar, Anand via buildroot
     [not found]       ` <20230608063000.882363-1-patrick.oppenlander@gmail.com>
2023-06-08 13:29         ` [Buildroot] [PATCH v7 0/3] add support for TI's AM64x boards Gadiyar, Anand via buildroot
2023-06-08 15:59           ` Andreas Dannenberg via buildroot
2023-06-13  5:56             ` Patrick Oppenlander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221211210600.38a372a8@windsurf \
    --to=buildroot@buildroot.org \
    --cc=X15000177@gmail.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=gadiyar@ti.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox