Re: [Buildroot] [PATCH v7 2/3] boot/ti-k3-image-gen: add new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Tue, 6 Dec 2022 11:17:18 -0600
Anand Gadiyar via buildroot <buildroot@buildroot.org> wrote:

> From: Xuanhao Shi <x-shi@ti.com>
> 
> This is the image generator that builds the full boot binary,
> tiboot3.bin, for the R5 core on TI's k3 devices.
> This requires the R5 spl output from the ti-k3-r5-loader package.
> 
> https://git.ti.com/cgit/k3-image-gen/k3-image-gen

The commit title should just be:

	boot/ti-k3-image-gen: new package

(not "add new package")


> diff --git a/boot/ti-k3-image-gen/Config.in b/boot/ti-k3-image-gen/Config.in
> new file mode 100644
> index 0000000000..02018f2f78
> --- /dev/null
> +++ b/boot/ti-k3-image-gen/Config.in
> @@ -0,0 +1,30 @@
> +config BR2_TARGET_TI_K3_IMAGE_GEN
> +	bool "ti-k3-image-gen"
> +	select BR2_TARGET_TI_K3_R5_LOADER

Should be a:

	depends on BR2_TARGET_TI_K3_R5_LOADER

> +if BR2_TARGET_TI_K3_IMAGE_GEN
> +config BR2_TARGET_TI_K3_IMAGE_GEN_SOC
> +	string "SOC type for image gen"

	string "SoC"

> +	help
> +	  The target SoC option for image gen.
> +	  For example, "am64x" for AM64X boards.
> +
> +config BR2_TARGET_TI_K3_IMAGE_GEN_SOC_TYPE
> +	string "SOC security type for image gen"

	string "SoC security type"

> +	help
> +	  The security type option for image gen.
> +	  Options are "gp", "hs-fs", or "hs-se".
> +
> +config BR2_TARGET_TI_K3_IMAGE_GEN_CONFIG
> +	string "CONFIG type for image gen"

	string "config type"


> +define TI_K3_IMAGE_GEN_BUILD_CMDS
> +	$(TI_K3_IMAGE_GEN_MAKE) -C $(@D) $(TI_K3_IMAGE_GEN_MAKE_OPTS)
> +endef

There is a serious problem: the build process of this package downloads
stuff:

Connecting to git.ti.com (git.ti.com)|198.47.28.208|:443... connected.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/blobs/raw/59d6f921b3b562e0aa1f42ce322e4645b1bfc52c/ti-sysfw/ti-sci-firmware-am64x-gp.bin [following]
--2022-12-11 20:53:58--  https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/blobs/raw/59d6f921b3b562e0aa1f42ce322e4645b1bfc52c/ti-sysfw/ti-sci-firmware-am64x-gp.bin
Reusing existing connection to git.ti.com:443.
HTTP request sent, awaiting response... 301 Moved Permanently
Location: https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/plain/ti-sysfw/ti-sci-firmware-am64x-gp.bin?id=59d6f921b3b562e0aa1f42ce322e4645b1bfc52c [following]
--2022-12-11 20:53:59--  https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/plain/ti-sysfw/ti-sci-firmware-am64x-gp.bin?id=59d6f921b3b562e0aa1f42ce322e4645b1bfc52c
Reusing existing connection to git.ti.com:443.
HTTP request sent, awaiting response... 200 OK
Length: 225248 (220K) [application/octet-stream]
Saving to: ‘ti-sci-firmware-am64x-gp.bin’

ti-sci-firmware-am64x-gp.bin  100%[==============================================>] 219,97K   114KB/s    in 1,9s    

2022-12-11 20:54:01 (114 KB/s) - ‘ti-sci-firmware-am64x-gp.bin’ saved [225248/225248]

Download SUCCESS!

This is not acceptable as it circumvents the download infrastructure of
Buildroot, but also the legal information collection infrastructure.

This needs to be fixed by downloading this file, either through a
separate package, or as an _EXTRA_DOWNLOADS of this package, and the
Makefile needs to be changed to not download this file. My impression
is that the Makefile will not download the files if they are already
available. So you could have _EXTRA_DOWNLOADS + some post-extract logic
to put the files at the right place.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot