Re: [Buildroot] [PATCH v7 3/3] board/ti/am64x_sk: add new board

["Gadiyar, Anand via buildroot" <buildroot@buildroot.org>]

> From: Julien Olivain <ju.o@free.fr>


> > +
> > +These configurations will build a complete image and
> > +device tree blobs for the the TI AM64x_sk board.
> 
> To avoid confusion between SK-AM64 and SK-AM64B, I suggest:
> 
> 1. to add the board url in this readme.txt, for example,
> using the same comment as in the commit log:
> """
> More information about the board can be found at:
> https://www.ti.com/tool/SK-AM64
> """
> 
> 2. add a note that:
> This configuration is for SK-AM64 only, since it's including:
> BR2_TARGET_TI_K3_IMAGE_GEN_SOC_TYPE="gp"
> The SK-AM64B [2] is not supported, as it would require "hs-fs".
> 
> [2] https://www.ti.com/tool/SK-AM64B
> 

Thanks for the review Julien!

The SK-AM64B wasn't around when we submitted the first patchset.
I expected a follow on patch to add the hs-fs support properly.

I'll clarify in the next revision that this series is for GP only. We'll need
some work to get the SK-AM64B supported and tested, and I'll try and
get that enabled after this initial series is merged.

I'll post a new series shortly with changes addressing review comments
from you and Thomas

- Anand
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot