[Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Fabrice Fontaine]

libdeflate is an optional dependency which is enabled by default since
version 4.2.0 and
https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/tiff/Config.in | 6 ++++++
 package/tiff/tiff.mk   | 7 +++++++
 2 files changed, 13 insertions(+)

diff --git a/package/tiff/Config.in b/package/tiff/Config.in
index f842c2ead8..58e2052ea5 100644
--- a/package/tiff/Config.in
+++ b/package/tiff/Config.in
@@ -11,6 +11,12 @@ config BR2_PACKAGE_TIFF_CCITT
 	bool "CCITT Group 3 & 4 support"
 	default y
 
+config BR2_PACKAGE_TIFF_LIBDEFLATE
+	bool "Libdeflate usage (still requires Zlib)"
+	default y
+	select BR2_PACKAGE_LIBDEFLATE
+	select BR2_PACKAGE_TIFF_ZLIB
+
 config BR2_PACKAGE_TIFF_PACKBITS
 	bool "Macintosh PackBits algorithm"
 	default y
diff --git a/package/tiff/tiff.mk b/package/tiff/tiff.mk
index 7981bdf2c9..a753065fde 100644
--- a/package/tiff/tiff.mk
+++ b/package/tiff/tiff.mk
@@ -33,6 +33,13 @@ ifneq ($(BR2_PACKAGE_TIFF_CCITT),y)
 TIFF_CONF_OPTS += --disable-ccitt
 endif
 
+ifeq ($(BR2_PACKAGE_TIFF_LIBDEFLATE),y)
+TIFF_CONF_OPTS += --enable-libdeflate
+TIFF_DEPENDENCIES += libdeflate
+else
+TIFF_CONF_OPTS += --disable-libdeflate
+endif
+
 ifneq ($(BR2_PACKAGE_TIFF_PACKBITS),y)
 TIFF_CONF_OPTS += --disable-packbits
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Thomas Petazzoni via buildroot]

On Thu, 22 Dec 2022 17:51:17 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libdeflate is an optional dependency which is enabled by default since
> version 4.2.0 and
> https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/tiff/Config.in | 6 ++++++
>  package/tiff/tiff.mk   | 7 +++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/tiff/Config.in b/package/tiff/Config.in
> index f842c2ead8..58e2052ea5 100644
> --- a/package/tiff/Config.in
> +++ b/package/tiff/Config.in
> @@ -11,6 +11,12 @@ config BR2_PACKAGE_TIFF_CCITT
>  	bool "CCITT Group 3 & 4 support"
>  	default y
>  
> +config BR2_PACKAGE_TIFF_LIBDEFLATE
> +	bool "Libdeflate usage (still requires Zlib)"
> +	default y

Is there any reason to have this "default y"? We normally try to
disable optional features by default, especially if they bring extra
dependencies.

I see it's a policy that has not been really applied to the tiff
package, but I'm wondering if there's a particular reason to not apply
our normal policy to this new option?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

Hello,


Le mar. 27 déc. 2022 à 22:35, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a écrit :

> On Thu, 22 Dec 2022 17:51:17 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > libdeflate is an optional dependency which is enabled by default since
> > version 4.2.0 and
> >
> https://gitlab.com/libtiff/libtiff/-/commit/3a2de853a932bd0ea79d1677d319841edb736c38
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/tiff/Config.in | 6 ++++++
> >  package/tiff/tiff.mk   | 7 +++++++
> >  2 files changed, 13 insertions(+)
> >
> > diff --git a/package/tiff/Config.in b/package/tiff/Config.in
> > index f842c2ead8..58e2052ea5 100644
> > --- a/package/tiff/Config.in
> > +++ b/package/tiff/Config.in
> > @@ -11,6 +11,12 @@ config BR2_PACKAGE_TIFF_CCITT
> >       bool "CCITT Group 3 & 4 support"
> >       default y
> >
> > +config BR2_PACKAGE_TIFF_LIBDEFLATE
> > +     bool "Libdeflate usage (still requires Zlib)"
> > +     default y
>
> Is there any reason to have this "default y"? We normally try to
> disable optional features by default, especially if they bring extra
> dependencies.
>
> I see it's a policy that has not been really applied to the tiff
> package, but I'm wondering if there's a particular reason to not apply
> our normal policy to this new option?
>

I decided to enable it by default for backward compatibility and because
(for an unknown reason) most tiff options are enabled by default but I can
send a v2 if needed.


>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 2875 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Thomas Petazzoni via buildroot]

On Tue, 27 Dec 2022 22:40:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> > I see it's a policy that has not been really applied to the tiff
> > package, but I'm wondering if there's a particular reason to not apply
> > our normal policy to this new option?
> 
> I decided to enable it by default for backward compatibility and because
> (for an unknown reason) most tiff options are enabled by default but I can
> send a v2 if needed.

Could you expand a bit on the backward compatibility reason? Is that
feature today enabled by default?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/tiff: add libdeflate optional dependency

[Fabrice Fontaine]

[-- Attachment #1.1: Type: text/plain, Size: 1266 bytes --]

Le mar. 27 déc. 2022 à 22:44, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a écrit :

> On Tue, 27 Dec 2022 22:40:52 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > > I see it's a policy that has not been really applied to the tiff
> > > package, but I'm wondering if there's a particular reason to not apply
> > > our normal policy to this new option?
> >
> > I decided to enable it by default for backward compatibility and because
> > (for an unknown reason) most tiff options are enabled by default but I
> can
> > send a v2 if needed.
>
> Could you expand a bit on the backward compatibility reason? Is that
> feature today enabled by default?
>

Yes, as I wrote in the commit message, libdeflate is enabled by default
since its addition in version 4.2.0.
However, obviously, libdeflate has to be built before tiff and libdeflate
has only been added to buildroot in August so I assume that most of the
time tiff is built without libdeflate support.
So, disabling it by default as you suggested is probably better.


>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com


Best Regards,

Fabrice

[-- Attachment #1.2: Type: text/html, Size: 2027 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot